* Better logging and error reporting.
* Preconditions for FollowerInfo.
* Preconditions when updating Current as leader.
* Change a log level.
* Fix unit tests.
* CHANGELOG.
* LOG_TOPIC ids.
* Fix a log id.
* Fix Windows compilation.
* Fixed case where a SmartVertex collection could be available too early. Only possible if a SmartGraph is created only with this one collection.
* Now the TTL remove operation will properly check preconditions again.
* Second attempt, we only say collection creation was success iff the plan for the collection has not been mdified during create.
* Disabled assertion in favor of tests.
* Removed debug output
When we try dropping a collection `A` for which there are other collections
that have distributeShardsLike set to `A`, mention this in the error message.
* Add drop-check for index creation in cluster.
* Move check from callback to regular read.
* Add changelog entry.
* Incorporate review suggestion
Co-Authored-By: Simon <simon@graetzer.org>
* Convert to VPackArrayIterator.
* Wait for _commTasks in unprepare, that is after Cluster::stop
* Chose better method names
* Revert "Chose better method names"
This reverts commit 91e821348740c655f47207af7e570075f2241895.
* Revert "Wait for _commTasks in unprepare, that is after Cluster::stop"
This reverts commit 6551ae90d74fc046369fdb97cc5872706ce1a184.
* Next try, stop ClusterComm threads earlier
* Bug fix 3.4/collection babies (#9033)
* Prepare API to create multiple collections in a single request to ClusterMethods to improve speedup
* Added counter on how many collections are successfully created
* Allow multi collection creation one level higher
* CollectionMethods now allow batch createion of Collections
* Improved array size assertions
* Now a graph is createad within a single roundtrip in the agency.
* Added new header files
* Insert collections in the AGENCY with TTL and a isBuilding flag, collections with this flag should not be visisible in the coordinator
* Added forgotten C++ file
* Fixed a rare race condition, and the failing IResearch Tests
* readded callback on DONE, otherwise lists are out of sync
* Fixed assertions to let mocked tests pass...
* Fixed community cluster
* Started fixing IResearch analyzer test, catch-tests are failing ;(
* Solved missed merge-conflict
* Added helper functions in AnalyzerFeature-test
* Refactoring AnalyzerTest Section-Auth
* Refactoring AnalyzerTest Section-Emplace-Duplicates
* Refactoring AnalyzerTest Section-Emplace-Error-Cases. Recovery-Test is now red, it seemed to be green because of invalid test case before.
* Refactoring AnalyzerTest, split GET test into multiple parts, still left 'cluster simulation'.
* Attempt to extract Coordinator / DBServer tests a little bit. This commit starts to break all Coordinator tests. However i am convinced that earlier version did NOT test a cluster situation at all, but some hybrid of SingleServer with full local storage that got told to be a Coordinator from now on, but without any Coordinator setup...
* Temporarly disabled some tests in AnalyzerFeature, as discussed with @gnusi.
* Fixed include guard.
* Temporarily deactivated failing tests
* You shall save your files before you commit...
* Fixed test asserting on plan version, which is now higher than before
* Wait for replication before inserting documents
Also, increased some timeouts and fixed a log message
* Fixed some log levels and a log message
* Removed repair-distribute-shards-like-spec from greylisted tests
* do not persist legacy analyzers into _analyzers table
* fix arangosearch upgrade in cluster
* get rid of Vasiliy's shit
* address review comments
* ensure link is synchronized after creation in upgrade
* fix compilation error
* minor cleanup
* fix tests
* distribute '_analyzers' collection as '_graphs'
* comment out Vasiliy's shit part 2
* Coordinators do not unregister at every shutdown.
Instead they create a new short name with every start.
This is needed for the transactions.
* Always new short id for coordinators. Never for DBServers!
* Port agency performance tuning for many shards to devel.
* Add more IDs to LOG_TOPIC calls.
* Even more IDs for LOG_TOPIC.
* Fix a duplicate LOG_TOPIC ID.
* Fix an old merging bug in devel.
* Don't hesitate between phases one and two for small clusters.
* Fixed hidden merge conflict
* Added BlockFetcher, added a minimal test for SingleRowFetcher
* move RegInfo in types.h
* fix getSomeLogic
* Added the AqlItemMatrix implementation. Not yet tested!
* Fixed nr called => Waiting ratio in AllBlocksFetcherMock
* fix compiling
* add RegInfo to produceRow
* BlockFetcherHelper now returns a matrix
* pass RegInfo as requested into AqlItemRow ctor
I would still keep it out as the ItemRow should be a thin view.
* allow to change the AqlItemRows cheaper / remove _sourceRow member
* implement copyRow for AqlItemRow
* organize cleanup for outputblock used in getsome / shrink if necessary
* Added tests for SingleRowFetcher, cleanup in AqlItemRow
* start mocking
* Added test helpers, began work on a more complex test for SingleRowFetcher
* Re-added RegInfo again to AqlItemRow
* helper, added test case for FilterExecutor
* merge fixed compile
* Removed trx name where it is actually not used
* Made some functions TEST_VIRTUAL for mocking.
* implemented Sort executor
* Fixed the BlockFetcherHelper API, to always return a matrix if it is not waiting
* Implemented a SortExecutor test with data
* disable borken test
* Fixed test on SortExecutor. Green now, needs some more testing
* change a bit how the AqlItemRow is used in a test
* Added another test for the SingleRowFetcher
* Added more tests for SingleRowFetcher
* fix getRegisterInfo
* Moved RegInfo into ExecutorInfos. Also now use the FilterExecutor implementation in production code instead of FilterBlock. Starting integration testing.
* add more asserts
* Fixed undefined behaviour in TestCode.
* Do not shrink an empty output block
* switch to block pointers in AqlItemRow
* return blocks in the row fetcher
* Updated grammar.cpp
* Updated (fixed) tests to verify returnBlock
* Improved const-ness
* Changed BlockFetcher constructor in order to make it mockable
* Implemented BlockFetcherMock and rewrote some tests with it
* Updated a comment
* Updated comments
* init commit - EnumerateListExecutor, including EnumerateListExecutorInfos
* add potential fix for ItemMatrix
* Replaced fakeit with BlockFetcherMock in another GIVEN block
* Replaced the last fakeit mocks with BlockFetcherMock and removed fakeit
* Updated function definition
* included missing arary included
* Renamed AqlItemRow to InputAqlItemRow
* Split AqlItemRow into Input~ and Output~ classes
* EnumerateListExecutor + Tests
* Added tests for AqlItemRows
* Added test file for AqlItemRows...
* Made the ostream operator for AqlItemBlocks available to Logger and Catch info
* build error
* Added a second test for AqlItemRows. Need to make input space invalid now, sth. acidential referencing will show up
* Introduce a block ID in the InputAqlItemRow
* Copy output values correctly, avoid InputAqlItemRow pointers
* Added a test for registerClearout
* Fixed tests
* Added a test for adding new values
* Added a test for an incomplete row write to not count as produced.
* Fixed getSome and a test
* Added a test for larger AQL values in AqlItemRows
* Fixed compile error in hidden merge conflict
* Added tests for Filter counter in FilterExecutor
* OutputAqlItemRow now takes responsibility of the block
* Handed responsibility of blocks in ExecutionBlockImpl to OutputAqlItemRow
* EnumerateListExecutor should be close to its finish. Tests need to be fixed, not ready yet.
* better swap
* OutputAqlItemRow now takes ExecutorInfos
- added several assert
- implemented a more strict and safe produced() logic
* enum list test
* Added a more specific error message
* Removed OutputAqlItemRow.changeRow()
* fix invalid block freeing
* changed order of input/output registers
* Fixed a test
* Fixed matrix width in test
* fix failure tests
* finished enumlist tests
* Implemented AllRowsFetcher and tests for it
* Bugfix in skipSome stub
* insert sort and enumerate list executors
into exectuion nodes' create functions
* fixed singlerowfetcherhelper, added tests
* small fixes
* add missing Infos
* restore accidentally deleted scorer
* make it compile
* fix executor info creation / usage
* make use of output var in EnumarateListNode
* Added Executor::Stats and FilterStats
* Extended FilterExecutor tests with stats, added node tracing to getSome
* Fixed Sort-&EnumerateList- Executor to use the new return type with stats
* Fixed compile error in tests
* Changed *ExecutorInfo constructors and classes to contain the necessary register informations
* Made an ExecutorInfo construction more readable
* Updated comments
* Fixed checks in OutputAqlItemRow::setValue()
* Add comparison method to SortRegister. Forbid construction without one.
* Implemented ExecutionBlockImpl::initializeCursor
* more mocking inside ExecutionBlockImplTest
* Minor changes
* Avoid AqlValueGuard destroying the value copied into the output block
* Disabled failure tests that do not apply to the new Sort implementation
* further mocking of test modules
* Removed constexpr for compatibility with outdated gcc versions
* add some failure tests - getsome works differently
therefor we do not test the old behavior
* fix sort node
* clean up alq item matrix
* Removed the transaction methods from read-only access to AqlValues (get and at) and repliced by CollectionNameResolver where necessary. Still left: some calls extract VPackOptions from the Transaction. Compare needs a BuilderLeaser only.
* textexecutionhelper, execimpl test
* Eliminated FilterBlock
* Eliminated the EnumerateListBlock
* first successful running test of executorblockimpl
* Eliminated SortBlock
* fixed testexecutor helper
* Made the ExecutorInfos private to the executors again.
* Implement and use AqlItemBlockShell (#6562)
* Added AqlItemBlockShell
* Minor changes
* Mostly replaced AqlItemBlock with ~Shell.
Current state:
- arangod compiles
- OutputAqlItemRow has yet to be changed
- catch tests have yet to be fixed
* Use AqlItemBlockShell in OutputAqlItemRow
* Added registersToKeep to AqlItemBlockShell
* Removed ExecutorInfos from OutputAqlItemRow
* Split AqlItemBlockShell into Input~ and Output~
* Changed tests so they compile again - they're still not yet working.
* Fixed tests
* fixed building, modified impl test
* Removed now superfluous BlockFetcherMock functions
* more execimpl testing
* Removed block IDs
* more impl testing
* Reduced dependencies of BlockFetcher construction
* Bugfix, cleared documentation
* Removed debug-output
* Adressed minor code review remarks
* Moved method definitions into .cpp files to avoid includes
* Added assertions
* Added comments
* Addressed several more review comments
* Added missing includes
* more testing, not finalized yet
* added missing header file
* added a test for execution block impl
* removed old comment
* Improved lookup algorithm to identify correct block/row combination in AqlItemMatrix
* added test for ExecutionBlockImpl
* move utility to the right position
* Bugfix and a TODO note
* Bugfix: use a uniform ResourceMonitor in tests
* Made OutputAqlItemRow::setValue clone by default and copy on move
* Replaced the getRow lookup with a binary search
* enumerate tests
* Disable emplacing of AqlValues in ItemBlock
* Reenabled std::enable_if will warn until oskar is using c++17 as standard.
* Add helper function to create a shared pointer of an unordered_map<RegisterId>
* CalculationExecutor (#6570)
* add CalculationExecutor skeleton
* first shot of CalculationExecutor
* fix minor bugs
* handle references
* use new shared pointers
* commit to share work
* fix failure test
* reformat with clang-format
* add test for CalculationExecutor
* fix CalcualtionExecutor test
* clean up
* Removes unused code
* clean up includes
* fix/remove comments
* add changes requrested by hacki
* ReturnExecutor (#7932)
* add skeleton to CMakeLists.txt
* build most parts of the ReturnExecutor
* This commit removes ReturnBlock and adds some debug messages
removed inheritRegisters functionality
* finish ReturnExecutor
* add test for return executor
* remove unused code
* add stats and clean up includes
* verify result in ReturnExecutorTest and move *Stats to "Aql/Stats.h"
* Fixed algorithm to find correct row in a MultiRow Input
* fix full count and failure tests (#7969)
* fix full count and failure tests
* fix filter test
* WIP: fixes
* fixed
* NoResultsExecutor (#7953)
* add NoResultsExecutor
* clean up
* some review changes
* fix test
* fix
* fix WAIT -> DONE
* remove unused code (#7995)
* create skeleton for SingletonExecutor (#7957)
* create skeleton for SingletonExecutor
* WIP: continue implementation
* WIP: add fetcher skel
* WIP: add inject function to ConstFetcher
* rename SingletonExecutor to IdExecutor
* WIP: replace singleton node
* WIP: More Debugging on IdExecutor
* WIP: IdExecutor
* WIP: add failure tests
* make iresarch test work but not pass
* WIP: add ConstFetcherHelper
* fix test
* fix tests
* fix iresearch tests
* fix wording
* add review changes
* add review change to SingleRowFetcher as well
* fix test
* fix error when increasing index
* temporarily remove fold-expression
* clean up
* Fix gcc compile error
* Feature/aql limit executor (#7982)
* limit executor
* removed not needed tri assert
* rm _invariable in limitnode
* find out if we are in a subquery
* queryDepth in limit infos
* added missing queryDepth
* finalizing limit executor
* added more tests, fixed a condition
* add assert to test
* added missing fullcount check
* typo
* minor changes, fixed test
* test
* wrong check
* fixed tests
* false merge
* remove basic blocks
* remove basic block includes
* include sort order
* removed not needed basic blocks
* removed not needed basic blocks
* fix test
* Feature/remove input output shells (#8090)
* Added template parameters to allow for block pass-through to be chosen at compile time
* Adapted the tests to match the new template parameters
* Adapted ConstFetcher and IdExecutor to match the new templated fetcher
* Implemented pass-through, fixed SingleRowFetcherTest
* Fixed implicit merge conflicts
* Fix assumptions that are violated by block pass-through
* Added 2 regression tests
* Fixed test expected data
* Fix nullptr dereference
* Fix handling of non-invalidated input variables
* Fix nullptr dereference
* Fix handling of non-invalidated input variables
* Fixed compile error
* Fixed a useless and leaking allocation
* Try a less implicit fix
* Allow IdExecutor and ConstFetcher to be used with pass-through
* Performance patches from @mchacki
* Fixed merge conflicts, and bugs in ConstFetcher
* Fixed atMost pass-through, and blocks that call their parents too often
* Removed InputAqlItemBlockShell (except from tests)
* Removed OutputAqlItemBlockShell (except for tests)
* Moved implementations of OutputAqlItemRow methods in the header
* Moved SingleRowFetcher::fetchRow to the header to allow inlining
* Reenabled returnInheritedResults optimization
* Enable passThrough for ReturnExecutor with inherited results
* Specialized CalculationExecutor to avoid unneccessary conditional jumps
* Made tests compile again (but are currently broken)
* Fixed ReturnExecutor test
* Move created InputRows out of AqlItemMatrix
* Limit- and EnumerateList Executors no longer fetch from upstream after DONE
* Added comments
* Added experimental AqlItemBlock optimizations
* Removed _numEntries, added comments
* Allow executors to pass an "atMost"-limit to the SingleRowFetcher (for LIMIT)
* Let the LimitExecutor pass atMost upstream
* Bugfix for FullCount
* Feature/aql enumeratecollection executor (#8028)
* initial commit
* enum coll executor
* buildable version of enumeratecollectionexecutor
* wrong usage of outVariable
* Added template parameters to allow for block pass-through to be chosen at compile time
* Adapted the tests to match the new template parameters
* Adapted ConstFetcher and IdExecutor to match the new templated fetcher
* more fixes, still some tests failing
* Implemented pass-through, fixed SingleRowFetcherTest
* Fixed implicit merge conflicts
* adding missing set value (remember optimize todo), optimized constructor
* removed old enumerate collection blocks
* Fix assumptions that are violated by block pass-through
* Added 2 regression tests
* Fixed test expected data
* Fix nullptr dereference
* Fix handling of non-invalidated input variables
* Fix nullptr dereference
* Fix handling of non-invalidated input variables
* Fixed compile error
* Fixed a useless and leaking allocation
* added broken uncompilable executor test
* Try a less implicit fix
* fix mocking
* enumerate collection executor test
* remove class, use only static function.
* clean up test after merging with main branch
* Allow IdExecutor and ConstFetcher to be used with pass-through
* Performance patches from @mchacki
* Fixed merge conflicts, and bugs in ConstFetcher
* Fixed atMost pass-through, and blocks that call their parents too often
* Removed InputAqlItemBlockShell (except from tests)
* Removed OutputAqlItemBlockShell (except for tests)
* Moved implementations of OutputAqlItemRow methods in the header
* Moved SingleRowFetcher::fetchRow to the header to allow inlining
* Reenabled returnInheritedResults optimization
* Enable passThrough for ReturnExecutor with inherited results
* Specialized CalculationExecutor to avoid unneccessary conditional jumps
* Made tests compile again (but are currently broken)
* Fixed ReturnExecutor test
* Limit- and EnumerateList Executors no longer fetch from upstream after DONE
* Removed an assertion which seems to be incorrect during bootstrap.
* Inlined AQL ItemMatrix and removed unused elements in other Executors
* Now inline + Move in AqlItemMatrix, seems to be overall best performing
* Bugfix: Do not returnInheritedResults on DBServers
* Fixed LIMIT test, and made it more thorough.
* Fixed createion of NoResultBlock creation in IResearch Nodes. Also relaxed an assertion
* Reactivated failure point, now identical with anotherone in OutputRow, need to unified
* Bug fix: do not mutate the offset in the LimitExecutor (#8109)
* Introduced test
* Fixed LimitExecutor to not mutate its infos, so it works correctly in subqueries
* Fixed crashes in CatchTests
* Fixed non-maintainer build
* try to fix subqueries
* Fix isInSubQuery for non-singleton nodes.
* remove useless while true
* Feature/aql blocks by line dan sort (#8143)
* Add SortNode::SorterType to SortExecutorInfoss.
* prepare imple of sort executor
* WIP: add some code for dan sort
* WIP: working at pushRows
* WIP - try to add Dan's heap-sort
* re add missing test
* 2 fixes
* fix
* Dan's tests are working
* remove unused variable
* remove SortBlock.cpp from CMakeLists.txt
* remove hack and provide an extra method to set the _baseIndex
* Simplified ContrainedSortExecutor.
* fix forgotten variable
* update doc
* Assert that we do not use functions that might return wrong results.
Preconditions or invariants the functions rely on are broken. Therefore
the functions can not be used. This is asserted in maintainer mode.
* add function to restore row invariant
* do not emplace and pop_back if not necessary
* Use clear registers in case we can move the rows.
* WIndows opst zirkus
* Actually destroy AqlItemValue
* Feature/traversal executor by line (#8000)
* Added stubs for TraversalExecutor, no implementation, not compiled in yet
* Included production code of TraversalExecutor and made it compile. Now implement
* Implemented production code for trivial tests, if no row is reaching the traverser.
* Fixed TraversalExecutor code to pull all rows from above and added tests. No traversal yet, this is next
* Intermediate blind commit might not work
* Fixed compile issue in test code
* Created a shared place for Mocks in tests and moved the StorageEngineMock there, also started a shared place for mock servers, most test will need the same server in order to work.
* Fixed travesalExecutor tests. Now able to create tests with actual input.
* Added successful test in TraversalExecutor, that Traverser as started with correct start vertices (by inputRegister)
* Further test cases
* Added stubs for TraversalExecutor, no implementation, not compiled in yet
* Included production code of TraversalExecutor and made it compile. Now implement
* Implemented production code for trivial tests, if no row is reaching the traverser.
* Fixed TraversalExecutor code to pull all rows from above and added tests. No traversal yet, this is next
* Intermediate blind commit might not work
* Fixed compile issue in test code
* Created a shared place for Mocks in tests and moved the StorageEngineMock there, also started a shared place for mock servers, most test will need the same server in order to work.
* Fixed travesalExecutor tests. Now able to create tests with actual input.
* Added successful test in TraversalExecutor, that Traverser as started with correct start vertices (by inputRegister)
* Fixed leftovers from rebase
* Refixed mocks in different folder
* Fixed Mock import
* Fixed Calculators Exector Test to use the unified mocked server.
* Implemented logic for the TraversalExecutor. Also added tests for it. Not fully complete though
* Added validation of result values
* Added usage of constant register in traversal executor
* Included filter variables in traersal executor. Added test for const input. And moved MMDR into base traverser class for simplicity
* Added ostream operators on AQLValue and AqlInputRow. Not 100% done yet but good enough
* Added a shutdownable ExecutionBlock. Some blocks need to implement a specific shutdown still. I added this class to make it easier to eliminate them when the time is due.
* Removed ostream operator for INPUT row again, does for some reason not compile on Linux0o
* Fixed initialization order
* Removed classwrapper for shutdown.
* Applied review changes
* Refixed failing tests, API is not subject to change
* Fixed CatchTest (wrong usage of string literal in test case)
* Feature/shortest path executor (#8042)
* Added stubs for TraversalExecutor, no implementation, not compiled in yet
* Included production code of TraversalExecutor and made it compile. Now implement
* Implemented production code for trivial tests, if no row is reaching the traverser.
* Fixed TraversalExecutor code to pull all rows from above and added tests. No traversal yet, this is next
* Intermediate blind commit might not work
* Fixed compile issue in test code
* Created a shared place for Mocks in tests and moved the StorageEngineMock there, also started a shared place for mock servers, most test will need the same server in order to work.
* Fixed travesalExecutor tests. Now able to create tests with actual input.
* Added successful test in TraversalExecutor, that Traverser as started with correct start vertices (by inputRegister)
* Further test cases
* Added stubs for TraversalExecutor, no implementation, not compiled in yet
* Included production code of TraversalExecutor and made it compile. Now implement
* Implemented production code for trivial tests, if no row is reaching the traverser.
* Fixed TraversalExecutor code to pull all rows from above and added tests. No traversal yet, this is next
* Intermediate blind commit might not work
* Fixed compile issue in test code
* Created a shared place for Mocks in tests and moved the StorageEngineMock there, also started a shared place for mock servers, most test will need the same server in order to work.
* Fixed travesalExecutor tests. Now able to create tests with actual input.
* Added successful test in TraversalExecutor, that Traverser as started with correct start vertices (by inputRegister)
* Fixed leftovers from rebase
* Refixed mocks in different folder
* Fixed Mock import
* Fixed Calculators Exector Test to use the unified mocked server.
* Implemented logic for the TraversalExecutor. Also added tests for it. Not fully complete though
* Added validation of result values
* Added usage of constant register in traversal executor
* Included filter variables in traersal executor. Added test for const input. And moved MMDR into base traverser class for simplicity
* Added ostream operators on AQLValue and AqlInputRow. Not 100% done yet but good enough
* Added a shutdownable ExecutionBlock. Some blocks need to implement a specific shutdown still. I added this class to make it easier to eliminate them when the time is due.
* Removed ostream operator for INPUT row again, does for some reason not compile on Linux0o
* Fixed initialization order
* First draft of shortest path executor
* Fixed logic bugs, Local AQL tests succeed
* Added first version of ShortestPathExecutor tests. Edge output tests are missing yet.
* Added EDGE output tests
* Replaced TraversalStats with NoStats, they have never been tracked...
* Removed obsolete ShortestPathBlock.
* Removed classwrapper for shutdown.
* Applied review changes
* Refixed failing tests, API is not subject to change
* windows macro opst circus
* Clear registers per block, not per row (#8164)
* Fixed compilation under linux again...
* Fixed bug where the Foxxmaster doesn't reset jobs after a crash when it should, or a non-master coordinator removes jobs in progress during startup
* Added a regression test
* Updated CHANGELOG
* Fixed non-maintainer compile
* Decoupled IO handling from Scheduler.
* Fixed SSL start up bug.
* Replaced Scheduler with new worker farm implementation.
* Added minimal statistics and info string for Scheduler.
* Added support for timed submissions.
* Updated delayed submission api. Updated code that used timers.
* Extracted new Scheduler into a virtual parent class. The implementation can now depend on the usecase.
* Signal handler now working.
* Changed threads names, `_stop` is atomic, check for failure during thread start + exception handling like old scheduler did.
* Commented on source code and added TODOs.
* Played around with start-stop-conditions
* Play around with start stop condition.
* start stop cond
* Sart Stop Conditions
* Removed bad cv_status check.
* Bug fix: now compare the actual objects instead of pointer values. Setup t1 and t2 depending on the thread id.
* Moved most of the stuff now unrelated to the Scheduler to GeneralServer. Got rid of JobGuard.
* Instead of waiting for a thread to terminate, put it on a clean up list and check for its termination in each supervisor run.
* Allow detaching long running threads.
* Fixed test mock.
* Updated the WorkHandle logic. Removed post functions.
* Fixed crash when obtaining shared_ptr from this in destructor.
* Added lost mutex.
* Fixed memory leak.
* Fixed merge bug.
* Changed a lot of code to optimize the scheduler.
* Fixed bug of invalidated iterator. Dont remove task on shutdown at different places. Let scheduler threads run until queue is empty.
* Only by value calls to queue.
* Added options again.
* Clean up of code.
* UI Request Lane added.
* Bug fixes in Scheduler.
* Applied reformat.
* Use sigaction.
* Bug fix 3.4/bad leader report current (#7574)
* Initialize theLeader non-empty, thus not assuming leadership.
* Correct ClusterInfo to look into Target/CleanedServers.
* Prevent usage of to be cleaned out servers in new collections.
* After a restart, do not assume to be leader for a shard.
* Do nothing in phaseTwo if leader has not been touched. (#7579)
* Drop follower if it refuses to cooperate.
This is important since a dbserver that is follower for a shard will
after a reboot think that it is a leader, at least for a short amount
of time. If it came back quickly enough, the leader might not have
noticed that it was away.
* Added some DEBUG output for replication rest handler
* Some more debug logging.
* Increased the priority of the ReplicationHandler. This way we will not get stuck with locks that cannot be canceled. Also cancel the lock on the correct database.
* Added extensive log output for replication thins
* Added tombstones to RestReplicationHandler. In a very unlikely case the cancel of a lock can be executed BEFORE the code that actually registers the lock, in this case we will now write a tombstone and do not lock.
* Revert "Added extensive log output for replication thins"
This reverts commit 6d4e37ea1e59e3b3457336019cc7dbc4c979504d.
* Added extensive log output for replication things, now in ERR level instead of MAINTAINER only
* Now actually use hours for synchronization
* React to errors under soft lock if they show up.
* Added a retry loop to increase the read-lock timer.
* Added more timeing output in RocksDB collection internals to figure out why the followers are dropped
* Tweaked RocksDB options
* Revert "Tweaked RocksDB options"
This reverts commit 2bf9c43280beda4792c47d079387fe5154cdd896.
* Removed debug output
* Applied all requested changes by goedderz
* Deleted unused variable
* agents' is obtained from leader's configuration
* corrections in Supervision for advertised endpoints
* change log
* Updated Documentation for cluster/health.
* Unified naming convention.
* Fixed missing update of volatile fields.
* Set version in right order.
* Removed debug output.
* Fixed jslint - missing ;
* Fix index creation in cluster.
Simplify and correct error handling logic in ensureIndexCoordinator.
* After index creation, wait until index appears.
We wait until the Supervision has removed the isBuilding flag and
the coordinator has reloaded the Plan.
* More index handling fixes.
* Directly remove isBuilding in ensureIndexCoordinator (again).
* Fix catch tests by holding mutex shorter.
* Better mutex handling in ClusterInfo.
* merged fixes from 3.4
* odd fix
* Bug fix 3.4/sync repl release thread (#6784)
* First attempt to not block the thread that requires the EXCLUSIVE sync-up lock
* Fixed insertion of query into registry in rest replication handler.
* Removed unnecessary / false asserts as suggested in review. Fixed code comments.
* Replaced auto with a correct type as suggested in review
* Added a helper function to validate if a query is in use in the registry
* Fixed logic bug in usage of query registry
* Fixed compile issue
* Automaticly transfrom int -> bool in initializerlist sucks...
* Inverted boolen logic bug hidden due to int->bool beeing logically inverted.
* Today it seems that bools are too complicated for my brain.
* Removed failure point, didn't write a test for it, and it is hard to write it in the current test environment. Need to find a better solution in future
* Applied chenges required by @goedderz in review
* Bug fix 3.4/shorter foot in door (#7084)
* Implement `syncCollectionCatchup` in DatabaseTailingSyncer.
First stab, might not even compile.
* Fixed a typo.
* Fix a typo and a compilation problem.
* Further compilation fix.
* Implement two stage catchup.
* Two small corrections.
* Unified error messages in Synchronize shard job.
* Improved a code comment.
* Fixed autocasting bool->double and double->bool issue. That is truely one of the best features ever invented... </irony>
* Renamed doHardLock => toSoftLockOnly and inverted default value
* Merged soft/hard foot logic with Transaction splits
* Use scopeguards to cancel readlocks
* Bug fix 3.4/sync replication allow soft and hard lock (#6864)
* First attempt to not block the thread that requires the EXCLUSIVE sync-up lock
* Fixed insertion of query into registry in rest replication handler.
* Removed unnecessary / false asserts as suggested in review. Fixed code comments.
* Replaced auto with a correct type as suggested in review
* Added a helper function to validate if a query is in use in the registry
* Fixed logic bug in usage of query registry
* Fixed compile issue
* Implemented optional 'doHardLock' parameter in the replication acquire read-lock call. A hard-lock guarntees to stop all writes, a soft-lock may not.
* Fixed compile issue
* Automaticly transfrom int -> bool in initializerlist sucks...
* Inverted boolen logic bug hidden due to int->bool beeing logically inverted.
* Today it seems that bools are too complicated for my brain.
* Removed failure point, didn't write a test for it, and it is hard to write it in the current test environment. Need to find a better solution in future
* Applied chenges required by @goedderz in review
* Renamed doHardLock => toSoftLockOnly and inverted default value
* issue 153: ensure views are dropped in Agency when database is dropped in cluster, minor fixes
* backport: add test to ensure views are dropped when database is dropped from plan, fix some issues in ClusterInfo
* optimize primary key lookups in ArangoSearch
* fix test
* Add JS tests
* temporary comment optimizations
* indexes are marked while still missing in Current
* index handling getCollection
* supervision gets indexes from isbuilding, when coordinator is gone before finishing
* seems right now
* fixed broken views
* remove junk comments
* cleanup
* node / supervision adjustements
* supervision fixes
* neunhoef remarks part i
* neunhoef remarks part ii
* neunhoef remarks part ii
* neunhoef remarks part iiI
* collection's current version please
* no need to wait for current once again
* no longer necessary code
* clear comments
* delete left overs
* dead code revived
* Forward-port of bug-fix-3.4/mmfiles-replication-get-followers-under-lock
Fix resign order
Fixed a typo
Get followers later, add TODOs
Added a callback parameter to collection insert methods
Get followers under the lock if necessary
Extracted the replication of inserts into a separate method
Move shortcut into replicate method
Added callbacks for remove, replace and update
Added missing overrides
Extracted replication code from modifyLocal and removeLocal
Update followers under lock also during replace, update, remove
Fix changes from the last commit for update/replace
Update comments, add asserts
Remove changes for document-level locks that will be done in another PR
Unify replication
Adapt log messages to the devel ones
Move common methods from its descendants to TransactionCollection, fix Mock on the way
More IResearch test / mock fixes
Relax asserts for nested transactions
Reformat
Fix non-babies remove and modify replication
* Remove some changes introduced by the merge
* Fixed compile errors introduced by merge
* Fix loophole in error handling.
* Fix inquiry case of id not found: 404.
* Also handle correctly in AgencyComm.
* Fix agency tests.
* Fix error handling in dropCollectionOnCoordinator.
* Start ClusterComm threads in `ClusterFeature::start`. Stop ClusterComm threads in `ClusterFeature::stop`.
* Do not free objects in `Scheduler::shutdown`. Let the `unique_ptr` do their job. Stop ClusterComm threads in `ClusterFeature::stop`, but free instance in `ClusterFeature::unprepare`.
* `io_context` may contains lambdas that hold `shared_ptr`s to `Tasks` the required a functional `VocBase` in their destructor.
* Improve logging on coordinator when doing `arangorestore`.
* Return more error information in `mergeResults`.
* Longer timeout for communication coordinator -> leader for writes.
This is taking into account possible write stops from followers needed
to get in sync.
* Fix compilation.
* Get rid of numbers in exception log messages.
* Fix a typo.
* Fix compilation.
* issue 496.1: switch scope of responsibility between a TRI_vocbase_t and a LogicalView in respect to view creation/deletion
* backport: address test failures
* backport: ensure arangosearch links get exported in the dump
* backport: ensure view is created during restore on the coordinator
* Updates for ArangoSearch DDL tests, IResearchView unregistration and known issues
* Add fix for internal issue 483
* update iresearch to codebase as of 20181011
* backport: address cluster test failures
* backport: address dump test failures
* backport: address discrepency in view creation between single-server and cluster
* backport: address test failure on cluster (revert change)
* backport: address test failures
* backport: address MSVC build issues
* backport: address issue with LogicalDatasource destructing after TRI_vocbase_t
* Revert "backport: address issue with LogicalDatasource destructing after TRI_vocbase_t"
This reverts commit 4f9880bbaa22194dfbb604b5a54658de1d447ac1.
Jan
Tobias Gödderz
Max Neunhöffer
Kaveh Vahedipour
Simon
Michael Hackstein
Lars Maier
Markus Pfeiffer
Wilfried Goesgens
Matthew Von-Maszewski
Dan Larkin-York
Jan Christoph Uhde
Andrey Abramov
Vasiliy
jsteemann
Tobias Gödderz
Luschgy
Manuel Pöter
Frank Celler
Andrey Abramov