////////////////////////////////////////////////////////////////////////////////
/// DISCLAIMER
///
/// Copyright 2018 ArangoDB GmbH, Cologne, Germany
///
/// Licensed under the Apache License, Version 2.0 (the "License");
/// you may not use this file except in compliance with the License.
/// You may obtain a copy of the License at
///
///     http://www.apache.org/licenses/LICENSE-2.0
///
/// Unless required by applicable law or agreed to in writing, software
/// distributed under the License is distributed on an "AS IS" BASIS,
/// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
/// See the License for the specific language governing permissions and
/// limitations under the License.
///
/// Copyright holder is ArangoDB GmbH, Cologne, Germany
///
/// @author Andrey Abramov
/// @author Vasiliy Nabatchikov
////////////////////////////////////////////////////////////////////////////////

#include "gtest/gtest.h"

#include "../IResearch/RestHandlerMock.h"
#include "../Mocks/StorageEngineMock.h"
#include "Aql/QueryRegistry.h"
#if USE_ENTERPRISE
#include "Enterprise/Ldap/LdapFeature.h"
#endif
#include "GeneralServer/AuthenticationFeature.h"
#include "RestHandler/RestViewHandler.h"
#include "RestServer/DatabaseFeature.h"
#include "RestServer/QueryRegistryFeature.h"
#include "RestServer/ViewTypesFeature.h"
#include "StorageEngine/EngineSelectorFeature.h"
#include "velocypack/Builder.h"
#include "velocypack/Parser.h"

namespace {

struct TestView : public arangodb::LogicalView {
  arangodb::Result _appendVelocyPackResult;
  arangodb::velocypack::Builder _properties;

  TestView(TRI_vocbase_t& vocbase, arangodb::velocypack::Slice const& definition, uint64_t planVersion)
      : arangodb::LogicalView(vocbase, definition, planVersion) {}
  virtual arangodb::Result appendVelocyPackImpl(
      arangodb::velocypack::Builder& builder,
      Serialization) const override {
    builder.add("properties", _properties.slice());
    return _appendVelocyPackResult;
  }
  virtual arangodb::Result dropImpl() override {
    return arangodb::LogicalViewHelperStorageEngine::drop(*this);
  }
  virtual void open() override {}
  virtual arangodb::Result renameImpl(std::string const& oldName) override {
    return arangodb::LogicalViewHelperStorageEngine::rename(*this, oldName);
  }
  virtual arangodb::Result properties(arangodb::velocypack::Slice const& properties,
                                      bool partialUpdate) override {
    _properties = arangodb::velocypack::Builder(properties);
    return arangodb::Result();
  }
  virtual bool visitCollections(CollectionVisitor const& visitor) const override {
    return true;
  }
};

struct ViewFactory : public arangodb::ViewFactory {
  virtual arangodb::Result create(arangodb::LogicalView::ptr& view, TRI_vocbase_t& vocbase,
                                  arangodb::velocypack::Slice const& definition) const override {
    view = vocbase.createView(definition);

    return arangodb::Result();
  }

  virtual arangodb::Result instantiate(arangodb::LogicalView::ptr& view,
                                       TRI_vocbase_t& vocbase,
                                       arangodb::velocypack::Slice const& definition,
                                       uint64_t planVersion) const override {
    view = std::make_shared<TestView>(vocbase, definition, planVersion);

    return arangodb::Result();
  }
};

}  // namespace

// -----------------------------------------------------------------------------
// --SECTION--                                                 setup / tear-down
// -----------------------------------------------------------------------------

class RestViewHandlerTest : public ::testing::Test {
 protected:
  StorageEngineMock engine;
  arangodb::application_features::ApplicationServer server;
  std::vector<std::pair<arangodb::application_features::ApplicationFeature*, bool>> features;
  ViewFactory viewFactory;

  RestViewHandlerTest() : engine(server), server(nullptr, nullptr) {
    arangodb::EngineSelectorFeature::ENGINE = &engine;

    // suppress INFO {authentication} Authentication is turned on (system only), authentication for unix sockets is turned on
    // suppress WARNING {authentication} --server.jwt-secret is insecure. Use --server.jwt-secret-keyfile instead
    arangodb::LogTopic::setLogLevel(arangodb::Logger::AUTHENTICATION.name(),
                                    arangodb::LogLevel::ERR);

    // setup required application features
    features.emplace_back(new arangodb::AuthenticationFeature(server), false);  // required for VocbaseContext
    features.emplace_back(new arangodb::DatabaseFeature(server),
                          false);  // required for TRI_vocbase_t::renameView(...)
    features.emplace_back(new arangodb::QueryRegistryFeature(server), false);  // required for TRI_vocbase_t
    features.emplace_back(new arangodb::ViewTypesFeature(server),
                          false);  // required for LogicalView::create(...)

#if USE_ENTERPRISE
    features.emplace_back(new arangodb::LdapFeature(server),
                          false);  // required for AuthenticationFeature with USE_ENTERPRISE
#endif

    for (auto& f : features) {
      arangodb::application_features::ApplicationServer::server->addFeature(f.first);
    }

    for (auto& f : features) {
      f.first->prepare();
    }

    for (auto& f : features) {
      if (f.second) {
        f.first->start();
      }
    }

    auto* viewTypesFeature =
        arangodb::application_features::ApplicationServer::lookupFeature<arangodb::ViewTypesFeature>();

    viewTypesFeature->emplace(arangodb::LogicalDataSource::Type::emplace(arangodb::velocypack::StringRef(
                                  "testViewType")),
                              viewFactory);
  }

  ~RestViewHandlerTest() {
    arangodb::application_features::ApplicationServer::server = nullptr;
    arangodb::EngineSelectorFeature::ENGINE = nullptr;

    // destroy application features
    for (auto& f : features) {
      if (f.second) {
        f.first->stop();
      }
    }

    for (auto& f : features) {
      f.first->unprepare();
    }

    arangodb::LogTopic::setLogLevel(arangodb::Logger::AUTHENTICATION.name(),
                                    arangodb::LogLevel::DEFAULT);
  }
};

// -----------------------------------------------------------------------------
// --SECTION--                                                        test suite
// -----------------------------------------------------------------------------

TEST_F(RestViewHandlerTest, test_auth) {
  // test create
  {
    TRI_vocbase_t vocbase(TRI_vocbase_type_e::TRI_VOCBASE_TYPE_NORMAL, 1,
                          "testVocbase");
    auto requestPtr = std::make_unique<GeneralRequestMock>(vocbase);
    auto& request = *requestPtr;
    auto responcePtr = std::make_unique<GeneralResponseMock>();
    auto& responce = *responcePtr;
    arangodb::RestViewHandler handler(requestPtr.release(), responcePtr.release());

    request.setRequestType(arangodb::rest::RequestType::POST);
    request._payload.openObject();
    request._payload.add(arangodb::StaticStrings::DataSourceName,
                         arangodb::velocypack::Value("testView"));
    request._payload.add(arangodb::StaticStrings::DataSourceType,
                         arangodb::velocypack::Value("testViewType"));
    request._payload.close();

    EXPECT_TRUE((vocbase.views().empty()));

    struct ExecContext : public arangodb::ExecContext {
      ExecContext()
          : arangodb::ExecContext(arangodb::ExecContext::Type::Default, "", "",
                                  arangodb::auth::Level::NONE,
                                  arangodb::auth::Level::NONE) {}
    } execContext;
    arangodb::ExecContextScope execContextScope(&execContext);
    auto* authFeature = arangodb::AuthenticationFeature::instance();
    auto* userManager = authFeature->userManager();
    arangodb::aql::QueryRegistry queryRegistry(0);  // required for UserManager::loadFromDB()
    userManager->setQueryRegistry(&queryRegistry);
    auto resetUserManager = std::shared_ptr<arangodb::auth::UserManager>(
        userManager,
        [](arangodb::auth::UserManager* ptr) -> void { ptr->removeAllUsers(); });

    // not authorized (missing user)
    {
      arangodb::auth::UserMap userMap;  // empty map, no user -> no permissions
      userManager->setAuthInfo(userMap);  // set user map to avoid loading configuration from system database

      auto status = handler.execute();
      EXPECT_TRUE((arangodb::RestStatus::DONE == status));
      EXPECT_TRUE((arangodb::rest::ResponseCode::FORBIDDEN == responce.responseCode()));
      auto slice = responce._payload.slice();
      EXPECT_TRUE((slice.isObject()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Code) &&
                   slice.get(arangodb::StaticStrings::Code).isNumber<size_t>() &&
                   size_t(arangodb::rest::ResponseCode::FORBIDDEN) ==
                       slice.get(arangodb::StaticStrings::Code).getNumber<size_t>()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Error) &&
                   slice.get(arangodb::StaticStrings::Error).isBoolean() &&
                   true == slice.get(arangodb::StaticStrings::Error).getBoolean()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::ErrorNum) &&
                   slice.get(arangodb::StaticStrings::ErrorNum).isNumber<int>() &&
                   TRI_ERROR_FORBIDDEN ==
                       slice.get(arangodb::StaticStrings::ErrorNum).getNumber<int>()));
      EXPECT_TRUE((vocbase.views().empty()));
    }

    // not authorized (RO user)
    {
      arangodb::auth::UserMap userMap;
      auto& user =
          userMap
              .emplace("", arangodb::auth::User::newUser("", "", arangodb::auth::Source::LDAP))
              .first->second;
      user.grantDatabase(vocbase.name(), arangodb::auth::Level::RO);
      userManager->setAuthInfo(userMap);  // set user map to avoid loading configuration from system database

      auto status = handler.execute();
      EXPECT_TRUE((arangodb::RestStatus::DONE == status));
      EXPECT_TRUE((arangodb::rest::ResponseCode::FORBIDDEN == responce.responseCode()));
      auto slice = responce._payload.slice();
      EXPECT_TRUE((slice.isObject()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Code) &&
                   slice.get(arangodb::StaticStrings::Code).isNumber<size_t>() &&
                   size_t(arangodb::rest::ResponseCode::FORBIDDEN) ==
                       slice.get(arangodb::StaticStrings::Code).getNumber<size_t>()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Error) &&
                   slice.get(arangodb::StaticStrings::Error).isBoolean() &&
                   true == slice.get(arangodb::StaticStrings::Error).getBoolean()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::ErrorNum) &&
                   slice.get(arangodb::StaticStrings::ErrorNum).isNumber<int>() &&
                   TRI_ERROR_FORBIDDEN ==
                       slice.get(arangodb::StaticStrings::ErrorNum).getNumber<int>()));
      EXPECT_TRUE((vocbase.views().empty()));
    }

    // authorzed (RW user)
    {
      arangodb::auth::UserMap userMap;
      auto& user =
          userMap
              .emplace("", arangodb::auth::User::newUser("", "", arangodb::auth::Source::LDAP))
              .first->second;
      user.grantDatabase(vocbase.name(), arangodb::auth::Level::RW);
      userManager->setAuthInfo(userMap);  // set user map to avoid loading configuration from system database

      auto status = handler.execute();
      EXPECT_TRUE((arangodb::RestStatus::DONE == status));
      EXPECT_TRUE((arangodb::rest::ResponseCode::CREATED == responce.responseCode()));
      auto slice = responce._payload.slice();
      EXPECT_TRUE((slice.isObject()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::DataSourceName) &&
                   slice.get(arangodb::StaticStrings::DataSourceName).isString() &&
                   std::string("testView") ==
                       slice.get(arangodb::StaticStrings::DataSourceName).copyString()));
      auto view = vocbase.lookupView("testView");
      EXPECT_TRUE((false == !view));
    }
  }

  // test drop
  {
    auto createViewJson = arangodb::velocypack::Parser::fromJson(
        "{ \"name\": \"testView\", \"type\": \"testViewType\" }");
    TRI_vocbase_t vocbase(TRI_vocbase_type_e::TRI_VOCBASE_TYPE_NORMAL, 1,
                          "testVocbase");
    auto logicalView = vocbase.createView(createViewJson->slice());
    ASSERT_TRUE((false == !logicalView));
    auto requestPtr = std::make_unique<GeneralRequestMock>(vocbase);
    auto& request = *requestPtr;
    auto responcePtr = std::make_unique<GeneralResponseMock>();
    auto& responce = *responcePtr;
    arangodb::RestViewHandler handler(requestPtr.release(), responcePtr.release());

    request.addSuffix("testView");
    request.setRequestType(arangodb::rest::RequestType::DELETE_REQ);

    struct ExecContext : public arangodb::ExecContext {
      ExecContext()
          : arangodb::ExecContext(arangodb::ExecContext::Type::Default, "", "",
                                  arangodb::auth::Level::NONE,
                                  arangodb::auth::Level::NONE) {}
    } execContext;
    arangodb::ExecContextScope execContextScope(&execContext);
    auto* authFeature = arangodb::AuthenticationFeature::instance();
    auto* userManager = authFeature->userManager();
    arangodb::aql::QueryRegistry queryRegistry(0);  // required for UserManager::loadFromDB()
    userManager->setQueryRegistry(&queryRegistry);
    auto resetUserManager = std::shared_ptr<arangodb::auth::UserManager>(
        userManager,
        [](arangodb::auth::UserManager* ptr) -> void { ptr->removeAllUsers(); });

    // not authorized (missing user)
    {
      arangodb::auth::UserMap userMap;  // empty map, no user -> no permissions
      userManager->setAuthInfo(userMap);  // set user map to avoid loading configuration from system database

      auto status = handler.execute();
      EXPECT_TRUE((arangodb::RestStatus::DONE == status));
      EXPECT_TRUE((arangodb::rest::ResponseCode::FORBIDDEN == responce.responseCode()));
      auto slice = responce._payload.slice();
      EXPECT_TRUE((slice.isObject()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Code) &&
                   slice.get(arangodb::StaticStrings::Code).isNumber<size_t>() &&
                   size_t(arangodb::rest::ResponseCode::FORBIDDEN) ==
                       slice.get(arangodb::StaticStrings::Code).getNumber<size_t>()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Error) &&
                   slice.get(arangodb::StaticStrings::Error).isBoolean() &&
                   true == slice.get(arangodb::StaticStrings::Error).getBoolean()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::ErrorNum) &&
                   slice.get(arangodb::StaticStrings::ErrorNum).isNumber<int>() &&
                   TRI_ERROR_FORBIDDEN ==
                       slice.get(arangodb::StaticStrings::ErrorNum).getNumber<int>()));
      auto view = vocbase.lookupView("testView");
      EXPECT_TRUE((false == !view));
    }

    // not authorized (RO user database)
    {
      arangodb::auth::UserMap userMap;
      auto& user =
          userMap
              .emplace("", arangodb::auth::User::newUser("", "", arangodb::auth::Source::LDAP))
              .first->second;
      user.grantDatabase(vocbase.name(), arangodb::auth::Level::RO);
      userManager->setAuthInfo(userMap);  // set user map to avoid loading configuration from system database

      auto status = handler.execute();
      EXPECT_TRUE((arangodb::RestStatus::DONE == status));
      EXPECT_TRUE((arangodb::rest::ResponseCode::FORBIDDEN == responce.responseCode()));
      auto slice = responce._payload.slice();
      EXPECT_TRUE((slice.isObject()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Code) &&
                   slice.get(arangodb::StaticStrings::Code).isNumber<size_t>() &&
                   size_t(arangodb::rest::ResponseCode::FORBIDDEN) ==
                       slice.get(arangodb::StaticStrings::Code).getNumber<size_t>()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Error) &&
                   slice.get(arangodb::StaticStrings::Error).isBoolean() &&
                   true == slice.get(arangodb::StaticStrings::Error).getBoolean()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::ErrorNum) &&
                   slice.get(arangodb::StaticStrings::ErrorNum).isNumber<int>() &&
                   TRI_ERROR_FORBIDDEN ==
                       slice.get(arangodb::StaticStrings::ErrorNum).getNumber<int>()));
      auto view = vocbase.lookupView("testView");
      EXPECT_TRUE((false == !view));
    }

    // authorized (NONE user view) as per https://github.com/arangodb/backlog/issues/459
    {
      arangodb::auth::UserMap userMap;
      auto& user =
          userMap
              .emplace("", arangodb::auth::User::newUser("", "", arangodb::auth::Source::LDAP))
              .first->second;
      user.grantDatabase(vocbase.name(), arangodb::auth::Level::RW);
      user.grantCollection(vocbase.name(), "testView", arangodb::auth::Level::NONE);
      userManager->setAuthInfo(userMap);  // set user map to avoid loading configuration from system database

      auto status = handler.execute();
      EXPECT_TRUE((arangodb::RestStatus::DONE == status));
      EXPECT_TRUE((arangodb::rest::ResponseCode::OK == responce.responseCode()));
      auto slice = responce._payload.slice();
      EXPECT_TRUE((slice.isObject()));
      EXPECT_TRUE((slice.hasKey("result") && slice.get("result").isBoolean() &&
                   true == slice.get("result").getBoolean()));
      EXPECT_TRUE((vocbase.views().empty()));
    }
  }

  // test rename
  {
    auto createViewJson = arangodb::velocypack::Parser::fromJson(
        "{ \"name\": \"testView\", \"type\": \"testViewType\" }");
    TRI_vocbase_t vocbase(TRI_vocbase_type_e::TRI_VOCBASE_TYPE_NORMAL, 1,
                          "testVocbase");
    auto logicalView = vocbase.createView(createViewJson->slice());
    ASSERT_TRUE((false == !logicalView));
    auto requestPtr = std::make_unique<GeneralRequestMock>(vocbase);
    auto& request = *requestPtr;
    auto responcePtr = std::make_unique<GeneralResponseMock>();
    auto& responce = *responcePtr;
    arangodb::RestViewHandler handler(requestPtr.release(), responcePtr.release());

    request.addSuffix("testView");
    request.addSuffix("rename");
    request.setRequestType(arangodb::rest::RequestType::PUT);
    request._payload.openObject();
    request._payload.add("name", arangodb::velocypack::Value("testView1"));
    request._payload.close();

    struct ExecContext : public arangodb::ExecContext {
      ExecContext()
          : arangodb::ExecContext(arangodb::ExecContext::Type::Default, "", "",
                                  arangodb::auth::Level::NONE,
                                  arangodb::auth::Level::NONE) {}
    } execContext;
    arangodb::ExecContextScope execContextScope(&execContext);
    auto* authFeature = arangodb::AuthenticationFeature::instance();
    auto* userManager = authFeature->userManager();
    arangodb::aql::QueryRegistry queryRegistry(0);  // required for UserManager::loadFromDB()
    userManager->setQueryRegistry(&queryRegistry);
    auto resetUserManager = std::shared_ptr<arangodb::auth::UserManager>(
        userManager,
        [](arangodb::auth::UserManager* ptr) -> void { ptr->removeAllUsers(); });

    // not authorized (missing user)
    {
      arangodb::auth::UserMap userMap;  // empty map, no user -> no permissions
      userManager->setAuthInfo(userMap);  // set user map to avoid loading configuration from system database

      auto status = handler.execute();
      EXPECT_TRUE((arangodb::RestStatus::DONE == status));
      EXPECT_TRUE((arangodb::rest::ResponseCode::FORBIDDEN == responce.responseCode()));
      auto slice = responce._payload.slice();
      EXPECT_TRUE((slice.isObject()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Code) &&
                   slice.get(arangodb::StaticStrings::Code).isNumber<size_t>() &&
                   size_t(arangodb::rest::ResponseCode::FORBIDDEN) ==
                       slice.get(arangodb::StaticStrings::Code).getNumber<size_t>()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Error) &&
                   slice.get(arangodb::StaticStrings::Error).isBoolean() &&
                   true == slice.get(arangodb::StaticStrings::Error).getBoolean()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::ErrorNum) &&
                   slice.get(arangodb::StaticStrings::ErrorNum).isNumber<int>() &&
                   TRI_ERROR_FORBIDDEN ==
                       slice.get(arangodb::StaticStrings::ErrorNum).getNumber<int>()));
      auto view = vocbase.lookupView("testView");
      EXPECT_TRUE((false == !view));
      auto view1 = vocbase.lookupView("testView1");
      EXPECT_TRUE((true == !view1));
    }

    // not authorized (RO user database)
    {
      arangodb::auth::UserMap userMap;
      auto& user =
          userMap
              .emplace("", arangodb::auth::User::newUser("", "", arangodb::auth::Source::LDAP))
              .first->second;
      user.grantDatabase(vocbase.name(), arangodb::auth::Level::RO);
      userManager->setAuthInfo(userMap);  // set user map to avoid loading configuration from system database

      auto status = handler.execute();
      EXPECT_TRUE((arangodb::RestStatus::DONE == status));
      EXPECT_TRUE((arangodb::rest::ResponseCode::FORBIDDEN == responce.responseCode()));
      auto slice = responce._payload.slice();
      EXPECT_TRUE((slice.isObject()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Code) &&
                   slice.get(arangodb::StaticStrings::Code).isNumber<size_t>() &&
                   size_t(arangodb::rest::ResponseCode::FORBIDDEN) ==
                       slice.get(arangodb::StaticStrings::Code).getNumber<size_t>()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Error) &&
                   slice.get(arangodb::StaticStrings::Error).isBoolean() &&
                   true == slice.get(arangodb::StaticStrings::Error).getBoolean()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::ErrorNum) &&
                   slice.get(arangodb::StaticStrings::ErrorNum).isNumber<int>() &&
                   TRI_ERROR_FORBIDDEN ==
                       slice.get(arangodb::StaticStrings::ErrorNum).getNumber<int>()));
      auto view = vocbase.lookupView("testView");
      EXPECT_TRUE((false == !view));
      auto view1 = vocbase.lookupView("testView1");
      EXPECT_TRUE((true == !view1));
    }

    // not authorized (NONE user view with failing toVelocyPack()) as per https://github.com/arangodb/backlog/issues/459
    {
      arangodb::auth::UserMap userMap;
      auto& user =
          userMap
              .emplace("", arangodb::auth::User::newUser("", "", arangodb::auth::Source::LDAP))
              .first->second;
      user.grantDatabase(vocbase.name(), arangodb::auth::Level::RW);
      user.grantCollection(vocbase.name(), "testView", arangodb::auth::Level::NONE);
      userManager->setAuthInfo(userMap);  // set user map to avoid loading configuration from system database
      auto* testView = arangodb::LogicalView::cast<TestView>(logicalView.get());
      testView->_appendVelocyPackResult = arangodb::Result(TRI_ERROR_FORBIDDEN);
      auto resetAppendVelocyPackResult =
          std::shared_ptr<TestView>(testView, [](TestView* p) -> void {
            p->_appendVelocyPackResult = arangodb::Result();
          });

      auto status = handler.execute();
      EXPECT_TRUE((arangodb::RestStatus::DONE == status));
      EXPECT_TRUE((arangodb::rest::ResponseCode::FORBIDDEN == responce.responseCode()));
      auto slice = responce._payload.slice();
      EXPECT_TRUE((slice.isObject()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Code) &&
                   slice.get(arangodb::StaticStrings::Code).isNumber<size_t>() &&
                   size_t(arangodb::rest::ResponseCode::FORBIDDEN) ==
                       slice.get(arangodb::StaticStrings::Code).getNumber<size_t>()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Error) &&
                   slice.get(arangodb::StaticStrings::Error).isBoolean() &&
                   true == slice.get(arangodb::StaticStrings::Error).getBoolean()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::ErrorNum) &&
                   slice.get(arangodb::StaticStrings::ErrorNum).isNumber<int>() &&
                   TRI_ERROR_FORBIDDEN ==
                       slice.get(arangodb::StaticStrings::ErrorNum).getNumber<int>()));
      auto view = vocbase.lookupView("testView");
      EXPECT_TRUE((false == !view));
      auto view1 = vocbase.lookupView("testView1");
      EXPECT_TRUE((true == !view1));
    }

    // authorized (NONE user view) as per https://github.com/arangodb/backlog/issues/459
    {
      arangodb::auth::UserMap userMap;
      auto& user =
          userMap
              .emplace("", arangodb::auth::User::newUser("", "", arangodb::auth::Source::LDAP))
              .first->second;
      user.grantDatabase(vocbase.name(), arangodb::auth::Level::RW);
      user.grantCollection(vocbase.name(), "testView", arangodb::auth::Level::NONE);
      userManager->setAuthInfo(userMap);  // set user map to avoid loading configuration from system database

      auto status = handler.execute();
      EXPECT_TRUE((arangodb::RestStatus::DONE == status));
      EXPECT_TRUE((arangodb::rest::ResponseCode::OK == responce.responseCode()));
      auto slice = responce._payload.slice();
      EXPECT_TRUE((slice.isObject()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::DataSourceName) &&
                   slice.get(arangodb::StaticStrings::DataSourceName).isString() &&
                   std::string("testView1") ==
                       slice.get(arangodb::StaticStrings::DataSourceName).copyString()));
      auto view = vocbase.lookupView("testView");
      EXPECT_TRUE((true == !view));
      auto view1 = vocbase.lookupView("testView1");
      EXPECT_TRUE((false == !view1));
    }
  }

  // test modify
  {
    auto createViewJson = arangodb::velocypack::Parser::fromJson(
        "{ \"name\": \"testView\", \"type\": \"testViewType\" }");
    TRI_vocbase_t vocbase(TRI_vocbase_type_e::TRI_VOCBASE_TYPE_NORMAL, 1,
                          "testVocbase");
    auto logicalView = vocbase.createView(createViewJson->slice());
    ASSERT_TRUE((false == !logicalView));
    auto requestPtr = std::make_unique<GeneralRequestMock>(vocbase);
    auto& request = *requestPtr;
    auto responcePtr = std::make_unique<GeneralResponseMock>();
    auto& responce = *responcePtr;
    arangodb::RestViewHandler handler(requestPtr.release(), responcePtr.release());

    request.addSuffix("testView");
    request.addSuffix("properties");
    request.setRequestType(arangodb::rest::RequestType::PUT);
    request._payload.openObject();
    request._payload.add("key", arangodb::velocypack::Value("value"));
    request._payload.close();

    struct ExecContext : public arangodb::ExecContext {
      ExecContext()
          : arangodb::ExecContext(arangodb::ExecContext::Type::Default, "", "",
                                  arangodb::auth::Level::NONE,
                                  arangodb::auth::Level::NONE) {}
    } execContext;
    arangodb::ExecContextScope execContextScope(&execContext);
    auto* authFeature = arangodb::AuthenticationFeature::instance();
    auto* userManager = authFeature->userManager();
    arangodb::aql::QueryRegistry queryRegistry(0);  // required for UserManager::loadFromDB()
    userManager->setQueryRegistry(&queryRegistry);
    auto resetUserManager = std::shared_ptr<arangodb::auth::UserManager>(
        userManager,
        [](arangodb::auth::UserManager* ptr) -> void { ptr->removeAllUsers(); });

    // not authorized (missing user)
    {
      arangodb::auth::UserMap userMap;  // empty map, no user -> no permissions
      userManager->setAuthInfo(userMap);  // set user map to avoid loading configuration from system database

      auto status = handler.execute();
      EXPECT_TRUE((arangodb::RestStatus::DONE == status));
      EXPECT_TRUE((arangodb::rest::ResponseCode::FORBIDDEN == responce.responseCode()));
      auto slice = responce._payload.slice();
      EXPECT_TRUE((slice.isObject()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Code) &&
                   slice.get(arangodb::StaticStrings::Code).isNumber<size_t>() &&
                   size_t(arangodb::rest::ResponseCode::FORBIDDEN) ==
                       slice.get(arangodb::StaticStrings::Code).getNumber<size_t>()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Error) &&
                   slice.get(arangodb::StaticStrings::Error).isBoolean() &&
                   true == slice.get(arangodb::StaticStrings::Error).getBoolean()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::ErrorNum) &&
                   slice.get(arangodb::StaticStrings::ErrorNum).isNumber<int>() &&
                   TRI_ERROR_FORBIDDEN ==
                       slice.get(arangodb::StaticStrings::ErrorNum).getNumber<int>()));
      auto view = vocbase.lookupView("testView");
      EXPECT_TRUE((false == !view));
    }

    // not authorized (RO user database)
    {
      arangodb::auth::UserMap userMap;
      auto& user =
          userMap
              .emplace("", arangodb::auth::User::newUser("", "", arangodb::auth::Source::LDAP))
              .first->second;
      user.grantDatabase(vocbase.name(), arangodb::auth::Level::RO);
      userManager->setAuthInfo(userMap);  // set user map to avoid loading configuration from system database

      auto status = handler.execute();
      EXPECT_TRUE((arangodb::RestStatus::DONE == status));
      EXPECT_TRUE((arangodb::rest::ResponseCode::FORBIDDEN == responce.responseCode()));
      auto slice = responce._payload.slice();
      EXPECT_TRUE((slice.isObject()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Code) &&
                   slice.get(arangodb::StaticStrings::Code).isNumber<size_t>() &&
                   size_t(arangodb::rest::ResponseCode::FORBIDDEN) ==
                       slice.get(arangodb::StaticStrings::Code).getNumber<size_t>()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Error) &&
                   slice.get(arangodb::StaticStrings::Error).isBoolean() &&
                   true == slice.get(arangodb::StaticStrings::Error).getBoolean()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::ErrorNum) &&
                   slice.get(arangodb::StaticStrings::ErrorNum).isNumber<int>() &&
                   TRI_ERROR_FORBIDDEN ==
                       slice.get(arangodb::StaticStrings::ErrorNum).getNumber<int>()));
      auto view = vocbase.lookupView("testView");
      EXPECT_TRUE((false == !view));
    }

    // not authorized (NONE user view with failing toVelocyPack()) as per https://github.com/arangodb/backlog/issues/459
    {
      arangodb::auth::UserMap userMap;
      auto& user =
          userMap
              .emplace("", arangodb::auth::User::newUser("", "", arangodb::auth::Source::LDAP))
              .first->second;
      user.grantDatabase(vocbase.name(), arangodb::auth::Level::RW);
      user.grantCollection(vocbase.name(), "testView", arangodb::auth::Level::NONE);
      userManager->setAuthInfo(userMap);  // set user map to avoid loading configuration from system database
      auto* testView = arangodb::LogicalView::cast<TestView>(logicalView.get());
      testView->_appendVelocyPackResult = arangodb::Result(TRI_ERROR_INTERNAL);
      auto resetAppendVelocyPackResult =
          std::shared_ptr<TestView>(testView, [](TestView* p) -> void {
            p->_appendVelocyPackResult = arangodb::Result();
          });

      auto status = handler.execute();
      EXPECT_TRUE((arangodb::RestStatus::DONE == status));
      EXPECT_TRUE((arangodb::rest::ResponseCode::SERVER_ERROR == responce.responseCode()));
      auto slice = responce._payload.slice();
      EXPECT_TRUE((slice.isObject()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Code) &&
                   slice.get(arangodb::StaticStrings::Code).isNumber<size_t>() &&
                   size_t(arangodb::rest::ResponseCode::SERVER_ERROR) ==
                       slice.get(arangodb::StaticStrings::Code).getNumber<size_t>()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Error) &&
                   slice.get(arangodb::StaticStrings::Error).isBoolean() &&
                   true == slice.get(arangodb::StaticStrings::Error).getBoolean()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::ErrorNum) &&
                   slice.get(arangodb::StaticStrings::ErrorNum).isNumber<int>() &&
                   TRI_ERROR_INTERNAL ==
                       slice.get(arangodb::StaticStrings::ErrorNum).getNumber<int>()));
      auto view = vocbase.lookupView("testView");
      EXPECT_TRUE((false == !view));
      slice = arangodb::LogicalView::cast<TestView>(*view)._properties.slice();
      EXPECT_TRUE((!slice.isObject()));
    }

    // authorized (NONE user view) as per https://github.com/arangodb/backlog/issues/459
    {
      arangodb::auth::UserMap userMap;
      auto& user =
          userMap
              .emplace("", arangodb::auth::User::newUser("", "", arangodb::auth::Source::LDAP))
              .first->second;
      user.grantDatabase(vocbase.name(), arangodb::auth::Level::RW);
      user.grantCollection(vocbase.name(), "testView", arangodb::auth::Level::NONE);
      userManager->setAuthInfo(userMap);  // set user map to avoid loading configuration from system database

      auto status = handler.execute();
      EXPECT_TRUE((arangodb::RestStatus::DONE == status));
      EXPECT_TRUE((arangodb::rest::ResponseCode::OK == responce.responseCode()));
      auto slice = responce._payload.slice();
      EXPECT_TRUE((slice.isObject()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::DataSourceName) &&
                   slice.get(arangodb::StaticStrings::DataSourceName).isString() &&
                   std::string("testView") ==
                       slice.get(arangodb::StaticStrings::DataSourceName).copyString()));
      EXPECT_TRUE((slice.hasKey("properties") && slice.get("properties").isObject() &&
                   slice.get("properties").hasKey("key") &&
                   slice.get("properties").get("key").isString() &&
                   std::string("value") == slice.get("properties").get("key").copyString()));
      auto view = vocbase.lookupView("testView");
      EXPECT_TRUE((false == !view));
      slice = arangodb::LogicalView::cast<TestView>(*view)._properties.slice();
      EXPECT_TRUE((slice.isObject()));
      EXPECT_TRUE((slice.hasKey("key") && slice.get("key").isString() &&
                   std::string("value") == slice.get("key").copyString()));
    }
    /* redundant because of above
        // not authorized (RO user view)
        {
          arangodb::auth::UserMap userMap;
          auto& user = userMap.emplace("", arangodb::auth::User::newUser("", "", arangodb::auth::Source::LDAP)).first->second;
          user.grantDatabase(vocbase.name(), arangodb::auth::Level::RW);
          user.grantCollection(vocbase.name(), "testView", arangodb::auth::Level::RO);
          userManager->setAuthInfo(userMap); // set user map to avoid loading configuration from system database

          auto status = handler.execute();
          EXPECT_TRUE((arangodb::RestStatus::DONE == status));
          EXPECT_TRUE((arangodb::rest::ResponseCode::FORBIDDEN == responce.responseCode()));
          auto slice = responce._payload.slice();
          EXPECT_TRUE((slice.isObject()));
          EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Code) && slice.get(arangodb::StaticStrings::Code).isNumber<size_t>() && size_t(arangodb::rest::ResponseCode::FORBIDDEN) == slice.get(arangodb::StaticStrings::Code).getNumber<size_t>()));
          EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Error) && slice.get(arangodb::StaticStrings::Error).isBoolean() && true == slice.get(arangodb::StaticStrings::Error).getBoolean()));
          EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::ErrorNum) && slice.get(arangodb::StaticStrings::ErrorNum).isNumber<int>() && TRI_ERROR_FORBIDDEN == slice.get(arangodb::StaticStrings::ErrorNum).getNumber<int>()));
          auto view = vocbase.lookupView("testView");
          EXPECT_TRUE((false == !view));
        }

        // not authorized (RW user view with failing toVelocyPack())
        {
          arangodb::auth::UserMap userMap;
          auto& user = userMap.emplace("", arangodb::auth::User::newUser("", "", arangodb::auth::Source::LDAP)).first->second;
          user.grantDatabase(vocbase.name(), arangodb::auth::Level::RW);
          user.grantCollection(vocbase.name(), "testView", arangodb::auth::Level::RW);
          userManager->setAuthInfo(userMap); // set user map to avoid loading configuration from system database
          auto* testView = arangodb::LogicalView::cast<TestView>(logicalView.get());
          testView->_appendVelocyPackResult = arangodb::Result(TRI_ERROR_INTERNAL);
          auto resetAppendVelocyPackResult = std::shared_ptr<TestView>(testView, [](TestView* p)->void { p->_appendVelocyPackResult = arangodb::Result(); });

          auto status = handler.execute();
          EXPECT_TRUE((arangodb::RestStatus::DONE == status));
          EXPECT_TRUE((arangodb::rest::ResponseCode::SERVER_ERROR == responce.responseCode()));
          auto slice = responce._payload.slice();
          EXPECT_TRUE((slice.isObject()));
          EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Code) && slice.get(arangodb::StaticStrings::Code).isNumber<size_t>() && size_t(arangodb::rest::ResponseCode::SERVER_ERROR) == slice.get(arangodb::StaticStrings::Code).getNumber<size_t>()));
          EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Error) && slice.get(arangodb::StaticStrings::Error).isBoolean() && true == slice.get(arangodb::StaticStrings::Error).getBoolean()));
          EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::ErrorNum) && slice.get(arangodb::StaticStrings::ErrorNum).isNumber<int>() && TRI_ERROR_INTERNAL == slice.get(arangodb::StaticStrings::ErrorNum).getNumber<int>()));
          auto view = vocbase.lookupView("testView");
          EXPECT_TRUE((false == !view));
          slice = arangodb::LogicalView::cast<TestView>(*view)._properties.slice();
          EXPECT_TRUE((!slice.isObject()));
        }

        // authorzed (RW user)
        {
          arangodb::auth::UserMap userMap;
          auto& user = userMap.emplace("", arangodb::auth::User::newUser("", "", arangodb::auth::Source::LDAP)).first->second;
          user.grantDatabase(vocbase.name(), arangodb::auth::Level::RW);
          user.grantCollection(vocbase.name(), "testView", arangodb::auth::Level::RW);
          userManager->setAuthInfo(userMap); // set user map to avoid loading configuration from system database

          auto status = handler.execute();
          EXPECT_TRUE((arangodb::RestStatus::DONE == status));
          EXPECT_TRUE((arangodb::rest::ResponseCode::OK == responce.responseCode()));
          auto slice = responce._payload.slice();
          EXPECT_TRUE((slice.isObject()));
          EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::DataSourceName) && slice.get(arangodb::StaticStrings::DataSourceName).isString() && std::string("testView") == slice.get(arangodb::StaticStrings::DataSourceName).copyString()));
          EXPECT_TRUE((slice.hasKey("properties") && slice.get("properties").isObject() && slice.get("properties").hasKey("key") && slice.get("properties").get("key").isString() && std::string("value") == slice.get("properties").get("key").copyString()));
          auto view = vocbase.lookupView("testView");
          EXPECT_TRUE((false == !view));
          slice = arangodb::LogicalView::cast<TestView>(*view)._properties.slice();
          EXPECT_TRUE((slice.isObject()));
          EXPECT_TRUE((slice.hasKey("key") && slice.get("key").isString() && std::string("value") == slice.get("key").copyString()));
        }
    */
  }

  // test get view (basic)
  {
    auto createViewJson = arangodb::velocypack::Parser::fromJson(
        "{ \"name\": \"testView\", \"type\": \"testViewType\" }");
    TRI_vocbase_t vocbase(TRI_vocbase_type_e::TRI_VOCBASE_TYPE_NORMAL, 1,
                          "testVocbase");
    auto logicalView = vocbase.createView(createViewJson->slice());
    ASSERT_TRUE((false == !logicalView));
    auto requestPtr = std::make_unique<GeneralRequestMock>(vocbase);
    auto& request = *requestPtr;
    auto responcePtr = std::make_unique<GeneralResponseMock>();
    auto& responce = *responcePtr;
    arangodb::RestViewHandler handler(requestPtr.release(), responcePtr.release());

    request.addSuffix("testView");
    request.setRequestType(arangodb::rest::RequestType::GET);

    struct ExecContext : public arangodb::ExecContext {
      ExecContext()
          : arangodb::ExecContext(arangodb::ExecContext::Type::Default, "", "",
                                  arangodb::auth::Level::NONE,
                                  arangodb::auth::Level::NONE) {}
    } execContext;
    arangodb::ExecContextScope execContextScope(&execContext);
    auto* authFeature = arangodb::AuthenticationFeature::instance();
    auto* userManager = authFeature->userManager();
    arangodb::aql::QueryRegistry queryRegistry(0);  // required for UserManager::loadFromDB()
    userManager->setQueryRegistry(&queryRegistry);
    auto resetUserManager = std::shared_ptr<arangodb::auth::UserManager>(
        userManager,
        [](arangodb::auth::UserManager* ptr) -> void { ptr->removeAllUsers(); });

    // not authorized (missing user)
    {
      arangodb::auth::UserMap userMap;  // empty map, no user -> no permissions
      userManager->setAuthInfo(userMap);  // set user map to avoid loading configuration from system database

      auto status = handler.execute();
      EXPECT_TRUE((arangodb::RestStatus::DONE == status));
      EXPECT_TRUE((arangodb::rest::ResponseCode::FORBIDDEN == responce.responseCode()));
      auto slice = responce._payload.slice();
      EXPECT_TRUE((slice.isObject()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Code) &&
                   slice.get(arangodb::StaticStrings::Code).isNumber<size_t>() &&
                   size_t(arangodb::rest::ResponseCode::FORBIDDEN) ==
                       slice.get(arangodb::StaticStrings::Code).getNumber<size_t>()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Error) &&
                   slice.get(arangodb::StaticStrings::Error).isBoolean() &&
                   true == slice.get(arangodb::StaticStrings::Error).getBoolean()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::ErrorNum) &&
                   slice.get(arangodb::StaticStrings::ErrorNum).isNumber<int>() &&
                   TRI_ERROR_FORBIDDEN ==
                       slice.get(arangodb::StaticStrings::ErrorNum).getNumber<int>()));
    }

    // not authorized (failed detailed toVelocyPack(...)) as per https://github.com/arangodb/backlog/issues/459
    {
      arangodb::auth::UserMap userMap;
      auto& user =
          userMap
              .emplace("", arangodb::auth::User::newUser("", "", arangodb::auth::Source::LDAP))
              .first->second;
      user.grantDatabase(vocbase.name(), arangodb::auth::Level::RO);
      user.grantCollection(vocbase.name(), "testView", arangodb::auth::Level::NONE);  // for missing collections User::collectionAuthLevel(...) returns database auth::Level
      userManager->setAuthInfo(userMap);  // set user map to avoid loading configuration from system database
      auto* testView = arangodb::LogicalView::cast<TestView>(logicalView.get());
      testView->_appendVelocyPackResult = arangodb::Result(TRI_ERROR_FORBIDDEN);
      auto resetAppendVelocyPackResult =
          std::shared_ptr<TestView>(testView, [](TestView* p) -> void {
            p->_appendVelocyPackResult = arangodb::Result();
          });

      auto status = handler.execute();
      EXPECT_TRUE((arangodb::RestStatus::DONE == status));
      EXPECT_TRUE((arangodb::rest::ResponseCode::FORBIDDEN == responce.responseCode()));
      auto slice = responce._payload.slice();
      EXPECT_TRUE((slice.isObject()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Code) &&
                   slice.get(arangodb::StaticStrings::Code).isNumber<size_t>() &&
                   size_t(arangodb::rest::ResponseCode::FORBIDDEN) ==
                       slice.get(arangodb::StaticStrings::Code).getNumber<size_t>()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Error) &&
                   slice.get(arangodb::StaticStrings::Error).isBoolean() &&
                   true == slice.get(arangodb::StaticStrings::Error).getBoolean()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::ErrorNum) &&
                   slice.get(arangodb::StaticStrings::ErrorNum).isNumber<int>() &&
                   TRI_ERROR_FORBIDDEN ==
                       slice.get(arangodb::StaticStrings::ErrorNum).getNumber<int>()));
    }

    // authorized (NONE view) as per https://github.com/arangodb/backlog/issues/459
    {
      arangodb::auth::UserMap userMap;
      auto& user =
          userMap
              .emplace("", arangodb::auth::User::newUser("", "", arangodb::auth::Source::LDAP))
              .first->second;
      user.grantDatabase(vocbase.name(), arangodb::auth::Level::RO);
      user.grantCollection(vocbase.name(), "testView", arangodb::auth::Level::NONE);  // for missing collections User::collectionAuthLevel(...) returns database auth::Level
      userManager->setAuthInfo(userMap);  // set user map to avoid loading configuration from system database

      auto status = handler.execute();
      EXPECT_TRUE((arangodb::RestStatus::DONE == status));
      EXPECT_TRUE((arangodb::rest::ResponseCode::OK == responce.responseCode()));
      auto slice = responce._payload.slice();
      EXPECT_TRUE((slice.isObject()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::DataSourceName) &&
                   slice.get(arangodb::StaticStrings::DataSourceName).isString() &&
                   std::string("testView") ==
                       slice.get(arangodb::StaticStrings::DataSourceName).copyString()));
    }
    /* redundant because of above
        // not authorized (NONE view)
        {
          arangodb::auth::UserMap userMap;
          auto& user = userMap.emplace("", arangodb::auth::User::newUser("", "", arangodb::auth::Source::LDAP)).first->second;
          user.grantDatabase(vocbase.name(), arangodb::auth::Level::RO);
          user.grantCollection(vocbase.name(), "testView", arangodb::auth::Level::NONE); // for missing collections User::collectionAuthLevel(...) returns database auth::Level
          userManager->setAuthInfo(userMap); // set user map to avoid loading configuration from system database

          auto status = handler.execute();
          EXPECT_TRUE((arangodb::RestStatus::DONE == status));
          EXPECT_TRUE((arangodb::rest::ResponseCode::FORBIDDEN == responce.responseCode()));
          auto slice = responce._payload.slice();
          EXPECT_TRUE((slice.isObject()));
          EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Code) && slice.get(arangodb::StaticStrings::Code).isNumber<size_t>() && size_t(arangodb::rest::ResponseCode::FORBIDDEN) == slice.get(arangodb::StaticStrings::Code).getNumber<size_t>()));
          EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Error) && slice.get(arangodb::StaticStrings::Error).isBoolean() && true == slice.get(arangodb::StaticStrings::Error).getBoolean()));
          EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::ErrorNum) && slice.get(arangodb::StaticStrings::ErrorNum).isNumber<int>() && TRI_ERROR_FORBIDDEN == slice.get(arangodb::StaticStrings::ErrorNum).getNumber<int>()));
        }

        // authorzed (RO view)
        {
          arangodb::auth::UserMap userMap;
          auto& user = userMap.emplace("", arangodb::auth::User::newUser("", "", arangodb::auth::Source::LDAP)).first->second;
          user.grantDatabase(vocbase.name(), arangodb::auth::Level::RO);
          user.grantCollection(vocbase.name(), "testView", arangodb::auth::Level::RO);
          userManager->setAuthInfo(userMap); // set user map to avoid loading configuration from system database

          auto status = handler.execute();
          EXPECT_TRUE((arangodb::RestStatus::DONE == status));
          EXPECT_TRUE((arangodb::rest::ResponseCode::OK == responce.responseCode()));
          auto slice = responce._payload.slice();
          EXPECT_TRUE((slice.isObject()));
          EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::DataSourceName) && slice.get(arangodb::StaticStrings::DataSourceName).isString() && std::string("testView") == slice.get(arangodb::StaticStrings::DataSourceName).copyString()));
        }
    */
  }

  // test get view (detailed)
  {
    auto createViewJson = arangodb::velocypack::Parser::fromJson(
        "{ \"name\": \"testView\", \"type\": \"testViewType\" }");
    TRI_vocbase_t vocbase(TRI_vocbase_type_e::TRI_VOCBASE_TYPE_NORMAL, 1,
                          "testVocbase");
    auto logicalView = vocbase.createView(createViewJson->slice());
    ASSERT_TRUE((false == !logicalView));
    auto requestPtr = std::make_unique<GeneralRequestMock>(vocbase);
    auto& request = *requestPtr;
    auto responcePtr = std::make_unique<GeneralResponseMock>();
    auto& responce = *responcePtr;
    arangodb::RestViewHandler handler(requestPtr.release(), responcePtr.release());

    request.addSuffix("testView");
    request.addSuffix("properties");
    request.setRequestType(arangodb::rest::RequestType::GET);

    struct ExecContext : public arangodb::ExecContext {
      ExecContext()
          : arangodb::ExecContext(arangodb::ExecContext::Type::Default, "", "",
                                  arangodb::auth::Level::NONE,
                                  arangodb::auth::Level::NONE) {}
    } execContext;
    arangodb::ExecContextScope execContextScope(&execContext);
    auto* authFeature = arangodb::AuthenticationFeature::instance();
    auto* userManager = authFeature->userManager();
    arangodb::aql::QueryRegistry queryRegistry(0);  // required for UserManager::loadFromDB()
    userManager->setQueryRegistry(&queryRegistry);
    auto resetUserManager = std::shared_ptr<arangodb::auth::UserManager>(
        userManager,
        [](arangodb::auth::UserManager* ptr) -> void { ptr->removeAllUsers(); });

    // not authorized (missing user)
    {
      arangodb::auth::UserMap userMap;  // empty map, no user -> no permissions
      userManager->setAuthInfo(userMap);  // set user map to avoid loading configuration from system database

      auto status = handler.execute();
      EXPECT_TRUE((arangodb::RestStatus::DONE == status));
      EXPECT_TRUE((arangodb::rest::ResponseCode::FORBIDDEN == responce.responseCode()));
      auto slice = responce._payload.slice();
      EXPECT_TRUE((slice.isObject()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Code) &&
                   slice.get(arangodb::StaticStrings::Code).isNumber<size_t>() &&
                   size_t(arangodb::rest::ResponseCode::FORBIDDEN) ==
                       slice.get(arangodb::StaticStrings::Code).getNumber<size_t>()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Error) &&
                   slice.get(arangodb::StaticStrings::Error).isBoolean() &&
                   true == slice.get(arangodb::StaticStrings::Error).getBoolean()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::ErrorNum) &&
                   slice.get(arangodb::StaticStrings::ErrorNum).isNumber<int>() &&
                   TRI_ERROR_FORBIDDEN ==
                       slice.get(arangodb::StaticStrings::ErrorNum).getNumber<int>()));
    }

    // not authorized (failed detailed toVelocyPack(...))
    {
      arangodb::auth::UserMap userMap;
      auto& user =
          userMap
              .emplace("", arangodb::auth::User::newUser("", "", arangodb::auth::Source::LDAP))
              .first->second;
      user.grantDatabase(vocbase.name(), arangodb::auth::Level::RO);
      user.grantCollection(vocbase.name(), "testView", arangodb::auth::Level::NONE);  // for missing collections User::collectionAuthLevel(...) returns database auth::Level
      userManager->setAuthInfo(userMap);  // set user map to avoid loading configuration from system database
      auto* testView = arangodb::LogicalView::cast<TestView>(logicalView.get());
      testView->_appendVelocyPackResult = arangodb::Result(TRI_ERROR_FORBIDDEN);
      auto resetAppendVelocyPackResult =
          std::shared_ptr<TestView>(testView, [](TestView* p) -> void {
            p->_appendVelocyPackResult = arangodb::Result();
          });

      auto status = handler.execute();
      EXPECT_TRUE((arangodb::RestStatus::DONE == status));
      EXPECT_TRUE((arangodb::rest::ResponseCode::FORBIDDEN == responce.responseCode()));
      auto slice = responce._payload.slice();
      EXPECT_TRUE((slice.isObject()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Code) &&
                   slice.get(arangodb::StaticStrings::Code).isNumber<size_t>() &&
                   size_t(arangodb::rest::ResponseCode::FORBIDDEN) ==
                       slice.get(arangodb::StaticStrings::Code).getNumber<size_t>()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Error) &&
                   slice.get(arangodb::StaticStrings::Error).isBoolean() &&
                   true == slice.get(arangodb::StaticStrings::Error).getBoolean()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::ErrorNum) &&
                   slice.get(arangodb::StaticStrings::ErrorNum).isNumber<int>() &&
                   TRI_ERROR_FORBIDDEN ==
                       slice.get(arangodb::StaticStrings::ErrorNum).getNumber<int>()));
    }

    // authorized (NONE view) as per https://github.com/arangodb/backlog/issues/459
    {
      arangodb::auth::UserMap userMap;
      auto& user =
          userMap
              .emplace("", arangodb::auth::User::newUser("", "", arangodb::auth::Source::LDAP))
              .first->second;
      user.grantDatabase(vocbase.name(), arangodb::auth::Level::RO);
      user.grantCollection(vocbase.name(), "testView", arangodb::auth::Level::NONE);  // for missing collections User::collectionAuthLevel(...) returns database auth::Level
      userManager->setAuthInfo(userMap);  // set user map to avoid loading configuration from system database

      auto status = handler.execute();
      EXPECT_TRUE((arangodb::RestStatus::DONE == status));
      EXPECT_TRUE((arangodb::rest::ResponseCode::OK == responce.responseCode()));
      auto slice = responce._payload.slice();
      EXPECT_TRUE((slice.isObject()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::DataSourceName) &&
                   slice.get(arangodb::StaticStrings::DataSourceName).isString() &&
                   std::string("testView") ==
                       slice.get(arangodb::StaticStrings::DataSourceName).copyString()));
    }
    /* redundant because of above
        // not authorized (NONE view)
        {
          arangodb::auth::UserMap userMap;
          auto& user = userMap.emplace("", arangodb::auth::User::newUser("", "", arangodb::auth::Source::LDAP)).first->second;
          user.grantDatabase(vocbase.name(), arangodb::auth::Level::RO);
          user.grantCollection(vocbase.name(), "testView", arangodb::auth::Level::NONE); // for missing collections User::collectionAuthLevel(...) returns database auth::Level
          userManager->setAuthInfo(userMap); // set user map to avoid loading configuration from system database

          auto status = handler.execute();
          EXPECT_TRUE((arangodb::RestStatus::DONE == status));
          EXPECT_TRUE((arangodb::rest::ResponseCode::FORBIDDEN == responce.responseCode()));
          auto slice = responce._payload.slice();
          EXPECT_TRUE((slice.isObject()));
          EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Code) && slice.get(arangodb::StaticStrings::Code).isNumber<size_t>() && size_t(arangodb::rest::ResponseCode::FORBIDDEN) == slice.get(arangodb::StaticStrings::Code).getNumber<size_t>()));
          EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Error) && slice.get(arangodb::StaticStrings::Error).isBoolean() && true == slice.get(arangodb::StaticStrings::Error).getBoolean()));
          EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::ErrorNum) && slice.get(arangodb::StaticStrings::ErrorNum).isNumber<int>() && TRI_ERROR_FORBIDDEN == slice.get(arangodb::StaticStrings::ErrorNum).getNumber<int>()));
        }

        // authorzed (RO view)
        {
          arangodb::auth::UserMap userMap;
          auto& user = userMap.emplace("", arangodb::auth::User::newUser("", "", arangodb::auth::Source::LDAP)).first->second;
          user.grantDatabase(vocbase.name(), arangodb::auth::Level::RO);
          user.grantCollection(vocbase.name(), "testView", arangodb::auth::Level::RO);
          userManager->setAuthInfo(userMap); // set user map to avoid loading configuration from system database

          auto status = handler.execute();
          EXPECT_TRUE((arangodb::RestStatus::DONE == status));
          EXPECT_TRUE((arangodb::rest::ResponseCode::OK == responce.responseCode()));
          auto slice = responce._payload.slice();
          EXPECT_TRUE((slice.isObject()));
          EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::DataSourceName) && slice.get(arangodb::StaticStrings::DataSourceName).isString() && std::string("testView") == slice.get(arangodb::StaticStrings::DataSourceName).copyString()));
        }
    */
  }

  // test get all views
  {
    auto createView1Json = arangodb::velocypack::Parser::fromJson(
        "{ \"name\": \"testView1\", \"type\": \"testViewType\" }");
    auto createView2Json = arangodb::velocypack::Parser::fromJson(
        "{ \"name\": \"testView2\", \"type\": \"testViewType\" }");
    TRI_vocbase_t vocbase(TRI_vocbase_type_e::TRI_VOCBASE_TYPE_NORMAL, 1,
                          "testVocbase");
    auto logicalView1 = vocbase.createView(createView1Json->slice());
    ASSERT_TRUE((false == !logicalView1));
    auto logicalView2 = vocbase.createView(createView2Json->slice());
    ASSERT_TRUE((false == !logicalView2));
    auto requestPtr = std::make_unique<GeneralRequestMock>(vocbase);
    auto& request = *requestPtr;
    auto responcePtr = std::make_unique<GeneralResponseMock>();
    auto& responce = *responcePtr;
    arangodb::RestViewHandler handler(requestPtr.release(), responcePtr.release());

    request.setRequestType(arangodb::rest::RequestType::GET);

    struct ExecContext : public arangodb::ExecContext {
      ExecContext()
          : arangodb::ExecContext(arangodb::ExecContext::Type::Default, "", "",
                                  arangodb::auth::Level::NONE,
                                  arangodb::auth::Level::NONE) {}
    } execContext;
    arangodb::ExecContextScope execContextScope(&execContext);
    auto* authFeature = arangodb::AuthenticationFeature::instance();
    auto* userManager = authFeature->userManager();
    arangodb::aql::QueryRegistry queryRegistry(0);  // required for UserManager::loadFromDB()
    userManager->setQueryRegistry(&queryRegistry);
    auto resetUserManager = std::shared_ptr<arangodb::auth::UserManager>(
        userManager,
        [](arangodb::auth::UserManager* ptr) -> void { ptr->removeAllUsers(); });

    // not authorized (missing user)
    {
      arangodb::auth::UserMap userMap;  // empty map, no user -> no permissions
      userManager->setAuthInfo(userMap);  // set user map to avoid loading configuration from system database

      auto status = handler.execute();
      EXPECT_TRUE((arangodb::RestStatus::DONE == status));
      EXPECT_TRUE((arangodb::rest::ResponseCode::FORBIDDEN == responce.responseCode()));
      auto slice = responce._payload.slice();
      EXPECT_TRUE((slice.isObject()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Code) &&
                   slice.get(arangodb::StaticStrings::Code).isNumber<size_t>() &&
                   size_t(arangodb::rest::ResponseCode::FORBIDDEN) ==
                       slice.get(arangodb::StaticStrings::Code).getNumber<size_t>()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Error) &&
                   slice.get(arangodb::StaticStrings::Error).isBoolean() &&
                   true == slice.get(arangodb::StaticStrings::Error).getBoolean()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::ErrorNum) &&
                   slice.get(arangodb::StaticStrings::ErrorNum).isNumber<int>() &&
                   TRI_ERROR_FORBIDDEN ==
                       slice.get(arangodb::StaticStrings::ErrorNum).getNumber<int>()));
    }

    // not authorized (failed detailed toVelocyPack(...)) as per https://github.com/arangodb/backlog/issues/459
    {
      arangodb::auth::UserMap userMap;
      auto& user =
          userMap
              .emplace("", arangodb::auth::User::newUser("", "", arangodb::auth::Source::LDAP))
              .first->second;
      user.grantDatabase(vocbase.name(), arangodb::auth::Level::RO);
      user.grantCollection(vocbase.name(), "testView1", arangodb::auth::Level::NONE);  // for missing collections User::collectionAuthLevel(...) returns database auth::Level
      user.grantCollection(vocbase.name(), "testView2", arangodb::auth::Level::NONE);  // for missing collections User::collectionAuthLevel(...) returns database auth::Level
      userManager->setAuthInfo(userMap);  // set user map to avoid loading configuration from system database
      auto* testView = arangodb::LogicalView::cast<TestView>(logicalView2.get());
      testView->_appendVelocyPackResult = arangodb::Result(TRI_ERROR_FORBIDDEN);
      auto resetAppendVelocyPackResult =
          std::shared_ptr<TestView>(testView, [](TestView* p) -> void {
            p->_appendVelocyPackResult = arangodb::Result();
          });

      auto status = handler.execute();
      EXPECT_TRUE((arangodb::RestStatus::DONE == status));
      EXPECT_TRUE((arangodb::rest::ResponseCode::OK == responce.responseCode()));
      auto slice = responce._payload.slice();
      EXPECT_TRUE((slice.isObject()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Code) &&
                   slice.get(arangodb::StaticStrings::Code).isNumber<size_t>() &&
                   size_t(arangodb::rest::ResponseCode::OK) ==
                       slice.get(arangodb::StaticStrings::Code).getNumber<size_t>()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Error) &&
                   slice.get(arangodb::StaticStrings::Error).isBoolean() &&
                   false == slice.get(arangodb::StaticStrings::Error).getBoolean()));
      EXPECT_TRUE((slice.hasKey("result")));
      slice = slice.get("result");
      EXPECT_TRUE((slice.isArray()));
      EXPECT_TRUE((1U == slice.length()));
      slice = slice.at(0);
      EXPECT_TRUE((slice.isObject()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::DataSourceName) &&
                   slice.get(arangodb::StaticStrings::DataSourceName).isString() &&
                   std::string("testView1") ==
                       slice.get(arangodb::StaticStrings::DataSourceName).copyString()));
    }

    // authorized (NONE view) as per https://github.com/arangodb/backlog/issues/459
    {
      arangodb::auth::UserMap userMap;
      auto& user =
          userMap
              .emplace("", arangodb::auth::User::newUser("", "", arangodb::auth::Source::LDAP))
              .first->second;
      user.grantDatabase(vocbase.name(), arangodb::auth::Level::RO);
      user.grantCollection(vocbase.name(), "testView1", arangodb::auth::Level::NONE);  // for missing collections User::collectionAuthLevel(...) returns database auth::Level
      userManager->setAuthInfo(userMap);  // set user map to avoid loading configuration from system database

      vocbase.dropView(logicalView2->id(), true);  // remove second view to make test result deterministic
      auto status = handler.execute();
      EXPECT_TRUE((arangodb::RestStatus::DONE == status));
      EXPECT_TRUE((arangodb::rest::ResponseCode::OK == responce.responseCode()));
      auto slice = responce._payload.slice();
      EXPECT_TRUE((slice.isObject()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Code) &&
                   slice.get(arangodb::StaticStrings::Code).isNumber<size_t>() &&
                   size_t(arangodb::rest::ResponseCode::OK) ==
                       slice.get(arangodb::StaticStrings::Code).getNumber<size_t>()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::Error) &&
                   slice.get(arangodb::StaticStrings::Error).isBoolean() &&
                   false == slice.get(arangodb::StaticStrings::Error).getBoolean()));
      EXPECT_TRUE((slice.hasKey("result")));
      slice = slice.get("result");
      EXPECT_TRUE((slice.isArray()));
      EXPECT_TRUE((1U == slice.length()));
      slice = slice.at(0);
      EXPECT_TRUE((slice.isObject()));
      EXPECT_TRUE((slice.hasKey(arangodb::StaticStrings::DataSourceName) &&
                   slice.get(arangodb::StaticStrings::DataSourceName).isString() &&
                   std::string("testView1") ==
                       slice.get(arangodb::StaticStrings::DataSourceName).copyString()));
    }
  }
}