1
0
Fork 0
Commit Graph

16906 Commits

Author SHA1 Message Date
Dronplane 592063c503 Bug fix 3.4/data loss in view (#9658)
* Added full index iterator utilization in case of some documents was not found in collection

* Added index operations reversal in case of insertion failure in rocksdb

* Removed singleop optimization as rollback possible even for such operations (in case of index operation failure on insert)

* Added tests for insert rollback in views

* Added catch tests for view block

* Added changelog entry

* fixed jslint errors

* fixed linux build

* Added test for update

* Fix CHANGELOG sequence

* Add line

* Added reverts for update and remove failures

* Cleanup in test. Added throwing error in case of failed reversal

* fixed typo

Co-Authored-By: Simran <Simran-B@users.noreply.github.com>

* fixed build

* Applied review comments

* Applied review comments
2019-08-09 17:30:17 +03:00
Lars Maier d8bc3685d3 [3.4] Fast Leader Change (#9642)
* Intermediate state.

* Finished.
2019-08-09 14:02:04 +02:00
Lars Maier 508abc311e Fail the FailedLeader Job if the new leader fails. (3.4 port) (#9640) 2019-08-09 14:00:55 +02:00
Jan 3219e63381
less copying in ClusterInfo::loadPlan() (#9650) 2019-08-08 10:04:36 +02:00
Jan f95281471c
fix lagging agency callbacks (#9621) 2019-08-02 11:43:04 +02:00
Jan Christoph Uhde 5b2e3f041b disable-foxx 3.4 (#9593) 2019-07-31 10:58:42 +02:00
KVS85 cc9aa74e1a
Fix ArangoSearch view creation errors (#9598) 2019-07-29 20:42:57 +03:00
Jan Christoph Uhde 6211a5fc4f nested collect backport 3.4 (#9590)
* stop optimization for nested collects (#9484)

* Update CHANGELOG
2019-07-29 19:42:50 +03:00
Wilfried Goesgens 823cc1d8ee don't keep the memory stats in the collections to save disk space (#9583) 2019-07-29 08:45:51 +02:00
Wilfried Goesgens 19887387d1 Feature 3.4/add js isolate mem statistics (#9570) 2019-07-26 17:51:53 +02:00
Jan 51921c4129
fixed a bug in RTRIM implementation, fixed issue #9558 (#9564) 2019-07-25 13:04:21 +02:00
Jan 950aefe6b8
Bug fix 3.4/temporary directory fixes (#9550)
* added startup error for bad temporary directory setting

if the temporary directory (--temp.path) setting is identical to the database directory (--database.directory)
this can eventually lead to data loss, as temporary files may be created inside the temporary directory, causing
overwrites of existing database files/directories with the same names.
Additionally the temporary directory may be cleaned at some point, and this would lead to an unintended cleanup
of the database files/directories as well.
Now, if the database directory and temporary directory are set to the same path, there will be a startup error
warning about potential data loss (though in ArangoDB 3.4 allowing to continue the startup - in 3.5 and higher
we will abort the startup).
2019-07-24 12:46:27 +02:00
Jan 0c9290ea1b
fix a query abort error in smart joins if both collections were (#9533) 2019-07-22 14:55:20 +02:00
Dan Larkin-York 07344d7694 Fix typo and restructure to match. (#9530) 2019-07-22 09:45:07 +02:00
Jan 1a812b4b4f
Bug fix 3.4/fix races in collection creation (#9504) 2019-07-19 13:29:24 +02:00
Tobias Gödderz 94a84b6233 [3.4] Fix query snippet responsibility for views (#9460)
* Fix query snippet responsibility for views

Select one snippet per node id, instead of parent query id

* Updated CHANGELOG

* Fixed compile error
2019-07-18 10:59:53 +02:00
Jan 83227cb7a1
prevent duplicate actions from popping up (#9453) 2019-07-16 10:02:59 +02:00
Matthew Von-Maszewski 4ef47fc7bd BugFix 3.4: Some error results have messages that are not reporting (#9455) 2019-07-11 13:16:15 +02:00
Max Neunhöffer 75f0a63549
Various error reporting fixes plus Maintenance Current fix. (#9398)
* Cleanup new logging.
* Hand on error message from getLocalCollections.
* Better behaviour if a database was announce but has vanished since.
* Fix catch tests.
* Switch on maintenance debugging output.
* Fix maintenance reporting bugs.
* CHANGELOG.
* No error if follower cannot be dropped.
* Improvement to avoid copying.
* Add preconditions to FollowerInfo agency operations.
* Adjust timeouts.
* Use isEqualString instead of compareString.
* Fix Windows compilation.
2019-07-05 13:38:44 +02:00
Jan 3cedbe4a67
replace potentially unsafe binary comparisons with logical ones (#9380) 2019-07-04 14:56:38 +02:00
Simon 5eb4951d29 use a lock when calling unload (#9367) 2019-07-03 16:21:00 +02:00
Jan c655a89db6
make sure all errors are prefixed with ERROR_ @fceller @kvs85 (#9383) 2019-07-02 18:06:52 +02:00
Lars Maier 8bd34fd1e3 [3.4]Precs to check if collection exists (#9283)
* Adding preconditions for jobs to check that the collection still exists.

* Make it compile.

* Fixed tests.
2019-07-01 13:26:01 +02:00
Max Neunhöffer 5f9423057d
Fix agency election lockstep bug. (#9348)
* Fix agency election lockstep bug.

Reset the base point for the random election timeout to now whenever we have
cast a vote, be it for us or for some other server.

* CHANGELOG.
2019-06-27 21:05:59 +02:00
Simon 17468f1dc9 do not buffer index estimates (#9338) 2019-06-26 17:27:01 +02:00
Kaveh Vahedipour b97a62c0de if collection is gone in meantine ... (#9331) 2019-06-26 15:11:40 +02:00
Wilfried Goesgens 1be89f8ce7 Bug fix 3.4/fix snappy dependency chain (#9316)
* fix snappy build dependencies

* fix snowball invocation and dependencies (#9275)
2019-06-25 11:20:18 +02:00
Michael Hackstein f06706e53d Bug fix 3.4/create collections better preconditions (#9306)
* Backward port of #9296

* Updated changelog

* Updated changelog
2019-06-24 08:43:46 +02:00
Heiko 5d5eb23e7f Bug fix/gharial 3 4 edge from and tos verification (#9263)
* attempt to apply PR: pull/#9177

* changelog
2019-06-21 14:43:43 +02:00
Lars Maier 40a72f8b43 Added special lock for local data. Use read and write locking. Do not hold read lock during agency transactions. (#9284) 2019-06-21 14:31:43 +02:00
Lars Maier b7d4b9ab5a Release _to server when abort because of dropped collection or `something serious went wrong`. (#9268) 2019-06-17 15:03:07 +02:00
Dan Larkin-York e4cc3ac776 [3.4] Add drop-check for index creation in cluster (#9220)
* Add drop-check for index creation in cluster.

* Fix return.

* Add changelog entry.

* Address review comments.

* Revert change of shared_ptr to plain atomic.
2019-06-12 20:02:01 +02:00
Jan 65e7557f42 Bug fix 3.4/improve arangorestore (#9156)
* always import system collections first, so if importing some other collection fails later, the system collections are already in place

* properly disable enterprise features when restoring an enterprise dump into a community cluster

* disable enterprise features when restoring an enterprise dump into the community version

* fix handling of "duplicate name" issues when restoring system
collections
2019-06-09 20:21:07 +02:00
Kaveh Vahedipour a46fc0690b fix agency's ttl handling in object assignments (#9180) 2019-06-08 22:23:05 +02:00
Jan 2de2d92054
remove archived RocksDB WAL files on agent servers (#9230) 2019-06-08 19:40:07 +02:00
Michael Hackstein b14259b55e
Fix missed callbacks race condition (#9183)
* If we miss a callback in CollectionCreation also test if we missed later callbacks.

* Updated changelog

* Fixed callback lockers

* Remove lockers vector alltogether, we are protected by mutex anyways

* Fixed include guard

* Do not recheck the Collection that has woken us up

* Fixed recursive lock gathering
2019-06-06 14:07:41 +02:00
Frank Celler 4982ca6c3d class ManagedDocumentResult is not a struct 2019-06-06 12:05:31 +02:00
Jan Christoph Uhde 19190dc963 add shardKeyAttribute to pregel start parameters (#9157) 2019-06-05 14:27:26 +02:00
Jan efc0e6c6f6
fix path length checks when copying js files (#9190) 2019-06-05 10:40:37 +02:00
Frank Celler ae3b956568 fix for windows 2019-06-04 11:51:58 +02:00
Jan 6fa651dbe3
Bug fix 3.4/pregel micro improvements (#9178) 2019-06-04 09:32:29 +02:00
Jan 3dc27af242
improve error message (#9155) 2019-06-03 17:06:44 +02:00
Tobias Gödderz 755c2c2db7 [3.4] Fixed incorrect tracing in TraversalBlock (#9152)
* Trace WAITING results in TraversalBlock

* Added CHANGELOG entry

* Fixed state type
2019-06-03 09:26:43 +02:00
Kaveh Vahedipour 75f0a51d67 [3.4] fix clientid register in state (#9065)
* fix flientid register in state

* remove the log erase locations

* iterator check

* also clear considered

* emplaces also handled

* don't add if clientId empty

* move semantics for log_t

* forward log_t into deque. bail out also as follower, when log_t cannot be emplaced

* whitespaces

* change log

* fix agency test for leadership change during long transactions with clientId

* log_t was as good as it gets

* white spaces

* add clientIds the inc/dec test

* client id for inc/dec test

* Fix a typo in a message.

* Add a comment for better readability.

* Fix agency test.

* Take debugging out.

* Activate another old agency test.

* Fix client id.

* Consistent behaviour across branches.
2019-05-29 21:43:45 +02:00
Simon 87977d1228 Pregel segmented buffers (#9109) 2019-05-28 18:21:56 +02:00
Simon e1fdc04193 Bug fix 3.4/jobs indexes (#9099) 2019-05-27 11:43:05 +02:00
Jan e440a1c7d2
fix various small annoyances (#9078) 2019-05-23 17:37:34 +02:00
Wilfried Goesgens 8e0ebb00c6 Bugfix/backport fs changes (#9024) 2019-05-23 12:46:47 +02:00
Jan 6d0e2e58e7 fix VERSION file handling on upgrade (#9077) 2019-05-22 22:43:37 +03:00
Jan 7ef180c71e
fix crash (#9059) 2019-05-21 18:32:46 +02:00