1
0
Fork 0
Commit Graph

16756 Commits

Author SHA1 Message Date
Wilfried Goesgens f923a6a36e stop statistics in stop instead of unprepare (#7631) 2018-12-04 19:54:46 +01:00
Jan 6fc8bb4a45
speed up remove ops for RocksDB engine (#7639) 2018-12-04 19:23:49 +01:00
Jan c8cad8a4f8
try again in case of a conflict when updating users (#7614) 2018-12-04 16:51:21 +01:00
Heiko 442d59a3f8 added MultiPolygon GeoJSON constructor function (#7633) 2018-12-04 14:40:13 +01:00
Dan Larkin-York d621387051 Disable warning about persistent IDs during upgrade procedure. (#7612) 2018-12-04 09:02:19 +01:00
jsteemann 1dbaa9d5ab fix segfault 2018-12-04 08:57:11 +01:00
Jan fa4c9bfa05
dont keep JS module directory (#7618) 2018-12-03 18:25:59 +01:00
jsteemann 4ab4d7d7ab improve debug messages 2018-12-03 16:42:15 +01:00
Jan 7b93b1c8f9
Bug fix/dont fail when restoring cluster dump into single server (#7598) 2018-12-03 16:18:07 +01:00
Vasiliy e16be8f3db issue 505.1: move index json comparison into index-type-specific implementations to address issue with incorrect definition comparison (#7430)
* issue 505: move index json comparison into index-type-specific implementations to address issue with incorrect definition comparison

* remove commented-out code

* fix typo

* backport: add additional logging and fix typo
2018-12-03 16:26:08 +03:00
Lars Maier dd07d74d69 [devel] Bug fix/bad leader report current (#7585)
* Bug fix 3.4/bad leader report current (#7574)
* Initialize theLeader non-empty, thus not assuming leadership.
* Correct ClusterInfo to look into Target/CleanedServers.
* Prevent usage of to be cleaned out servers in new collections.
* After a restart, do not assume to be leader for a shard.
* Do nothing in phaseTwo if leader has not been touched. (#7579)
* Drop follower if it refuses to cooperate.

This is important since a dbserver that is follower for a shard will
after a reboot think that it is a leader, at least for a short amount
of time. If it came back quickly enough, the leader might not have
noticed that it was away.
2018-12-03 10:20:30 +01:00
Andrey Abramov d6de637cb7
treat all iresearch scores as float_t for 3.4 (#7573) (#7578)
* treat all iresearch scores as float_t for 3.4

* cleanup

* attempt to fix tests

* another attempt to fix tests
2018-12-02 15:55:42 +03:00
Dan Larkin-York 8449a185ec Port #7490. (#7559) 2018-11-30 17:26:29 +01:00
Jan 14c598c194
allow using UTF8 filenames for UUID directory (#7568) 2018-11-30 16:44:04 +01:00
Lars Maier 908df47cd7 [devel] Bug fix/cluster health ui timestamp (#7562) 2018-11-30 16:26:21 +01:00
Michael Hackstein 2d73f04008
Bug fix 3.4/syncing of followers (#7377) (#7535)
* Added some DEBUG output for replication rest handler

* Some more debug logging.

* Increased the priority of the ReplicationHandler. This way we will not get stuck with locks that cannot be canceled. Also cancel the lock on the correct database.

* Added extensive log output for replication thins

* Added tombstones to RestReplicationHandler. In a very unlikely case the cancel of a lock can be executed BEFORE the code that actually registers the lock, in this case we will now write a tombstone and do not lock.

* Revert "Added extensive log output for replication thins"

This reverts commit 6d4e37ea1e59e3b3457336019cc7dbc4c979504d.

* Added extensive log output for replication things, now in ERR level instead of MAINTAINER only

* Now actually use hours for synchronization

* React to errors under soft lock if they show up.

* Added a retry loop to increase the read-lock timer.

* Added more timeing output in RocksDB collection internals to figure out why the followers are dropped

* Tweaked RocksDB options

* Revert "Tweaked RocksDB options"

This reverts commit 2bf9c43280beda4792c47d079387fe5154cdd896.

* Removed debug output

* Applied all requested changes by goedderz

* Deleted unused variable
2018-11-30 14:43:04 +01:00
Jan 8c8472be48
Bug fix/issue 7522 (#7556) 2018-11-29 19:25:49 +01:00
Andrey Abramov e13f6e6f79
ensure UnorderedRefKeyMap keys are valid after copying (#7549)
* ensure UnorderedRefKeyMap keys are valid after copying

* minor improvement
2018-11-29 20:46:36 +03:00
jsteemann b7221bc3a5 Revert "fixed some asan search stuff (#7544)"
This reverts commit 617674adfd.
2018-11-29 16:33:11 +01:00
Jan 5e8002adc7
fix assertion (#7527) 2018-11-29 15:43:00 +01:00
Heiko 617674adfd fixed some asan search stuff (#7544) 2018-11-29 15:20:24 +01:00
Lars Maier 52cff7ad55 Feature/engine version added to agent configuration (#7481) (#7524)
* agents' is obtained from leader's configuration
* corrections in Supervision for advertised endpoints
* change log
* Updated Documentation for cluster/health.
* Unified naming convention.
* Fixed missing update of volatile fields.
* Set version in right order.
* Removed debug output.
* Fixed jslint - missing ;
2018-11-29 14:25:40 +01:00
Simon 17a95710bd Micro-Optimize AQL CXX calls (#7486) (#7489)
(cherry picked from commit 8ddb9a063b)
2018-11-29 14:00:41 +01:00
Simon 6f8829a623 Document RocksDB exclusive option (#7517)
* Document exclusive option, use in more cases

* address review comments
2018-11-29 13:59:07 +01:00
Andrey Abramov 2a0fa4946e
improve logging in ClusterInfo::loadPlan (#7511)
* improve logging in ClusterInfo::loadPlan

* address review comments
2018-11-29 15:56:51 +03:00
Andrey Abramov 6674a4282d
avoid calling cluster related functions while instantiating views on … (#7509)
* avoid calling cluster related functions while instantiating views on a db server

* minor cleanup
2018-11-29 15:43:53 +03:00
Jan adc651e338
Bug fix/cxxcheck 28112018 (#7518) 2018-11-29 13:39:04 +01:00
Max Neunhöffer a16fbf5df3
Improve log messages. (#7521) 2018-11-29 11:30:52 +01:00
Jan be0f8b59fa
added option `--rocksdb.enforce-block-cache-size-limit` (#7505) 2018-11-28 21:02:45 +01:00
Jan b2924057e7
cleanup (#7507) 2018-11-28 19:42:37 +01:00
Jan 59868fdf04
Bug fix/use lock for pregel stats (#7499) 2018-11-28 18:39:27 +01:00
Max Neunhöffer ae29e5d2ba
Fix index creation in cluster. (#7440)
* Fix index creation in cluster.

Simplify and correct error handling logic in ensureIndexCoordinator.

* After index creation, wait until index appears.

We wait until the Supervision has removed the isBuilding flag and
the coordinator has reloaded the Plan.

* More index handling fixes.

* Directly remove isBuilding in ensureIndexCoordinator (again).

* Fix catch tests by holding mutex shorter.

* Better mutex handling in ClusterInfo.
2018-11-28 16:58:05 +01:00
Jan 683d45bd68
Feature/micro optimizations 28112018 (#7496) 2018-11-28 15:57:10 +01:00
Jan 1bef7e842c
do not allow MMFiles single document operations overtaking each other… (#7469) 2018-11-28 13:03:47 +01:00
Andrey Abramov 95fd5793a1
Bug fix/internal issue #502 (#7480)
* update iresearch

* update iresearch
2018-11-27 22:53:19 +03:00
Simon d0efd95a37 Bug fix/restore index refactor (#7470) 2018-11-27 20:22:36 +01:00
Vasiliy 59e002841f issue 506.3: use camel-case configuration parameter names consistntly, add a configuration version property to iresearch view meta (#7475)
* issue 506.3: use camel-case configuration parameter names consistntly, add a configuration version property to iresearch view meta

* backport: ensure meta version is supported

* backport: hide 'version' property from non-persistence json
2018-11-27 18:35:33 +03:00
Vasiliy 2d0a75f0d5 issue 506.2: add optimization to not reexecute a primary-key filter if a match was already found (#7460)
* issue 506.2: add optimization to not reexecute a primary-key filter if a match was already found

* backport: explicitly check type of instance of the primary-key filter

* backport: return non-null prepared filter and convert check to assert
2018-11-27 18:29:35 +03:00
Lars Maier f3ade0f860 Version/Engine Cluster Health (#7474)
* Export Version and Engine in Cluster Health. Additionally export `versionString` in registered Servers.

* Updated Changelog.
2018-11-27 14:56:00 +01:00
jsteemann 7213b80c6c increase shutdown time 2018-11-27 13:46:10 +01:00
Dan Larkin-York 6d542e11c8 Fix end condition (hasMore) for EnumerateViewNode. (#7279)
* Fix end condition (hasMore) for EnumerateViewNode.

* Fix crashes.

* Some more fixes.

* eliminate code duplication
2018-11-26 23:41:58 +03:00
Tobias Gödderz 0d5f85e684 Fix error handling in case ClusterCommResult.result == nullptr (#7356) 2018-11-26 16:23:44 +01:00
Vasiliy 21c832248c issue 506.1: address issue with multiple identical document insertions on rocksdb recovery (#7452) 2018-11-26 17:18:05 +03:00
Max Neunhöffer d72e51ed8f
Fix move leader shard. (#7445)
* Ungreylist move shard test.
* Move leader shard: wait until all but the old leader are in sync.
* Increate moveShard timeout to 10000 seconds.
* Add CHANGELOG entry.
* Fix compilation.
* Fix a misleading comment.
2018-11-26 15:04:04 +01:00
jsteemann d5acd724f1 remove dead code 2018-11-26 09:58:24 +01:00
jsteemann b4e888ef13 revert Scheduler changes 2018-11-26 09:57:53 +01:00
Simon f90b48f792 switch default message for requireFromPresent (#7439) 2018-11-23 18:59:03 +01:00
Michael Hackstein 16d0874da5
Bug fix/synchronous replication catchup (#7146)
* merged fixes from 3.4

* odd fix

* Bug fix 3.4/sync repl release thread (#6784)

* First attempt to not block the thread that requires the EXCLUSIVE sync-up lock

* Fixed insertion of query into registry in rest replication handler.

* Removed unnecessary / false asserts as suggested in review. Fixed code comments.

* Replaced auto with a correct type as suggested in review

* Added a helper function to validate if a query is in use in the registry

* Fixed logic bug in usage of query registry

* Fixed compile issue

* Automaticly transfrom int -> bool in initializerlist sucks...

* Inverted boolen logic bug hidden due to int->bool beeing logically inverted.

* Today it seems that bools are too complicated for my brain.

* Removed failure point, didn't write a test for it, and it is hard to write it in the current test environment. Need to find a better solution in future

* Applied chenges required by @goedderz in review

* Bug fix 3.4/shorter foot in door (#7084)

* Implement `syncCollectionCatchup` in DatabaseTailingSyncer.

First stab, might not even compile.

* Fixed a typo.

* Fix a typo and a compilation problem.

* Further compilation fix.

* Implement two stage catchup.

* Two small corrections.

* Unified error messages in Synchronize shard job.

* Improved a code comment.

* Fixed autocasting bool->double and double->bool issue. That is truely one of the best features ever invented... </irony>

* Renamed doHardLock => toSoftLockOnly and inverted default value

* Merged soft/hard foot logic with Transaction splits

* Use scopeguards to cancel readlocks

* Bug fix 3.4/sync replication allow soft and hard lock (#6864)

* First attempt to not block the thread that requires the EXCLUSIVE sync-up lock

* Fixed insertion of query into registry in rest replication handler.

* Removed unnecessary / false asserts as suggested in review. Fixed code comments.

* Replaced auto with a correct type as suggested in review

* Added a helper function to validate if a query is in use in the registry

* Fixed logic bug in usage of query registry

* Fixed compile issue

* Implemented optional 'doHardLock' parameter in the replication acquire read-lock call. A hard-lock guarntees to stop all writes, a soft-lock may not.

* Fixed compile issue

* Automaticly transfrom int -> bool in initializerlist sucks...

* Inverted boolen logic bug hidden due to int->bool beeing logically inverted.

* Today it seems that bools are too complicated for my brain.

* Removed failure point, didn't write a test for it, and it is hard to write it in the current test environment. Need to find a better solution in future

* Applied chenges required by @goedderz in review

* Renamed doHardLock => toSoftLockOnly and inverted default value
2018-11-23 16:16:34 +01:00
Wilfried Goesgens ce5273c852 Bug fix/handle nullptr (#7432)
* handle more potential nullptrs, fix try/catch scope

* fix none reply
2018-11-23 12:52:30 +01:00
Simon c584527d79 Fix restore of views, add --view option (#7425) 2018-11-22 19:24:24 +01:00