1
0
Fork 0
Commit Graph

16925 Commits

Author SHA1 Message Date
Kaveh Vahedipour 36d7e3628b DropCollection is a FAST_LANE action and should not need much time or else retry. (#9897) 2019-09-04 14:48:50 +02:00
Jan ea5106ff60 Bug fix 3.4/babies unknown shard (#9872)
* release version 3.4.8

* [3.4] fix agency lockup when removing 404-ed callbacks (#9839)

* fix non-deterministic occurrences of "document not found" in sharded
collections with custom sharding and multi-document lookup

* updated CHANGELOG

* fix error code handling

* Update CHANGELOG
2019-09-03 23:58:14 +03:00
Kaveh Vahedipour 694799be5b url instead path (#9879)
* [3.4] fix agency lockup when removing 404-ed callbacks (#9839)

* typo
2019-09-02 17:37:23 +03:00
Kaveh Vahedipour 3f554f15d1 [3.4] fix agency lockup when removing 404-ed callbacks (#9839) 2019-09-02 16:13:37 +02:00
Jan 0935bb898e issue #9794: Limit with offset results in an infinite query that can't be cancelled (#9819) 2019-08-27 16:23:21 +03:00
Dan Larkin-York 4a0383849f [3.4] Minimize unnecessary dropping of followers due to poorly set synchronous replication timeouts (#9811)
* Minimize unnecessary dropping of followers due to poorly set synchronous replication timeouts.

* Add changelog entry.

* Add setIntroducedIn version.
2019-08-27 11:45:37 +03:00
Dronplane 12ec3f63d1 Bug fix 3.4/issue #9795 (#9807) 2019-08-27 10:32:36 +02:00
Frank Celler ed41809dba use LDAP_PATH instead of fixed one (#9812) 2019-08-27 10:22:29 +02:00
Jan 0360c251cc Bug fix 3.4/multi bugs (#9791)
* add whitespace to make error message more readable

* Don't retry persisting follower information

for collections/shards already dropped.
The previous implementation retried (unsuccessfully in this case)
for up to 2 hours, occupying one scheduler thread.
2019-08-26 15:50:56 +03:00
Kaveh Vahedipour 59b78a1ec4 [3.4] back port of agency call back cleanup (#9723)
* back port of agency call back cleanup
* storecallback missing
* revert callback bodies to API specification
* array needs be inside so that multiple unobserves to same key are possible
2019-08-23 10:12:11 +02:00
Lars Maier 6f4eb0e89f [3.4] Move Shard Bug 4567124 (#9741)
* Fixed abort in moveshard in the case new leader is not in Current.
* Updated Changelog.
* Fixed special case if to server is follower.
2019-08-20 11:39:45 +02:00
Jan eb5f4241a5 issue #9654 (#9752) 2019-08-19 23:18:57 +03:00
Lars Maier 562ee69ca4 [3.4] Backported TakeoverLeadership action. (#9732)
* Backported TakeoverLeadership action.
* Fix a LOG_DEVEL.
2019-08-16 17:31:02 +02:00
Max Neunhöffer 6720427b72
Fix an agency bug found in Windows tests. (#9729)
* Fix agency bug found in Windows tests.
* CHANGELOG.
2019-08-16 12:16:11 +02:00
Matthew Von-Maszewski 38b9ec80b8
Bugfix 3.4: Clean up rocksdb getStatistics() (#9703)
* clean up basic rocksdb statistics.  More clean-up needed.

* add rocksdb throttle value to statistics

* update comments about rocksdb properties

* rename function per PR comments
2019-08-13 13:10:45 -04:00
Kaveh Vahedipour 5c8aee1b67 Bug fix 3.4/node corrections (#9417)
* op:set should have new, some operators should not create non existing keys
* this is the proper direction
* observe/unobserve have no business in Node
* normalization of URI
* agency test added for observe / unobserve
* more tests
* Fixed catch tests.
2019-08-13 15:15:45 +02:00
Jan 49ad6fd290
fixed issue #9679 (#9683) 2019-08-12 14:59:22 +02:00
Jan fdbf2eb1e8
various replication improvements: (#9674)
- better debuggability (more log details)
- shorter minimum wait delay in active failover
- fixed too early pruning of WAL files on leaders
2019-08-12 10:44:50 +02:00
Lars Maier 6b04e3de03 Ported ResignLeadership to 3.4 (#9669)
* Ported ResignLeadership to 3.5

* Added http route.
2019-08-09 16:41:13 +02:00
Dronplane 592063c503 Bug fix 3.4/data loss in view (#9658)
* Added full index iterator utilization in case of some documents was not found in collection

* Added index operations reversal in case of insertion failure in rocksdb

* Removed singleop optimization as rollback possible even for such operations (in case of index operation failure on insert)

* Added tests for insert rollback in views

* Added catch tests for view block

* Added changelog entry

* fixed jslint errors

* fixed linux build

* Added test for update

* Fix CHANGELOG sequence

* Add line

* Added reverts for update and remove failures

* Cleanup in test. Added throwing error in case of failed reversal

* fixed typo

Co-Authored-By: Simran <Simran-B@users.noreply.github.com>

* fixed build

* Applied review comments

* Applied review comments
2019-08-09 17:30:17 +03:00
Lars Maier d8bc3685d3 [3.4] Fast Leader Change (#9642)
* Intermediate state.

* Finished.
2019-08-09 14:02:04 +02:00
Lars Maier 508abc311e Fail the FailedLeader Job if the new leader fails. (3.4 port) (#9640) 2019-08-09 14:00:55 +02:00
Jan 3219e63381
less copying in ClusterInfo::loadPlan() (#9650) 2019-08-08 10:04:36 +02:00
Jan f95281471c
fix lagging agency callbacks (#9621) 2019-08-02 11:43:04 +02:00
Jan Christoph Uhde 5b2e3f041b disable-foxx 3.4 (#9593) 2019-07-31 10:58:42 +02:00
KVS85 cc9aa74e1a
Fix ArangoSearch view creation errors (#9598) 2019-07-29 20:42:57 +03:00
Jan Christoph Uhde 6211a5fc4f nested collect backport 3.4 (#9590)
* stop optimization for nested collects (#9484)

* Update CHANGELOG
2019-07-29 19:42:50 +03:00
Wilfried Goesgens 823cc1d8ee don't keep the memory stats in the collections to save disk space (#9583) 2019-07-29 08:45:51 +02:00
Wilfried Goesgens 19887387d1 Feature 3.4/add js isolate mem statistics (#9570) 2019-07-26 17:51:53 +02:00
Jan 51921c4129
fixed a bug in RTRIM implementation, fixed issue #9558 (#9564) 2019-07-25 13:04:21 +02:00
Jan 950aefe6b8
Bug fix 3.4/temporary directory fixes (#9550)
* added startup error for bad temporary directory setting

if the temporary directory (--temp.path) setting is identical to the database directory (--database.directory)
this can eventually lead to data loss, as temporary files may be created inside the temporary directory, causing
overwrites of existing database files/directories with the same names.
Additionally the temporary directory may be cleaned at some point, and this would lead to an unintended cleanup
of the database files/directories as well.
Now, if the database directory and temporary directory are set to the same path, there will be a startup error
warning about potential data loss (though in ArangoDB 3.4 allowing to continue the startup - in 3.5 and higher
we will abort the startup).
2019-07-24 12:46:27 +02:00
Jan 0c9290ea1b
fix a query abort error in smart joins if both collections were (#9533) 2019-07-22 14:55:20 +02:00
Dan Larkin-York 07344d7694 Fix typo and restructure to match. (#9530) 2019-07-22 09:45:07 +02:00
Jan 1a812b4b4f
Bug fix 3.4/fix races in collection creation (#9504) 2019-07-19 13:29:24 +02:00
Tobias Gödderz 94a84b6233 [3.4] Fix query snippet responsibility for views (#9460)
* Fix query snippet responsibility for views

Select one snippet per node id, instead of parent query id

* Updated CHANGELOG

* Fixed compile error
2019-07-18 10:59:53 +02:00
Jan 83227cb7a1
prevent duplicate actions from popping up (#9453) 2019-07-16 10:02:59 +02:00
Matthew Von-Maszewski 4ef47fc7bd BugFix 3.4: Some error results have messages that are not reporting (#9455) 2019-07-11 13:16:15 +02:00
Max Neunhöffer 75f0a63549
Various error reporting fixes plus Maintenance Current fix. (#9398)
* Cleanup new logging.
* Hand on error message from getLocalCollections.
* Better behaviour if a database was announce but has vanished since.
* Fix catch tests.
* Switch on maintenance debugging output.
* Fix maintenance reporting bugs.
* CHANGELOG.
* No error if follower cannot be dropped.
* Improvement to avoid copying.
* Add preconditions to FollowerInfo agency operations.
* Adjust timeouts.
* Use isEqualString instead of compareString.
* Fix Windows compilation.
2019-07-05 13:38:44 +02:00
Jan 3cedbe4a67
replace potentially unsafe binary comparisons with logical ones (#9380) 2019-07-04 14:56:38 +02:00
Simon 5eb4951d29 use a lock when calling unload (#9367) 2019-07-03 16:21:00 +02:00
Jan c655a89db6
make sure all errors are prefixed with ERROR_ @fceller @kvs85 (#9383) 2019-07-02 18:06:52 +02:00
Lars Maier 8bd34fd1e3 [3.4]Precs to check if collection exists (#9283)
* Adding preconditions for jobs to check that the collection still exists.

* Make it compile.

* Fixed tests.
2019-07-01 13:26:01 +02:00
Max Neunhöffer 5f9423057d
Fix agency election lockstep bug. (#9348)
* Fix agency election lockstep bug.

Reset the base point for the random election timeout to now whenever we have
cast a vote, be it for us or for some other server.

* CHANGELOG.
2019-06-27 21:05:59 +02:00
Simon 17468f1dc9 do not buffer index estimates (#9338) 2019-06-26 17:27:01 +02:00
Kaveh Vahedipour b97a62c0de if collection is gone in meantine ... (#9331) 2019-06-26 15:11:40 +02:00
Wilfried Goesgens 1be89f8ce7 Bug fix 3.4/fix snappy dependency chain (#9316)
* fix snappy build dependencies

* fix snowball invocation and dependencies (#9275)
2019-06-25 11:20:18 +02:00
Michael Hackstein f06706e53d Bug fix 3.4/create collections better preconditions (#9306)
* Backward port of #9296

* Updated changelog

* Updated changelog
2019-06-24 08:43:46 +02:00
Heiko 5d5eb23e7f Bug fix/gharial 3 4 edge from and tos verification (#9263)
* attempt to apply PR: pull/#9177

* changelog
2019-06-21 14:43:43 +02:00
Lars Maier 40a72f8b43 Added special lock for local data. Use read and write locking. Do not hold read lock during agency transactions. (#9284) 2019-06-21 14:31:43 +02:00
Lars Maier b7d4b9ab5a Release _to server when abort because of dropped collection or `something serious went wrong`. (#9268) 2019-06-17 15:03:07 +02:00