* Index late materialization draft
* Index late materialization. Refactoring.
* Index late materialization. Expansion draft.
* HashIndexMock
* Refactoring.
* Hash index mock expansion fixes
* Fix compare of attributes.
* Hash index mock. Last expansion support.
* Hash index mock. Take value for array from document, not equal key.
* Optimizations.
* Query tests
* lateMaterialized improvements
* velocypack fixes and tests for index node
* Fix after merge.
* Const expression in a condition test
* Clone tests
* More tests
* Fix for materialized view (nullptr var)
* Fixed index vars registers count planning
* javascript tests
* Fixed cluster tests
* Cluster support
* MaterializeExecutor and MaterializerExecutorInfos refactoring
* More tests
* js tests rocksdb only
* js test. Removed print()
* js testd added skiplist
* C++ unit tests for invalid json
* js test var i
* js tests == -> ===
* iFix js tests ===
* jslint ;
* int unsigned int fix
* double deletion fix
* refactoring
* Added const for collection source
* override final, added materialize namespace, fixed femove in hash index mock
* Removed expansion support. Index can contain null value in case of several object with same fields
* isNumber<>
* Optimization for single collection case
* Renaming
* refactoring
* Unit tests. Added checking documents
* !sliceIt.valid() instead of !(!=)
* Fix primary index (object instead of array)
* Edge collection test
* Windows compilation fix
* IndexExecutor getCallback optimization
* ADB_UNLIKELY
* explainer.js
* removed unsused variable in js test
* fix explainer.js
* do not use several indexes with js test
* Removed several indexes implementation
* space
* fix explainer.js
* fix explainer.js
* code alignment
* Squashed commit of the following:
commit dd4b85fcaa634ed829e79e266ee547c0522e71f6
Merge: 9fc1548e54 fa7de56cf8
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Jan 10 10:21:26 2019 +0100
Merge branch 'devel' into feature/cpp17
* devel:
upgrade to boost 1.69.0 (#7910)
Doc - Add a paragraph that JS JS trxs are excluded from intermediate commits. (#7919)
issue 511.7.3: restore single-document optimization, implement call to update data-store options, add IResearchView upgrade step (#7918)
improve assertions (#7830)
fix MSVC warning
remove unused function
fix#7900 - null bind values do not change to empty string anymore (#7917)
commit 9fc1548e54f8cfd2990e7ae0b2b7ae3da55a2cd2
Merge: f2ecee8136 e7810e1956
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Jan 9 09:36:19 2019 +0100
Merge remote-tracking branch 'origin/devel' into feature/cpp17
* origin/devel:
Doc - Update remark about per-database replication (#7891)
Doc - Known Issues - new links (#7908)
support db._explain with all plans (#7895)
JWT base64url encoding (#7899)
cppcheck/Scheduler (#7909)
multiplex REPLICATION-APPLIER-STATE files for RocksDB engine (#7898)
fix compile warnings
upgrade bundled curl library to version 7.63 (#7846)
Feature/new server infra (#7733)
Doc - check_function (#7885)
simran (#7881)
added AQL function CHECK_DOCUMENT (#7842)
added arangorestore option `--cleanup-duplicate-attributes` (#7877)
Doc - arangorestore improvements (#7878)
added arangorestore options `--number-of-shards` and `--replication-f… (#7869)
commit f2ecee81360f0f0c19901accdbc9902304814bb2
Merge: 44adf97fa0 5c53ebceb0
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Thu Jan 3 10:51:20 2019 +0100
Merge remote-tracking branch 'origin/devel' into feature/cpp17
* origin/devel: (40 commits)
Feature/jwt keyfile (#7863)
prevent duplicate attributes being generated by AQL queries (#7837)
fixed issue #7834 (#7843)
Bug fix/issues 23122018 (#7847)
Documents that arangorestore/arangodump threads option is from v3.4.0 on (#7701)
Update ISSUE_TEMPLATE.md (#7103)
Doc - Forwardports to devel - 2018-12-27 (#7858)
Doc - Sync-external-repo-2018-12-25 (#7854)
Doc - re-add switching storage engine section (#7781)
Doc - Fix build (whitespaces, triple-backticks, comments) (#7857)
Add http_server test for creating view with links (#7852)
big reformat
added new clang style and reformat script for clang-format 6.0
Doc - Improve MacOS Installation page (#7744)
Fix issue with geo iterator reset. (#7839)
Doc - Single Instance vs. Cluster (diff + migration) (#7739)
Rdb index background (preliminary) (#7644)
iResearch asan issue (#7832)
Feature/improve edgeindex covered (#7718)
issue 511.6: update iresearch to 6e870904eae5eaf891359ed06e7332666c02cb19 (#7819)
...
commit 44adf97fa0bc9cc7dc649c98916a91dba456b956
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Tue Dec 18 13:39:03 2018 +0100
Add COMPILER_* variables to VERSIONS file.
The variables will be used to select a fitting compiler in the CI.
Developers need to ensure themselves that their development environment
supports the c++ standard.
commit 8124eb3b44fb2302cdd7250d1573b25135719e41
Merge: 127bb7d1cb 4423125a7f
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Tue Dec 18 11:09:42 2018 +0100
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/cpp17
* 'devel' of https://github.com/arangodb/arangodb: (381 commits)
tools are now looking into the build to find the file (#7128)
issue 511.3: remove IResearchViewDBServer and use the IResearchView directly on db-server (#7748)
Fix S2 for aarch64. (#7770)
equalising devel and 3.4 in agency/cluster (#7755)
wording
startLocalCluster in rr debugging mode cannot be started with --console on agents / db servers (#7776)
fix cmake parameters coincidence (#7774)
Fix a rare deadlock situation in Replication sync phase (#7759)
add virtual dtor
wait for procdump to exit too. (#7731)
fix invalid handling of `_lastValue` in case of multiple coordinators (#7734)
fixed item 3 of issue #7009 (#7747)
updated 3rdparty licenses
remove inclusion of valgrind.h
remove now-unused file
Bug fix/fix thread shutdown (#7728)
Doc - fix build by adding missing SUMMARY entries (#7741)
issue 511.2.1: use references instead of raw pointers for Index operations to avoid null pointer access (#7725)
port 3.4 change to stopBackgroundThreads. Move ClusterCommThread routines to same place in source file. (#7721)
Ignore invaild geo coordinates when indexing. (#7724)
...
commit 127bb7d1cb56fb71b06613971c896aedc1817a98
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Oct 15 22:06:27 2018 +0200
fix invoke for c++17
commit 65a514c34472a611167cd01e14efd5dccc9ae2d1
Author: Frank Celler <frank@arangodb.com>
Date: Mon Oct 15 18:58:31 2018 +0200
trying to use 17
commit 8344d96e43522757813bb37e10b95ae83ff35abf
Merge: 2822dae6e1 c7933bcb31
Author: Frank Celler <frank@arangodb.com>
Date: Mon Oct 15 18:08:52 2018 +0200
Merge branch 'devel' of ssh://github.com/arangodb/ArangoDB into feature/cpp17
commit 2822dae6e175e866106c49ed8e1f5248dcef0b62
Merge: 4001d11afd af2f18fcbf
Author: Frank Celler <frank@arangodb.com>
Date: Fri Oct 12 17:44:04 2018 +0200
Merge branch 'feature/boost-168' of ssh://github.com/arangodb/ArangoDB into feature/cpp17
commit 4001d11afd6ed691ce9dcce34b1ee7b75a08be4b
Author: Frank Celler <frank@arangodb.com>
Date: Fri Oct 12 17:43:46 2018 +0200
fixed merge conflict
commit 94cb4b7d4c43c7c12db7ccc3c7cb1c1885e9fafa
Merge: cbc2f34bb4 d3c446156c
Author: Frank Celler <frank@arangodb.com>
Date: Fri Oct 12 14:35:42 2018 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/cpp17
commit af2f18fcbf709a86e76feb5165ea848f3d4eba67
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Fri Sep 28 14:44:16 2018 +0200
add bcrypt.lib to make uuid work
commit 11efd1299a40a38ef92d717a8ee9e882fc77c82b
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Sep 19 12:31:25 2018 +0200
fix boost path for iresearch that is not able to use the provided
information
commit 57ed116b6c7c5fda1180929c4f1d63895c25ea1f
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Sep 19 10:24:10 2018 +0200
add missing boost core includes
commit 5d52b322a0fa8fccb4c0d50f5677f7c4b0505284
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Sep 19 09:22:43 2018 +0200
upgrade boost to version 1.68.0
commit cbc2f34bb475f988fc407b2fd332d9984fc682db
Merge: 3de8d481e6 1b1142647a
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Sep 19 12:08:13 2018 +0200
Merge branch 'feature/cpp17' of https://github.com/arangodb/arangodb into feature/cpp17
* 'feature/cpp17' of https://github.com/arangodb/arangodb:
allow MSVC to user autopointer with c++17
nightly frontend build
Remove unused variable check from arangodump. (#6529)
fixed JavaScript error
added a reserve call
Bug fix/simplify things (#6516)
catch 501 (not implemented) in the query editor (ui) (#6523)
return error codes in case a babies remove operation fails (#6527)
Use physical collection directly (#6526)
Feature/aql item block compression (#6514)
move tests to the right location
take over selectivity estimates (#6505)
Properly check syncer erros, catch more exceptions (#6520)
prevent out-of-bounds array access
Fix deduplication in IndexBlock (#6508)
commit 3de8d481e6c40ab1b160ca931b23882fe36048c2
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Sep 19 12:05:56 2018 +0200
add autopointer and tr1
commit 1b1142647ac79764c55c0688c1b22a0227c7fad6
Merge: 4b38f0a7a0 0dd277d325
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Sep 19 10:06:01 2018 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/cpp17
* 'devel' of https://github.com/arangodb/arangodb:
nightly frontend build
Remove unused variable check from arangodump. (#6529)
fixed JavaScript error
added a reserve call
Bug fix/simplify things (#6516)
catch 501 (not implemented) in the query editor (ui) (#6523)
return error codes in case a babies remove operation fails (#6527)
Use physical collection directly (#6526)
Feature/aql item block compression (#6514)
move tests to the right location
take over selectivity estimates (#6505)
Properly check syncer erros, catch more exceptions (#6520)
prevent out-of-bounds array access
Fix deduplication in IndexBlock (#6508)
commit 4b38f0a7a003a2da813a363b91dc289419e0210c
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Wed Sep 19 10:04:46 2018 +0200
allow MSVC to user autopointer with c++17
commit 9c9102341245f2bc4373d11cd69c8e4c3d9fb129
Merge: 1b9e580f14 e51359b68e
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Sep 17 12:53:03 2018 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/cpp17
* 'devel' of https://github.com/arangodb/arangodb:
port startup fix
Bugfix/early out invalid links in view creation (#6502)
commit 1b9e580f14db737f005b7eed9926c222fa047754
Merge: b08bc2e9ba 8bd834bcf7
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Sep 17 06:38:24 2018 +0200
Merge remote-tracking branch 'origin/devel' into feature/cpp17
* origin/devel: (38 commits)
Maintenance delayed by incomplete hashing maintenance actions (#6448)
Do not hide indexes (#6507)
Fix WebUI Login with read-only (#6500)
Improve use of single shard restriction (#6182)
make cid values in /_api/replication/logger-follow strings as advertised (#6499)
less dynamic memory allocations on index operations (#6497)
Fix several TSan warnings (#6473)
Copy installation files on startup (#6491)
nightly frontend build
fix cluster selectivity estimates (#6488)
this moves aql::Query* out of the call parameter to any aql::Function (#6485)
Add advertised endpoints. (#6104)
nightly frontend build
fix leak in regex cache (#6480)
Removing ClusterComm ClientTransactionID (#6294)
pass variables by const reference
remove unused variable
remove unused variable
fix init-order fiasco with static strings (#6475)
minor issues (#6471)
...
commit b08bc2e9ba1553d608ae1bd5dc4a42290fa2cabd
Merge: 03fabcc509 2eb3c2dee4
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Tue Sep 11 12:46:51 2018 +0200
Merge branch 'devel' of https://github.com/arangodb/arangodb into feature/cpp17
* 'devel' of https://github.com/arangodb/arangodb:
temporarily increase log verbosity for replication log topic
Fix skipSome PR (#6455)
bump version number to 3.5 (#6454)
Feature/new devel versioning scheme (#6312)
Bug fix/aql modify cleanup (#6380)
Trace skipSome() calls (#6449)
nightly frontend build
Fix ArangoSearch authentication update task test (#6453)
Forward port changelog changes and typo fixes from #6303 (#6409)
fix some issues with sorted variant of COLLECT (#6433)
added tests, updated docu (#6407)
now that we are on c++14 and std::make_unique is available everywhere, we can safely remove our shim for std::make_unique (#6429)
Fixed memory leak due to cyclic references of shared pointer. (#6442)
do not create empty useless transaction data objects (#6430)
add some debugging for unstable replication_sync test (#6436)
Address leak sanitizer warnings (#6275)
Fix Pregel Graph Loading Logic (#6419)
remove unused variables
fix profile output for nodes without calls to getSome (#6397)
commit 03fabcc5098f4e097d31546835fbadd373e854c1
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Tue Sep 11 07:19:21 2018 +0200
switch more libs to c++17
commit 335942038f5d0d817554f59a5943e041d928ec40
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Sep 10 07:31:49 2018 +0200
fix static asserts in iresearch
commit 90eab952765c26d165e57dc8e01ee42bc1d2d8e6
Author: Jan Christoph Uhde <Jan@UhdeJC.com>
Date: Mon Sep 10 07:10:48 2018 +0200
move from c++14 to c++17
* specify required clang and gcc versions
* fix openssl 1.3 usage
* change random_shuffle to shuffle as the former has been removed from the c++ standard
https://meetingcpp.com/blog/items/stdrandom_shuffle-is-deprecated.html
* disable uncaught_exceptions in catch2 for darwin
In file included from /Users/jenkins/Git/cpp17/tests/main.cpp:2:
/Users/jenkins/Git/cpp17/3rdParty/catch/catch.hpp:10877:21: error: 'uncaught_exceptions' is unavailable: introduced in macOS 10.12
return std::uncaught_exceptions() > 0;
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/exception:130:63: note: 'uncaught_exceptions' has been explicitly marked unavailable here
_LIBCPP_FUNC_VIS _LIBCPP_AVAILABILITY_UNCAUGHT_EXCEPTIONS int uncaught_exceptions() _NOEXCEPT;
^
* boost locale now depends on boost thread
* add fix for VS2019
* try to fix build for windows
* add some change required by older macos
* add miserable hack to circumvent std::stack implementation problem on older Xcode
* try to fix windows build
* remove unary function as in v8 upstream
* clean up CMakeLists.txt
* Remove emplace hack that was introduced for OSX
* Revert "Remove emplace hack that was introduced for OSX"
This reverts commit 2b0a4cdd7881baa9ea8fbd34f2e89ef6fa9b9b63.
* Remove emplace hack that was introduced on OSX to support C++17 (#10184)
* Revert "Revert "Remove emplace hack that was introduced for OSX""
This reverts commit 7df9edde4097a951e95fcb204113d9c5289bf4bf.
* fixed MACOSX_DEPLOYMENT_TARGET
* Fix quotes usage in conditions
* Added MACOS_MIN
* Adjust variables
* Fix compilation
* remove iresearch patches
* Update CMakeLists.txt
Co-Authored-By: Jan <jsteemann@users.noreply.github.com>
* Applied review cAdded sceleton optimizer functionomments
* Added mask for rule
* Applied review cAdded sceleton optimizer functionomments
* Added mask for rule
* adding plan traversal for rule
* Rule execution block developing
* Experiment with additional block
* LIMIT node modifications
* implemented late materialization base version.
* Code cleanup
* Added check for variable usage
* Implemented serialization and cloning
* Fixed build errors
* Implemented late materialization for LimitNode
* Moved materialization to Sort Node
* Removed LimitNode modiications
* Implemented skipRows to speedup single server
* Added tests for optimizer rule
* fixed build
* Fix mac build
* Fixed mac build
* Fixed PR test run errors
* Added tmp fix for cluster test runs
* removed debug print
* Make materialization stick to last sort node. Add late materialization to explainer
* Updated optimization rule to search optimal SortNode to do materialization
* Refined optimization rules for cluster
* Added tests for SortExecutor and IResearchViewNode
* Fixed mac buid. Removed misplaced assertion.
* Fixed build
* Updated tests. Coded cleanup
* Code cleanup
* made function name for SortedExecutor match name in ConstraintSortedExecutor
* cleanup
* Fixed test run
* made scoring results stable across cluster
* Make optimize rule stop if sort node for limit node is not suitable
* Disabled constrained sort for materializing SortNode
* reverted SortNode modifications
* Implemented separate materializer node
* Fixed tests to account new materialize node
* Code cleanup
* reverted debugging change
* Fixed test jslint error and comments
* MaterializeNode renamed
* enum value renamed for materialize node
* Code cleanup
* code cleanup and optimization
* Fixed clang warning
* Applied review comments
* Out variable planning moved to materialize node
* inlined getters in ReadContex
* Added a way to execute DEATH tests in a core-free way, otherewise the Linux jenkins will produce core-files on those tests
* Update tests/Mocks/Death_Test.h
no new line at end of file
* Renamed the DeathTest macro as suggested.
* Yeah Windows Yeah, disabled death-test because i cannot get it to work.
* Replace template <bool blockPassthrough>
by template <BlockPassthrough blockPassthrough> where BlockPassthrough is an
enum class.
This is mainly for better readability and for some type safety.
* Fixup some implicit conversions to bool
* Add Start/End subquery node skeleton
* Added a test query that triggers complex interna in the future and needs to proof that our work is side-effect free.
* Added first draft of ShadowRow Interface
* Refactored RegisterPlan and pulled it out of the ExecutionNode
* AqlItemBlock now has an additional hidden register to store subquery depth infromation. Right now no shadow rows are created, however thy could now make use of this situation
* Added API and test to insert new shadow rows into an OutputRow.
* Extrated test helper function
* Add template function to statically assert size of type
* Add Start/End subquery node skeleton
* Add Start/End subquery node creation to ExecutionNode
* Cleanup SubqueryEndNode
* Add test file
* Add isEqualTo to ExecutionNode
* Subquery nodes cleanup
* Update ExecutionNode tests
* Added API and tests to consume ShadowRows. Interface is there and compiles with templates, we might need to implement further underlying functions later on as we make progress on ShadowRows, it is only implemented in the minimal way (intentionally)
* Updates to testing code
* Added a test for nested ShadowRows and adapted OutputRow accordingly.
* More updates
* Add optimizer rule
* Fix optimizer rule
* Added additional memory include, seems to be required under GCC not udner CLANG
* it actually helps to save fies before commiting them...
* Fix optimizer rule (again)
* Fixed serialization/Deserialization of AqlItemBlock to contain the hidden subquery register now
* Added a c++ test for AqlItemBlock. It just covers the basics thus far and needs to be improved.
* Fixed toVPack of AqlInputRow for subqueries. Also added serialization / deserialization tests for AqlItemRow
* Added a c++ test for inputAqlItem row serialization => AqlItemBlock deserialization
* Add a public function to get plan from query
* Fix register planning
* Add test for splicing subquery nodes
* add static asserts for sizes of SubqueryStartNode and SubqueryEndNode
* Add comment about statically asserted size
* Fix isEqualTo virtual and override dance.
* Attempt to fix :windows: compile warning
* Fix isEqualTo, remove static_assert_size
* Remove a TODO; the plan owns the ExecutionNodes
* Only add stealPlan to Query when testing
* Remove another static_assert_size
* Fixed mac compile issues
* Added a serialization format to be backwards compatible to 3.5 whenever AQL item blocks need to be send over to remote nodes.
* Handle ShadowAqlItemRow in SingleRowFetcher
* Move some code from header to cpp
* Added more tests for serialization of shadow rows, and fixed a bug revealed by this
* Apply suggestions from code review
Thank you for review!
Co-Authored-By: Tobias Gödderz <tobias@arangodb.com>
* Review comments. Thanks for spotting
* Fixed hidden merge conflicts
* Removed unused variable
* Added first test on ShadowRows in SingleRowFetcher. Found inconvenience in original code with it.
* Added a test for multi level shadow rows
* Added a test and fixed production for multiple consecutirve shadow rows.
* Added tests for pass through blocks and shadow rows
* Attempt to explain windows on how one can actually cast numbers into other number types...
* Add SubqueryEndExecutor
* Adapted RowFetcherHelper to be able to work on ShadowRows
* Fixed minor error in RowFetcherHelper that causes LIMIT tests to error
* Temporarily disabled test suites (sorry there is only one 'test case' in this suites that does all or nothing tests ...) as it tests a feature we cannot support in this intermediate state, we need to default disable our new rule first.
* IMplemented missing function to copy over SubqueryDepth between blocks
* Seperated assert, to see faster which part is violated
* Update arangod/Aql/AqlItemBlockSerializationFormat.h
Co-Authored-By: Tobias Gödderz <tobias@arangodb.com>
* Disabled subquery splice rule by default
* Forgotten merge marker
* temporarily modified test
* Some Subquery End Executor work
* Fix RowFetcherHelper to work with ShadowRows
* Add tests for SubqueryEndExecutor
* Rewrite SubqueryEndExecutor
* Update test
* Add createBlock code for SubqueryEndExecutionNode
* Some fixups adding ExecutionBlockImpl for SubqueryEndExecutor
* Fix SubqueryEndExecutor
* Update SubqueryEndExecutorTest
* Update endexecutor test
* Fix the endnode executor once more
* Fix some merge fallout
* Update test
* Add missing advanceRow to SubqueryEndExecutor
* SubqueryEndExecutor Tests
* Activate a death test
* Better handling of death test
* RowFetcherTest refactoring Part 1, still ongoing. We use this for AqlItemMatrix and SingleRowFetcher
* Update and cleanup the SubqueryEndExecutor tests
* Check that expected shadow row depths are met
* Remove commented out code in AqlItemBlock.cpp
* Remove a misplaced comment
* Sort out SubqueryEndExecutor includes
* Remove superflous include
* Consistently use NoStats{} in SubqueryEndExecutor
* Make SubqueryEndExecutor properties constexpr
* Reactivate IResearchTests
* Do not copy the accumulator in SubqueryEndNode
* Return a more sensible value for expectedNumberOfRows of SubqueryEndNodeExecutor
* Constify an argument
* Fix ownership problems with the buffer for _accumulator
* Cleanup SubqueryEndExecutor tests
Also add a test that writes to a register other than 0
* Patch RowFetcherHelper to count the number of Items returned instead of number
of calls
* Make MSVC happy
* Added TODO notes
* Pass limit of constrained sort to sorting gather
* Count output rows, and added assertions
* Extracted row-producing code in a reusable way
* Implemented SortingGatherExecutor::skipRows
* Fixed signature
* Fixed an assertion
* Added limit to (de)serialization
* Fixed an assertion
* Fixed an atMost calculation
* In the sort-limit optimization, apply limit to sorting gather as well
* Fixed optimizer rule reporting modification
* Added missing initialization
* Fix: Do not produce more rows than the limit when skipping first
* Fix: pass limit when cloning
* Updated CHANGELOG
* Fixed atMost intricacies
* Add Start/End subquery node skeleton
* Added a test query that triggers complex interna in the future and needs to proof that our work is side-effect free.
* Added first draft of ShadowRow Interface
* Refactored RegisterPlan and pulled it out of the ExecutionNode
* AqlItemBlock now has an additional hidden register to store subquery depth infromation. Right now no shadow rows are created, however thy could now make use of this situation
* Added API and test to insert new shadow rows into an OutputRow.
* Extrated test helper function
* Add template function to statically assert size of type
* Add Start/End subquery node skeleton
* Add Start/End subquery node creation to ExecutionNode
* Cleanup SubqueryEndNode
* Add test file
* Add isEqualTo to ExecutionNode
* Subquery nodes cleanup
* Update ExecutionNode tests
* Added API and tests to consume ShadowRows. Interface is there and compiles with templates, we might need to implement further underlying functions later on as we make progress on ShadowRows, it is only implemented in the minimal way (intentionally)
* Updates to testing code
* Added a test for nested ShadowRows and adapted OutputRow accordingly.
* More updates
* Add optimizer rule
* Fix optimizer rule
* Added additional memory include, seems to be required under GCC not udner CLANG
* it actually helps to save fies before commiting them...
* Fix optimizer rule (again)
* Fixed serialization/Deserialization of AqlItemBlock to contain the hidden subquery register now
* Added a c++ test for AqlItemBlock. It just covers the basics thus far and needs to be improved.
* Fixed toVPack of AqlInputRow for subqueries. Also added serialization / deserialization tests for AqlItemRow
* Added a c++ test for inputAqlItem row serialization => AqlItemBlock deserialization
* Add a public function to get plan from query
* Fix register planning
* Add test for splicing subquery nodes
* add static asserts for sizes of SubqueryStartNode and SubqueryEndNode
* Add comment about statically asserted size
* Fix isEqualTo virtual and override dance.
* Attempt to fix :windows: compile warning
* Fix isEqualTo, remove static_assert_size
* Remove a TODO; the plan owns the ExecutionNodes
* Only add stealPlan to Query when testing
* Remove another static_assert_size
* Fixed mac compile issues
* Initial commit, added class and test stubs
* Added Executor body stub, also added a test for no input. Passes now, as no input is read yet.
* Base implementation + Test of SubqueryStart Executor. First level shadowRows are now produced. Need to add tests for multilevel, and for non-fitting output blocks.
* Added more sophisticated test about shadow row relevance
* Added a test where ShadowRow does not fit into the open block. Also added disabled test on multi level shadowrows. Requires modifications on SingleRowFetcher.
* Added a serialization format to be backwards compatible to 3.5 whenever AQL item blocks need to be send over to remote nodes.
* Handle ShadowAqlItemRow in SingleRowFetcher
* Move some code from header to cpp
* Added more tests for serialization of shadow rows, and fixed a bug revealed by this
* Apply suggestions from code review
Thank you for review!
Co-Authored-By: Tobias Gödderz <tobias@arangodb.com>
* Review comments. Thanks for spotting
* Fixed hidden merge conflicts
* Removed unused variable
* Added first test on ShadowRows in SingleRowFetcher. Found inconvenience in original code with it.
* Added a test for multi level shadow rows
* Added a test and fixed production for multiple consecutirve shadow rows.
* Added tests for pass through blocks and shadow rows
* Attempt to explain windows on how one can actually cast numbers into other number types...
* Adapted RowFetcherHelper to be able to work on ShadowRows
* Seperated assert, to see faster which part is violated
* Fixed minor error in RowFetcherHelper that causes LIMIT tests to error
* Temporarily disabled test suites (sorry there is only one 'test case' in this suites that does all or nothing tests ...) as it tests a feature we cannot support in this intermediate state, we need to default disable our new rule first.
* Improve check of ExecutionState
* Implemented shadow row handling in subquery start executor. Tests not happy yet
* IMplemented missing function to copy over SubqueryDepth between blocks
* Fixed test code of StartExecutor test. It asserted wrongly on releveance of subquery rows.
* Added instanciation of SubqueryStartExecutorTest. Code does not compile.
* Allow to create SubqueryStartExecutors.
* Update arangod/Aql/AqlItemBlockSerializationFormat.h
Co-Authored-By: Tobias Gödderz <tobias@arangodb.com>
* Disabled subquery splice rule by default
* Forgotten merge marker
* temporarily modified test
* temporarily modified test
* Fixed windows compile
* Fixed unused variable warning
* Removed incorrect optimization in SubqueryStartExecutor
* Add Start/End subquery node skeleton
* Added a test query that triggers complex interna in the future and needs to proof that our work is side-effect free.
* Add template function to statically assert size of type
* Add Start/End subquery node skeleton
* Add Start/End subquery node creation to ExecutionNode
* Cleanup SubqueryEndNode
* Add test file
* Add isEqualTo to ExecutionNode
* Subquery nodes cleanup
* Update ExecutionNode tests
* Updates to testing code
* More updates
* Add optimizer rule
* Fix optimizer rule
* Fix optimizer rule (again)
* Add a public function to get plan from query
* Fix register planning
* Add test for splicing subquery nodes
* add static asserts for sizes of SubqueryStartNode and SubqueryEndNode
* Add comment about statically asserted size
* Fix isEqualTo virtual and override dance.
* Fix isEqualTo, remove static_assert_size
* Remove a TODO; the plan owns the ExecutionNodes
* Only add stealPlan to Query when testing
* Remove another static_assert_size
* Disabled subquery splice rule by default
* temporarily modified test
* Fixed windows compile
* Fixed unused variable warning
* Enable IPO (LTO) via CMake
* Use separate IPO_ENABLED variable
* Enabled IPO for more binaries
* Enabled IPO for arangobackup
* Suppress an MSVC warning (though it is not unjustified...)
* Fix static builds, broken due to Policy CMP0060 introduced in cmake 3.3
* Removed policies superseded by minimum cmake version
* Disable IPO with google tests due to a g++ bug
* Disable IPO with google tests only on AUTO
* Disable warning for correct line
* Begin de-inlining Aql
* de-inlining Aql: 2nd batch
* de-inlining Aql: 3rd batch
* de-inlining Aql: 4th batch
* Moved code out of ifdef
* Enabled IPO for additional libs
* Fixed some problems found with IPO enabled
- Fixed ODR violation in Pregel
- Removed unused code in ClusterMethods
- Avoid possible uninitialized variable usage
* Set IPO globally, except for 3rdParty libs
* De-inlined AstHelper again (was undone due to a previous merge conflict)
* Added missing .cpp file
* Fixed compilation with MSVC
* Removed superfluous includes from deinlined AQL header files
* Added includes for size_t
* Deleted outdated files
* De-inlined files that were undone during the merge
* Removed includes from files that were undone during merge
* Fixed merge conflicts
* Added first draft of ShadowRow Interface
* Refactored RegisterPlan and pulled it out of the ExecutionNode
* AqlItemBlock now has an additional hidden register to store subquery depth infromation. Right now no shadow rows are created, however thy could now make use of this situation
* Added API and test to insert new shadow rows into an OutputRow.
* Extrated test helper function
* Added API and tests to consume ShadowRows. Interface is there and compiles with templates, we might need to implement further underlying functions later on as we make progress on ShadowRows, it is only implemented in the minimal way (intentionally)
* Added a test for nested ShadowRows and adapted OutputRow accordingly.
* Added additional memory include, seems to be required under GCC not udner CLANG
* it actually helps to save fies before commiting them...
* Fixed serialization/Deserialization of AqlItemBlock to contain the hidden subquery register now
* Added a c++ test for AqlItemBlock. It just covers the basics thus far and needs to be improved.
* Fixed toVPack of AqlInputRow for subqueries. Also added serialization / deserialization tests for AqlItemRow
* Added a c++ test for inputAqlItem row serialization => AqlItemBlock deserialization
* Attempt to fix :windows: compile warning
* Added a serialization format to be backwards compatible to 3.5 whenever AQL item blocks need to be send over to remote nodes.
* Added more tests for serialization of shadow rows, and fixed a bug revealed by this
* Apply suggestions from code review
Thank you for review!
Co-Authored-By: Tobias Gödderz <tobias@arangodb.com>
* Review comments. Thanks for spotting
* Fixed hidden merge conflicts
* Attempt to explain windows on how one can actually cast numbers into other number types...
* Update arangod/Aql/AqlItemBlockSerializationFormat.h
Co-Authored-By: Tobias Gödderz <tobias@arangodb.com>
* Avoid overfetch in sorting gather executor
* Updated CHANGELOG
* Temporarily disabled sort-limit in cluster when fullCount is enabled, until we can fix SortingGather
* Added a cluster test for sort-limit
* Fixed non-maintainer compile
* Fixed jslint errors
* Disabled sort profiler tests until SortingGather is fixed
Jan
Wilfried Goesgens
Iurii Popov
Markus Pfeiffer
jsteemann
Simon Grätzer
Tobias Gödderz
Andrey Abramov
Michael Hackstein
Jan Christoph Uhde
Dronplane
KVS85
Dan Larkin-York
Kaveh Vahedipour