* Squashed commit of feature-3.5/hotbackup_devel.
This puts hotbackup into 3.5.
* Port atomic-database-creation-2 to 3.5.
* Remove some wrongly ported code.
* Fix compilation.
* Fix a manual merge error.
* Remove a feature from the mocks which does not exist in 3.5.
* Add some code which was forgotten in manual merge.
* Fix a problem introduced in a manual merge.
* reuse function
* Address some whitespace issues that came up in review
* aardvark should not create the frontend collection
* create _frontend collection from c++
* recheckAndUpdate Callback in CollectionWatcher
* Wrong author ;)
* rm outdated todo
* Update lib/Basics/VelocyPackHelper.h
Co-Authored-By: Michael Hackstein <michael@arangodb.com>
* use logger unique id, use startup logger
* not needed
* optimized vector shardid method
* do not create _modules collection lazy anymre
* Formatting.
* Assert instead of if/TRI_ASSERT(false)
* Don't use exceptions as control structure
* Re-add READ_LOCKER that got lost in translation
* Fix audit log in case database creation fails early.
* legacy sharding
* Add CHANGELOG entry.
* Retry database cancellation indefinitely
* Do not use exceptions in UpgradeTask
* DropCollection is a FAST_LANE action and should not need much time or else retry.
* Remove superflous addition of LdapFeature
Proudly brought to you by ASAN tests
* Fixed check for distributShardsLike sharding on _system database
* Fixed compile issue on tests
* Removed assertion that seems to be not correct yet on devel.
* Sort out google cloud storage as remote. (#9918)
* Add successful method to ClusterCommResult.
* Improve error forwarding for cluster internal communication.
* Feature/hotbackup list retries (#9924)
* retry hot backup listing for 2 minutes in cluster before giving up
* Enable api by default.
* fix broken list of non existing id (#9957)
* Fix compilation after manual merge.
* Fix another compilation problem.
* Yet more fixes for compilation.
* More compilation fixes.
* Bug fix 3.5/make arangosh reconnect (#9615)
* make arangosh reconnect
* added CHANGELOG entry
* fix lagging AgencyCallbacks (#9620)
* fix lagging AgencyCallbacks
* optimizations, discussed with @mchacki
* fix wording
* updated CHANGELOG
* fix yet another undefined behavior (#9629)
* [3.5.1] Fail the FailedLeader Job if the new leader fails. (#9628)
* Fail the FailedLeader Job if the new leader fails.
* Updated changelog.
* In case of timeout do not rollback.
* Fixed catch tests.
* Changed wording.
* DELETED rollback.
* reduce wait timeouts as a mitigation for notifying waiters without ho… (#9619)
* reduce wait timeouts as a mitigation for notifying waiters without holding the required mutex
this is a quick mitigation only, which reduces maximum wait time from 1
second to 100 milliseconds without changing other behavior.
the main problem of notifying pending writers without successfully
acquiring the required mutex still needs proper addressing.
* adjust timing-dependent test
* [3.5.1] Fast Controlled Leaderchange (#9634)
* First draft of keeping in sync during controlled leader change.
* Test if server is actually the leader in plan.
* Updated changelog.
* Added oldLeader check for set-the-leader request.
* Small fixes.
* Removed LOG_DEVEL.
* less copying, more moving! 🚚 (#9645)
* attempt to fix load_balancing tests in slow test environments (#9626)
* Bug fix/fix swagger datatype (#9045) (#9602)
* Bug fix/fix swagger datatype (#9045)
* remove http so https arangos will work
* verify that query parameters are proper swagger data types, fix offending documentation files
* return the actual type - not the list of available ones
* check formats
* there is no uint64 in swagger
* Fresh Swagger
* Port TakeoverShardLeadership from devel to 3.5.1 (#9659)
* Create TakeoverShardLeader job.
* Add TakeoverShardLeadership to Action factory.
* Add log message at level debug.
* Sort out LOG_TOPIC ids.
* Fix unit tests.
* CHANGELOG.
* Bug fix 3.5/hide mmfiles specific info in web ui (#9668)
* attempt to fix load_balancing tests in slow test environments (#9626)
* Bug fix/fix swagger datatype (#9045) (#9602)
* Bug fix/fix swagger datatype (#9045)
* remove http so https arangos will work
* verify that query parameters are proper swagger data types, fix offending documentation files
* return the actual type - not the list of available ones
* check formats
* there is no uint64 in swagger
* Fresh Swagger
* hide MMFiles-specific information when we don't need it
* Ported ResignLeadership to 3.5 (#9656)
* attempt to fix load_balancing tests in slow test environments (#9626)
* Bug fix/fix swagger datatype (#9045) (#9602)
* Bug fix/fix swagger datatype (#9045)
* remove http so https arangos will work
* verify that query parameters are proper swagger data types, fix offending documentation files
* return the actual type - not the list of available ones
* check formats
* there is no uint64 in swagger
* Fresh Swagger
* Ported ResignLeadership to 3.5
* Add the actual http route.
* Aardvark: Add k Shortest Paths example graph to UI (#9491) (#9661)
* Aardvark: Add k Shortest Paths example graph to UI (#9491)
* Add example graph to UI
* Add kShortestPathsGraph to examples.js
* Update example-graph.js
* Update aardvark.js
* Regenerate UI
* add the ability to have cluster special examples (#9613) (#9663)
* add the ability to have cluster special examples
* Update get_cluster_health.md
* fix abort condition, fix negative filtering for cluster tests
* Test if job fails with unmet assertion
* Remove cluster test example
* germanize
* better skip reasons
* removing superfluous semicolons
* Revert skip reasons, too noisy
* various replication improvements: (#9675)
* attempt to fix load_balancing tests in slow test environments (#9626)
* Bug fix/fix swagger datatype (#9045) (#9602)
* Bug fix/fix swagger datatype (#9045)
* remove http so https arangos will work
* verify that query parameters are proper swagger data types, fix offending documentation files
* return the actual type - not the list of available ones
* check formats
* there is no uint64 in swagger
* Fresh Swagger
* various replication improvements:
- better debuggability (more log details)
- shorter minimum wait delay in active failover
- fixed too early pruning of WAL files on leaders
* Bug fix 3.5/fix rocksdb return code (#9692)
* attempt to fix load_balancing tests in slow test environments (#9626)
* Bug fix/fix swagger datatype (#9045) (#9602)
* Bug fix/fix swagger datatype (#9045)
* remove http so https arangos will work
* verify that query parameters are proper swagger data types, fix offending documentation files
* return the actual type - not the list of available ones
* check formats
* there is no uint64 in swagger
* Fresh Swagger
* fix return codes for concurrent writes to same documents
* [3.5] Feature/rebootid notice changes, backport of #9523 (#9684)
* Feature/rebootid notice changes, backport of #9523
* Fixed error code to not re-use an old one
* Bug fix 3.5/issue 9679 (#9682)
* attempt to fix load_balancing tests in slow test environments (#9626)
* Bug fix/fix swagger datatype (#9045) (#9602)
* Bug fix/fix swagger datatype (#9045)
* remove http so https arangos will work
* verify that query parameters are proper swagger data types, fix offending documentation files
* return the actual type - not the list of available ones
* check formats
* there is no uint64 in swagger
* Fresh Swagger
* fixed issue #9679
* bug-fix/issue-#9660 (#9704) (#9707)
* bug-fix/issue-#9660 (#9704)
* fix issue
* Update tests/js/common/aql/aql-view-arangosearch-cluster.inc
Co-Authored-By: Jan <jsteemann@users.noreply.github.com>
* Update tests/js/common/aql/aql-view-arangosearch-noncluster.js
Co-Authored-By: Jan <jsteemann@users.noreply.github.com>
* fix cluster tests
* Update CHANGELOG
* [3.5] agency node fixes (#9698)
* node fixes port from 3.4
* fixed change log
* update rocksdb statistics to deliver sums from column family instead of single value from default family. (#9706)
* Feature 3.5/geo functions (#9710)
* Add support for WGS84 on distances (#9672)
* Add area calculations (#9693)
* Update CHANGELOG
* start maintenance arangosearch threads after recovery is done
* ensure flush subscription is not being deallocated while in use
* add some tests
* properly determine storage engine
* adjust default view options
* stick to old index meta format in 3.5
* address test failures
* and cluster tests
* optimize away SortNode in case it is covered by an arangosearch view
this implementation is a stub with hard-coded attribute names
* extend IResearchViewMeta with sorting order definition
* make 'IResearchViewMeta::Sort' compatible with 'SortCondition' API
* ensure ArangSearch sort is immutable after creation
* address review comments
* issue 526.3: update analyzer feature to store analyzer definitions in per-vocbase system collections
* address merge issues
* address another merge issue
* Fixed hidden merge conflict
* Added BlockFetcher, added a minimal test for SingleRowFetcher
* move RegInfo in types.h
* fix getSomeLogic
* Added the AqlItemMatrix implementation. Not yet tested!
* Fixed nr called => Waiting ratio in AllBlocksFetcherMock
* fix compiling
* add RegInfo to produceRow
* BlockFetcherHelper now returns a matrix
* pass RegInfo as requested into AqlItemRow ctor
I would still keep it out as the ItemRow should be a thin view.
* allow to change the AqlItemRows cheaper / remove _sourceRow member
* implement copyRow for AqlItemRow
* organize cleanup for outputblock used in getsome / shrink if necessary
* Added tests for SingleRowFetcher, cleanup in AqlItemRow
* start mocking
* Added test helpers, began work on a more complex test for SingleRowFetcher
* Re-added RegInfo again to AqlItemRow
* helper, added test case for FilterExecutor
* merge fixed compile
* Removed trx name where it is actually not used
* Made some functions TEST_VIRTUAL for mocking.
* implemented Sort executor
* Fixed the BlockFetcherHelper API, to always return a matrix if it is not waiting
* Implemented a SortExecutor test with data
* disable borken test
* Fixed test on SortExecutor. Green now, needs some more testing
* change a bit how the AqlItemRow is used in a test
* Added another test for the SingleRowFetcher
* Added more tests for SingleRowFetcher
* fix getRegisterInfo
* Moved RegInfo into ExecutorInfos. Also now use the FilterExecutor implementation in production code instead of FilterBlock. Starting integration testing.
* add more asserts
* Fixed undefined behaviour in TestCode.
* Do not shrink an empty output block
* switch to block pointers in AqlItemRow
* return blocks in the row fetcher
* Updated grammar.cpp
* Updated (fixed) tests to verify returnBlock
* Improved const-ness
* Changed BlockFetcher constructor in order to make it mockable
* Implemented BlockFetcherMock and rewrote some tests with it
* Updated a comment
* Updated comments
* init commit - EnumerateListExecutor, including EnumerateListExecutorInfos
* add potential fix for ItemMatrix
* Replaced fakeit with BlockFetcherMock in another GIVEN block
* Replaced the last fakeit mocks with BlockFetcherMock and removed fakeit
* Updated function definition
* included missing arary included
* Renamed AqlItemRow to InputAqlItemRow
* Split AqlItemRow into Input~ and Output~ classes
* EnumerateListExecutor + Tests
* Added tests for AqlItemRows
* Added test file for AqlItemRows...
* Made the ostream operator for AqlItemBlocks available to Logger and Catch info
* build error
* Added a second test for AqlItemRows. Need to make input space invalid now, sth. acidential referencing will show up
* Introduce a block ID in the InputAqlItemRow
* Copy output values correctly, avoid InputAqlItemRow pointers
* Added a test for registerClearout
* Fixed tests
* Added a test for adding new values
* Added a test for an incomplete row write to not count as produced.
* Fixed getSome and a test
* Added a test for larger AQL values in AqlItemRows
* Fixed compile error in hidden merge conflict
* Added tests for Filter counter in FilterExecutor
* OutputAqlItemRow now takes responsibility of the block
* Handed responsibility of blocks in ExecutionBlockImpl to OutputAqlItemRow
* EnumerateListExecutor should be close to its finish. Tests need to be fixed, not ready yet.
* better swap
* OutputAqlItemRow now takes ExecutorInfos
- added several assert
- implemented a more strict and safe produced() logic
* enum list test
* Added a more specific error message
* Removed OutputAqlItemRow.changeRow()
* fix invalid block freeing
* changed order of input/output registers
* Fixed a test
* Fixed matrix width in test
* fix failure tests
* finished enumlist tests
* Implemented AllRowsFetcher and tests for it
* Bugfix in skipSome stub
* insert sort and enumerate list executors
into exectuion nodes' create functions
* fixed singlerowfetcherhelper, added tests
* small fixes
* add missing Infos
* restore accidentally deleted scorer
* make it compile
* fix executor info creation / usage
* make use of output var in EnumarateListNode
* Added Executor::Stats and FilterStats
* Extended FilterExecutor tests with stats, added node tracing to getSome
* Fixed Sort-&EnumerateList- Executor to use the new return type with stats
* Fixed compile error in tests
* Changed *ExecutorInfo constructors and classes to contain the necessary register informations
* Made an ExecutorInfo construction more readable
* Updated comments
* Fixed checks in OutputAqlItemRow::setValue()
* Add comparison method to SortRegister. Forbid construction without one.
* Implemented ExecutionBlockImpl::initializeCursor
* more mocking inside ExecutionBlockImplTest
* Minor changes
* Avoid AqlValueGuard destroying the value copied into the output block
* Disabled failure tests that do not apply to the new Sort implementation
* further mocking of test modules
* Removed constexpr for compatibility with outdated gcc versions
* add some failure tests - getsome works differently
therefor we do not test the old behavior
* fix sort node
* clean up alq item matrix
* Removed the transaction methods from read-only access to AqlValues (get and at) and repliced by CollectionNameResolver where necessary. Still left: some calls extract VPackOptions from the Transaction. Compare needs a BuilderLeaser only.
* textexecutionhelper, execimpl test
* Eliminated FilterBlock
* Eliminated the EnumerateListBlock
* first successful running test of executorblockimpl
* Eliminated SortBlock
* fixed testexecutor helper
* Made the ExecutorInfos private to the executors again.
* Implement and use AqlItemBlockShell (#6562)
* Added AqlItemBlockShell
* Minor changes
* Mostly replaced AqlItemBlock with ~Shell.
Current state:
- arangod compiles
- OutputAqlItemRow has yet to be changed
- catch tests have yet to be fixed
* Use AqlItemBlockShell in OutputAqlItemRow
* Added registersToKeep to AqlItemBlockShell
* Removed ExecutorInfos from OutputAqlItemRow
* Split AqlItemBlockShell into Input~ and Output~
* Changed tests so they compile again - they're still not yet working.
* Fixed tests
* fixed building, modified impl test
* Removed now superfluous BlockFetcherMock functions
* more execimpl testing
* Removed block IDs
* more impl testing
* Reduced dependencies of BlockFetcher construction
* Bugfix, cleared documentation
* Removed debug-output
* Adressed minor code review remarks
* Moved method definitions into .cpp files to avoid includes
* Added assertions
* Added comments
* Addressed several more review comments
* Added missing includes
* more testing, not finalized yet
* added missing header file
* added a test for execution block impl
* removed old comment
* Improved lookup algorithm to identify correct block/row combination in AqlItemMatrix
* added test for ExecutionBlockImpl
* move utility to the right position
* Bugfix and a TODO note
* Bugfix: use a uniform ResourceMonitor in tests
* Made OutputAqlItemRow::setValue clone by default and copy on move
* Replaced the getRow lookup with a binary search
* enumerate tests
* Disable emplacing of AqlValues in ItemBlock
* Reenabled std::enable_if will warn until oskar is using c++17 as standard.
* Add helper function to create a shared pointer of an unordered_map<RegisterId>
* CalculationExecutor (#6570)
* add CalculationExecutor skeleton
* first shot of CalculationExecutor
* fix minor bugs
* handle references
* use new shared pointers
* commit to share work
* fix failure test
* reformat with clang-format
* add test for CalculationExecutor
* fix CalcualtionExecutor test
* clean up
* Removes unused code
* clean up includes
* fix/remove comments
* add changes requrested by hacki
* ReturnExecutor (#7932)
* add skeleton to CMakeLists.txt
* build most parts of the ReturnExecutor
* This commit removes ReturnBlock and adds some debug messages
removed inheritRegisters functionality
* finish ReturnExecutor
* add test for return executor
* remove unused code
* add stats and clean up includes
* verify result in ReturnExecutorTest and move *Stats to "Aql/Stats.h"
* Fixed algorithm to find correct row in a MultiRow Input
* fix full count and failure tests (#7969)
* fix full count and failure tests
* fix filter test
* WIP: fixes
* fixed
* NoResultsExecutor (#7953)
* add NoResultsExecutor
* clean up
* some review changes
* fix test
* fix
* fix WAIT -> DONE
* remove unused code (#7995)
* create skeleton for SingletonExecutor (#7957)
* create skeleton for SingletonExecutor
* WIP: continue implementation
* WIP: add fetcher skel
* WIP: add inject function to ConstFetcher
* rename SingletonExecutor to IdExecutor
* WIP: replace singleton node
* WIP: More Debugging on IdExecutor
* WIP: IdExecutor
* WIP: add failure tests
* make iresarch test work but not pass
* WIP: add ConstFetcherHelper
* fix test
* fix tests
* fix iresearch tests
* fix wording
* add review changes
* add review change to SingleRowFetcher as well
* fix test
* fix error when increasing index
* temporarily remove fold-expression
* clean up
* Fix gcc compile error
* Feature/aql limit executor (#7982)
* limit executor
* removed not needed tri assert
* rm _invariable in limitnode
* find out if we are in a subquery
* queryDepth in limit infos
* added missing queryDepth
* finalizing limit executor
* added more tests, fixed a condition
* add assert to test
* added missing fullcount check
* typo
* minor changes, fixed test
* test
* wrong check
* fixed tests
* false merge
* remove basic blocks
* remove basic block includes
* include sort order
* removed not needed basic blocks
* removed not needed basic blocks
* fix test
* Feature/remove input output shells (#8090)
* Added template parameters to allow for block pass-through to be chosen at compile time
* Adapted the tests to match the new template parameters
* Adapted ConstFetcher and IdExecutor to match the new templated fetcher
* Implemented pass-through, fixed SingleRowFetcherTest
* Fixed implicit merge conflicts
* Fix assumptions that are violated by block pass-through
* Added 2 regression tests
* Fixed test expected data
* Fix nullptr dereference
* Fix handling of non-invalidated input variables
* Fix nullptr dereference
* Fix handling of non-invalidated input variables
* Fixed compile error
* Fixed a useless and leaking allocation
* Try a less implicit fix
* Allow IdExecutor and ConstFetcher to be used with pass-through
* Performance patches from @mchacki
* Fixed merge conflicts, and bugs in ConstFetcher
* Fixed atMost pass-through, and blocks that call their parents too often
* Removed InputAqlItemBlockShell (except from tests)
* Removed OutputAqlItemBlockShell (except for tests)
* Moved implementations of OutputAqlItemRow methods in the header
* Moved SingleRowFetcher::fetchRow to the header to allow inlining
* Reenabled returnInheritedResults optimization
* Enable passThrough for ReturnExecutor with inherited results
* Specialized CalculationExecutor to avoid unneccessary conditional jumps
* Made tests compile again (but are currently broken)
* Fixed ReturnExecutor test
* Move created InputRows out of AqlItemMatrix
* Limit- and EnumerateList Executors no longer fetch from upstream after DONE
* Added comments
* Added experimental AqlItemBlock optimizations
* Removed _numEntries, added comments
* Allow executors to pass an "atMost"-limit to the SingleRowFetcher (for LIMIT)
* Let the LimitExecutor pass atMost upstream
* Bugfix for FullCount
* Feature/aql enumeratecollection executor (#8028)
* initial commit
* enum coll executor
* buildable version of enumeratecollectionexecutor
* wrong usage of outVariable
* Added template parameters to allow for block pass-through to be chosen at compile time
* Adapted the tests to match the new template parameters
* Adapted ConstFetcher and IdExecutor to match the new templated fetcher
* more fixes, still some tests failing
* Implemented pass-through, fixed SingleRowFetcherTest
* Fixed implicit merge conflicts
* adding missing set value (remember optimize todo), optimized constructor
* removed old enumerate collection blocks
* Fix assumptions that are violated by block pass-through
* Added 2 regression tests
* Fixed test expected data
* Fix nullptr dereference
* Fix handling of non-invalidated input variables
* Fix nullptr dereference
* Fix handling of non-invalidated input variables
* Fixed compile error
* Fixed a useless and leaking allocation
* added broken uncompilable executor test
* Try a less implicit fix
* fix mocking
* enumerate collection executor test
* remove class, use only static function.
* clean up test after merging with main branch
* Allow IdExecutor and ConstFetcher to be used with pass-through
* Performance patches from @mchacki
* Fixed merge conflicts, and bugs in ConstFetcher
* Fixed atMost pass-through, and blocks that call their parents too often
* Removed InputAqlItemBlockShell (except from tests)
* Removed OutputAqlItemBlockShell (except for tests)
* Moved implementations of OutputAqlItemRow methods in the header
* Moved SingleRowFetcher::fetchRow to the header to allow inlining
* Reenabled returnInheritedResults optimization
* Enable passThrough for ReturnExecutor with inherited results
* Specialized CalculationExecutor to avoid unneccessary conditional jumps
* Made tests compile again (but are currently broken)
* Fixed ReturnExecutor test
* Limit- and EnumerateList Executors no longer fetch from upstream after DONE
* Removed an assertion which seems to be incorrect during bootstrap.
* Inlined AQL ItemMatrix and removed unused elements in other Executors
* Now inline + Move in AqlItemMatrix, seems to be overall best performing
* Bugfix: Do not returnInheritedResults on DBServers
* Fixed LIMIT test, and made it more thorough.
* Fixed createion of NoResultBlock creation in IResearch Nodes. Also relaxed an assertion
* Reactivated failure point, now identical with anotherone in OutputRow, need to unified
* Bug fix: do not mutate the offset in the LimitExecutor (#8109)
* Introduced test
* Fixed LimitExecutor to not mutate its infos, so it works correctly in subqueries
* Fixed crashes in CatchTests
* Fixed non-maintainer build
* try to fix subqueries
* Fix isInSubQuery for non-singleton nodes.
* remove useless while true
* Feature/aql blocks by line dan sort (#8143)
* Add SortNode::SorterType to SortExecutorInfoss.
* prepare imple of sort executor
* WIP: add some code for dan sort
* WIP: working at pushRows
* WIP - try to add Dan's heap-sort
* re add missing test
* 2 fixes
* fix
* Dan's tests are working
* remove unused variable
* remove SortBlock.cpp from CMakeLists.txt
* remove hack and provide an extra method to set the _baseIndex
* Simplified ContrainedSortExecutor.
* fix forgotten variable
* update doc
* Assert that we do not use functions that might return wrong results.
Preconditions or invariants the functions rely on are broken. Therefore
the functions can not be used. This is asserted in maintainer mode.
* add function to restore row invariant
* do not emplace and pop_back if not necessary
* Use clear registers in case we can move the rows.
* WIndows opst zirkus
* Actually destroy AqlItemValue
* Feature/traversal executor by line (#8000)
* Added stubs for TraversalExecutor, no implementation, not compiled in yet
* Included production code of TraversalExecutor and made it compile. Now implement
* Implemented production code for trivial tests, if no row is reaching the traverser.
* Fixed TraversalExecutor code to pull all rows from above and added tests. No traversal yet, this is next
* Intermediate blind commit might not work
* Fixed compile issue in test code
* Created a shared place for Mocks in tests and moved the StorageEngineMock there, also started a shared place for mock servers, most test will need the same server in order to work.
* Fixed travesalExecutor tests. Now able to create tests with actual input.
* Added successful test in TraversalExecutor, that Traverser as started with correct start vertices (by inputRegister)
* Further test cases
* Added stubs for TraversalExecutor, no implementation, not compiled in yet
* Included production code of TraversalExecutor and made it compile. Now implement
* Implemented production code for trivial tests, if no row is reaching the traverser.
* Fixed TraversalExecutor code to pull all rows from above and added tests. No traversal yet, this is next
* Intermediate blind commit might not work
* Fixed compile issue in test code
* Created a shared place for Mocks in tests and moved the StorageEngineMock there, also started a shared place for mock servers, most test will need the same server in order to work.
* Fixed travesalExecutor tests. Now able to create tests with actual input.
* Added successful test in TraversalExecutor, that Traverser as started with correct start vertices (by inputRegister)
* Fixed leftovers from rebase
* Refixed mocks in different folder
* Fixed Mock import
* Fixed Calculators Exector Test to use the unified mocked server.
* Implemented logic for the TraversalExecutor. Also added tests for it. Not fully complete though
* Added validation of result values
* Added usage of constant register in traversal executor
* Included filter variables in traersal executor. Added test for const input. And moved MMDR into base traverser class for simplicity
* Added ostream operators on AQLValue and AqlInputRow. Not 100% done yet but good enough
* Added a shutdownable ExecutionBlock. Some blocks need to implement a specific shutdown still. I added this class to make it easier to eliminate them when the time is due.
* Removed ostream operator for INPUT row again, does for some reason not compile on Linux0o
* Fixed initialization order
* Removed classwrapper for shutdown.
* Applied review changes
* Refixed failing tests, API is not subject to change
* Fixed CatchTest (wrong usage of string literal in test case)
* Feature/shortest path executor (#8042)
* Added stubs for TraversalExecutor, no implementation, not compiled in yet
* Included production code of TraversalExecutor and made it compile. Now implement
* Implemented production code for trivial tests, if no row is reaching the traverser.
* Fixed TraversalExecutor code to pull all rows from above and added tests. No traversal yet, this is next
* Intermediate blind commit might not work
* Fixed compile issue in test code
* Created a shared place for Mocks in tests and moved the StorageEngineMock there, also started a shared place for mock servers, most test will need the same server in order to work.
* Fixed travesalExecutor tests. Now able to create tests with actual input.
* Added successful test in TraversalExecutor, that Traverser as started with correct start vertices (by inputRegister)
* Further test cases
* Added stubs for TraversalExecutor, no implementation, not compiled in yet
* Included production code of TraversalExecutor and made it compile. Now implement
* Implemented production code for trivial tests, if no row is reaching the traverser.
* Fixed TraversalExecutor code to pull all rows from above and added tests. No traversal yet, this is next
* Intermediate blind commit might not work
* Fixed compile issue in test code
* Created a shared place for Mocks in tests and moved the StorageEngineMock there, also started a shared place for mock servers, most test will need the same server in order to work.
* Fixed travesalExecutor tests. Now able to create tests with actual input.
* Added successful test in TraversalExecutor, that Traverser as started with correct start vertices (by inputRegister)
* Fixed leftovers from rebase
* Refixed mocks in different folder
* Fixed Mock import
* Fixed Calculators Exector Test to use the unified mocked server.
* Implemented logic for the TraversalExecutor. Also added tests for it. Not fully complete though
* Added validation of result values
* Added usage of constant register in traversal executor
* Included filter variables in traersal executor. Added test for const input. And moved MMDR into base traverser class for simplicity
* Added ostream operators on AQLValue and AqlInputRow. Not 100% done yet but good enough
* Added a shutdownable ExecutionBlock. Some blocks need to implement a specific shutdown still. I added this class to make it easier to eliminate them when the time is due.
* Removed ostream operator for INPUT row again, does for some reason not compile on Linux0o
* Fixed initialization order
* First draft of shortest path executor
* Fixed logic bugs, Local AQL tests succeed
* Added first version of ShortestPathExecutor tests. Edge output tests are missing yet.
* Added EDGE output tests
* Replaced TraversalStats with NoStats, they have never been tracked...
* Removed obsolete ShortestPathBlock.
* Removed classwrapper for shutdown.
* Applied review changes
* Refixed failing tests, API is not subject to change
* windows macro opst circus
* Clear registers per block, not per row (#8164)
* Fixed compilation under linux again...
* issue 466.4: implement persistence of IResearchLink WAL flush marker
* address enterprise test failure
* address test failures
* treat missing collections/indexes as potentially removed
* change view asertios to match collection assertions
* convert assertions to exceptions since they are possible
* revert assertion removal since assertions are actually valid for coordinator
* address scenario where link is dropped twice
* check for data store state before returning error
* revert last change since it's not valid for MMFiles
* add ability to restrict collections scope of ArangoSearch view in query
* fail if collection which is not registered with a view was specified in options
* allow bound parameters to be used with ArangoSearch view options, add unit tests
* fix tests
* add tests for cluster
* fix issue in deseralization logic
* fix cluster tests, extend integration tests
* more tests
* fix failing cluster test
* address review comments
* address test issues
* issue 511.5: remove cid from IResearchPrimaryKey since iresearch data-stores are per-collction, minr code cleanup
* get rid of CID field in a document
* make ArangoSearch PK encoding/decoding logic explicit
* issue 506.3: use camel-case configuration parameter names consistntly, add a configuration version property to iresearch view meta
* backport: ensure meta version is supported
* backport: hide 'version' property from non-persistence json
* Forward-port of bug-fix-3.4/mmfiles-replication-get-followers-under-lock
Fix resign order
Fixed a typo
Get followers later, add TODOs
Added a callback parameter to collection insert methods
Get followers under the lock if necessary
Extracted the replication of inserts into a separate method
Move shortcut into replicate method
Added callbacks for remove, replace and update
Added missing overrides
Extracted replication code from modifyLocal and removeLocal
Update followers under lock also during replace, update, remove
Fix changes from the last commit for update/replace
Update comments, add asserts
Remove changes for document-level locks that will be done in another PR
Unify replication
Adapt log messages to the devel ones
Move common methods from its descendants to TransactionCollection, fix Mock on the way
More IResearch test / mock fixes
Relax asserts for nested transactions
Reformat
Fix non-babies remove and modify replication
* Remove some changes introduced by the merge
* Fixed compile errors introduced by merge
* issue 496.3: move more coordinator-related logic out of TRI_vocbase_t, rename some arangosearch view configuration parameters, remove some consolidation policies, update iresearch to revision 6fd9760d81b136f769e277ea5b8f53996ed7a1ca
* address potential deadlock between link creation and FlushThread
* remove code causing nullptr access
* add back lock around reader reopen
* revert: address potential deadlock between link creation and FlushThread
* invalidate payload for each field in FieldIterator before setting a value
* issue 496.1: switch scope of responsibility between a TRI_vocbase_t and a LogicalView in respect to view creation/deletion
* backport: address test failures
* backport: ensure arangosearch links get exported in the dump
* backport: ensure view is created during restore on the coordinator
* Updates for ArangoSearch DDL tests, IResearchView unregistration and known issues
* Add fix for internal issue 483
* issue 485: ensure LogicalDataSource::drop() is called on vocbase drop
* add missed change
* backport: address race between make(...) and async job
* add another missed change
* backport: ensure recursive lock reports itself as locked correctly
* backport: address test failure on mmfiles
* backport: remove redundant lock already held by async task
* backport: reset reader before unlinking directory
* get rid of memory stores
* do not use 'waitForSync' transaction option to synchronize a view
* honor `Methods::isSingleOperationTransaction()` hint
* explicitly specify index_writer's properties
* ensure data is synced
* fix tests
* another fix
* code cleanup
* remove code duplication
* some fixes
* fix typo
* issue 459.3: ensure collection permissions are checked before updating/dropping an IResearch view
* backport: ensure collection permissions are checked before updating/dropping an IResearch view on cluster
* backport: address test failures
* backport: address more test failures
* reuse existing classes for scoping ExecContext
* issue 450.3: use a single configuration policy differentiated by 'type' with arbitrary number of configurable parameters
* ensure test data is persisted to the test directory
* add missed declaration
* fix typo
* add full namespace and includes
* issue 410.3: remove the extra neting of ArangoSearch view definition into 'properties'
* address merge issue
* backport: address test failures
* backport: address dump test failure
* issue 410.1: ensure both JavaScript and Rest API for views matches API for collections
* backport: address some FIXMEs
* backport: address test failures
* backport: address more test failures
* backport: fix some Ruby tests
* temporarily comment out broken Ruby tests
* backport: fix more broken Ruby tests
* temporarily comment out failing Ruby tests
* backport: match result structure for View instances with Collection instances
* backport: return different result structure for view listing and view definition
* backport: fix even more broken Ruby tests
* backport: do not depend on unordered_set stable order
* update documentation
* Added feature phases
* BasicsPhase and DatabasePhase to the required files. Server now has Feature circles and does not boot. Will be sorted out later on.
* Added ClusterPhase to features
* Added V8Phase to the required features
* Added AQLPhase to the affected features
* Added ServerPhase to Features
* Added FoxxPhase to the relevant features
* Added AgencyPhase to the relevant features
* Moved registration from local variable SYS_SYSTEM_REPLICATION_FACTOR from cluster to V8 as their ordering is now vice versa
* Moved Bootstrap feature into FoxxPhase. It could be moved to ServerPhase easily if the FoxxQueue dependency would be removed
* Final movement of Startup Phases. Now solved all circles.
* Removed merge conflict
* Moved ReplicationTimeout into cluster phase and fixed cross-phase requirements
* Added greetings phase. This phase separates the Basics Phase and is the first to be run. Includes Logger and Hello/Goodbye
* Added the GreetingsPhase in the corresponding features. Now all BasicsPhase features start after greetings Phase. There is some issue in this branch which prevents the Agency from Gossipping right now. Will be fixed next
* Moved creation of the Agent into the prepare phase of the feature. THereby it is guaranteed that agents at least exists before the GeneralServer is activating endpoints
* Recovery needs to be started after the ServerID
* Moved log output of FeaturePhases to DEBUG instead of ERROR.
* Added feature phases for clients
* ClusterFeature now does not directly require AgencyFeature any more
* Added requirement of TravEngineRegistryFeature in AQL feature. Otherwise shutdown may be undefined
* The ApplicationServer can now handout the list of ordered features. Used for testing purposes
* Fixed IResearchVew Tests Setup to honor new feature ordering
* Fixed IResearchViewDBServer Tests Setup to honor new feature ordering
* Started fixing IResearchView Coordinator tests with startup ordering. Not finished yet
* Added startup phases to ViewCoordinator test
* Disabled expected logoutput in ClusterRepairsTest
* Fixed indention in test code
* LinkCoordinator now honors startup ordering
* Link meta now honors startup rdering
* Supress expected cluster logs in ViewTest
* Removed '#' accidentially added.
* issue 400.2.4: register IResearchView sync tasks with IResearchFeature, remove unused configuration parameter
* set flag before notify, fix failures in new tests from 'devel'
* revert set flag before notify, fix more failures in new tests from 'devel'
* fix even more failures in new tests from 'devel', backport: do not reset notification flag if pending tasks were seen
* fix still more failures in new tests from 'devel'
* try to work around buggy test failures
* issue 401.2: split IResearchViewMeta into the user configurable part and internal state
* backport: update documentation and integration tests to reflect the IResearchViewMeta changes
* backport: addresss typo
* backport: address another typo
Andrey Abramov
Max Neunhöffer
Jan
KVS85
Simon
Dan Larkin-York
Vasiliy
Luschgy
Andrey Abramov
Wilfried Goesgens
Tobias Gödderz
Michael Hackstein