1
0
Fork 0
Commit Graph

345 Commits

Author SHA1 Message Date
Dronplane 592063c503 Bug fix 3.4/data loss in view (#9658)
* Added full index iterator utilization in case of some documents was not found in collection

* Added index operations reversal in case of insertion failure in rocksdb

* Removed singleop optimization as rollback possible even for such operations (in case of index operation failure on insert)

* Added tests for insert rollback in views

* Added catch tests for view block

* Added changelog entry

* fixed jslint errors

* fixed linux build

* Added test for update

* Fix CHANGELOG sequence

* Add line

* Added reverts for update and remove failures

* Cleanup in test. Added throwing error in case of failed reversal

* fixed typo

Co-Authored-By: Simran <Simran-B@users.noreply.github.com>

* fixed build

* Applied review comments

* Applied review comments
2019-08-09 17:30:17 +03:00
Simon 5eb4951d29 use a lock when calling unload (#9367) 2019-07-03 16:21:00 +02:00
Simon 17468f1dc9 do not buffer index estimates (#9338) 2019-06-26 17:27:01 +02:00
Simon 89a7591d00 Bug fix 3.4/rocksdb truncate asan (#8525) 2019-03-22 17:15:03 +01:00
Jan 3f3f0c6fe3
Feature 3.4/ncc1701 (#8441) 2019-03-21 14:53:28 +01:00
Jan db7fcdce7a
don't run compact() on a collection after a truncate() was done in the same transaction (#8471)
running compact() in the same transaction will only increase the data size on disk due to
  RocksDB not being able to remove any documents physically due to the snapshot that is
  taken at transaction start.

  This change also exposes db.<collection>.compact() in the arangosh, in order to manually
  run a compaction on the data range of a collection should it be needed for maintenance.
2019-03-20 17:44:06 +01:00
Vasiliy e536f2ab1f issue 525.1: backport 3.4: ensure RocksDB CreateIndex/DropIndex WAL markers are properly written during recovery (#8279)
* issue 525.1: backport 3.4: ensure RocksDB CreateIndex/DropIndex WAL markers are properly writen during recovery

* backport: skip writing DropIndex marker in recovery
2019-03-01 15:57:42 +03:00
Jan 8e3fb5dfc7
Feature 3.4/improve replication speed (#8268) 2019-02-28 14:37:40 +01:00
Jan fbc1e5b35f
use PutUntracked (#8126) 2019-02-13 16:04:27 +01:00
Frank Celler 9477af198b big reformat 2018-12-26 00:57:05 +01:00
Simon 4132870e49 Document RocksDB exclusive option (#7517) (#7538) 2018-11-29 18:42:43 +01:00
Simon 933ca8a775 Bug fix/restore index refactor (#7470) (#7491)
(cherry picked from commit d0efd95a37)
2018-11-29 14:08:29 +01:00
Jan 2d4b38600f
prevent operations from overtaking each other (#7498) 2018-11-28 14:30:54 +01:00
Simon 8ddb9a063b Micro-Optimize AQL CXX calls (#7486) 2018-11-27 20:22:18 +01:00
Jan ffc823e1c8
Bug fix 3.4/backport optimizations (#7434) 2018-11-26 19:16:05 +01:00
Michael Hackstein 8098bb4eed
Bug fix 3.4/syncing of followers (#7377)
* Added some DEBUG output for replication rest handler

* Some more debug logging.

* Increased the priority of the ReplicationHandler. This way we will not get stuck with locks that cannot be canceled. Also cancel the lock on the correct database.

* Added extensive log output for replication thins

* Added tombstones to RestReplicationHandler. In a very unlikely case the cancel of a lock can be executed BEFORE the code that actually registers the lock, in this case we will now write a tombstone and do not lock.

* Revert "Added extensive log output for replication thins"

This reverts commit 6d4e37ea1e59e3b3457336019cc7dbc4c979504d.

* Added extensive log output for replication things, now in ERR level instead of MAINTAINER only

* Now actually use hours for synchronization

* React to errors under soft lock if they show up.

* Added a retry loop to increase the read-lock timer.

* Added more timeing output in RocksDB collection internals to figure out why the followers are dropped

* Tweaked RocksDB options

* Revert "Tweaked RocksDB options"

This reverts commit 2bf9c43280beda4792c47d079387fe5154cdd896.

* Removed debug output

* Applied all requested changes by goedderz

* Deleted unused variable
2018-11-23 16:08:27 +01:00
Simon ef239cbe4e Make recovery more reliable (#7297) (#7367) 2018-11-21 16:51:38 +01:00
Jan Christoph Uhde 8441368954 disable RocksDB indexing for some secondary index operations (#7393) 2018-11-21 15:50:36 +01:00
Dan Larkin-York a7c9374527 Hide internal link properties (#7209) 2018-11-20 18:00:14 +01:00
Jan d27c4cc113
Bug fix 3.4/aql speedup (#7378) 2018-11-20 16:08:16 +01:00
Simon 5124633e6a Faster index creation (#7348) 2018-11-20 13:41:01 +01:00
Tobias Gödderz 3d1c643e23 [3.4] MMFiles replication: get followers under lock (#7298)
* Fix resign order

* Fixed a typo

* Get followers later, add TODOs

* Added a callback parameter to collection insert methods

* Get followers under the lock if necessary

* Extracted the replication of inserts into a separate method

* Move shortcut into replicate method

* Added callbacks for remove, replace and update

* Added missing overrides

* Extracted replication code from modifyLocal and removeLocal

* Update followers under lock also during replace, update, remove

* Fix changes from the last commit for update/replace

* Update comments, add asserts

* Remove changes for document-level locks that will be done in another PR

* Unify replication

* Adapt log messages to the devel ones

* Move common methods from its descendants to TransactionCollection, fix Mock on the way

* More IResearch test / mock fixes

* Relax asserts for nested transactions

* Reformat

* Fix non-babies remove and modify replication
2018-11-19 13:03:07 +01:00
Simon f2f4a0fdaf Truncate Fix (Nr 6) (#7176) 2018-10-31 16:32:00 +01:00
Simon 78132bc2e5 Next try at truncate (#7090) (#7096) 2018-10-26 15:06:36 +02:00
Simon 3e5f90dcd3 Truncate index extimate fix (#7017) 2018-10-23 18:06:55 +02:00
Jan 4e7f56a532
attempt to fix truncation (#7002) 2018-10-22 16:44:21 +02:00
Simon c2b6fb99ba Propper commit Sequence Numbers (#6958) 2018-10-18 18:25:34 +02:00
Jan 5a347017da
backport some fixes to 3.4 (#6739) 2018-10-08 09:43:14 +02:00
Dan Larkin-York 3d15b96f66 [3.4] Additional and cleaned-up logging (#6648) 2018-10-01 19:03:05 +02:00
Jan 68e81da38e
handle DeleteRange markers on RocksDB recovery (#6565) 2018-09-28 11:10:11 +02:00
Jan d3b43b1cfc
fix assertion failure with _numLogData (#6632) 2018-09-27 19:26:10 +02:00
Jan a8cd72f502
Bug fix 3.4/optimizations 210918 (#6574) 2018-09-25 09:50:25 +02:00
Simon 3c965ee48a Resilience test failure points (#6545) 2018-09-20 01:04:38 +02:00
Simon 3eed525481 Hide links (#6348) 2018-09-03 15:36:37 +02:00
Jan 5022ccc24d
Bug fix/fixes 2508 (#6254) 2018-08-27 21:36:39 +02:00
Simon Grätzer c3d950f1d6 fix shard move 2018-08-22 12:42:57 +02:00
Jan e5864838d5
use rocksdb::Transaction::PopSavePoint() (#6192)
this prevents stacking many useless SavePoints in transactions with
many operations.

The PopSavePoint method in RocksDB is forward-ported from upstream
RocksDB commit 90f744941d48f15d5d070dfcab5d51b77abac8ad.
This is likely to be released with a future release of RocksDB.
2018-08-20 12:13:26 +02:00
Jan d78adb7ae1
Bug fix/turn off range deletes in cluster (#6178) 2018-08-17 08:41:00 +02:00
Simon 392118bd62 Use RangeDelete where possible (#6121) 2018-08-15 18:52:09 +02:00
Simon 4238cff3ff Adding cacheUsage property and tests (#6075)
* Adding cacheUsage property and tests

* Make cacheUsage more permissible
2018-08-06 14:55:20 +02:00
Simon Grätzer 7ac0a70bc7 add cache stats to collection figures 2018-08-03 18:21:11 +02:00
Jan b278d6874a
allow master & slave to work in parallel for RocksDB WAL tailing (#6059) 2018-08-03 13:37:53 +02:00
Simon 42cabb858a Fix dumping of views in the cluster (#6024) 2018-08-02 17:25:49 +02:00
Simon Grätzer a7c78a3f37 Merge branch 'devel' of github.com:arangodb/arangodb into bug-fix/improve-intermediate-commits
# Conflicts:
#	arangod/RocksDBEngine/RocksDBIncrementalSync.cpp
#	arangod/RocksDBEngine/RocksDBIterators.cpp
2018-07-31 15:19:57 +02:00
Jan 2a416f2e33
Bug fix/3007 (#6019) 2018-07-30 17:16:47 +02:00
Simon Grätzer 9d979efbd6 remove redundant test 2018-07-27 18:22:24 +02:00
Simon Grätzer 1cfb328bcc fix intermediate commits 2018-07-27 17:40:38 +02:00
Vasiliy 62ca1235ac issue 430.3: remove redundant constructor from SingleCollectionTransaction (#5996) 2018-07-26 16:54:53 +03:00
Jan 21064144c8
Bug fix/replication improvements (#5962) 2018-07-25 09:04:50 +02:00
Vasiliy 08d3cb3802 issue 399.4: use LogicalCollection& instead of LogicalCollection* in Index (#5929)
* issue 399.4: use LogicalCollection& instead of LogicalCollection* in Index

* backport: address enterprise build issues
2018-07-20 14:55:58 +03:00