Hawkin
/
arangodb
mirror of https://gitee.com/bigwinds/arangodb
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

improve error messages

This commit is contained in:
jsteemann 2017-05-04 16:34:22 +02:00
parent 0cad04bdb3
commit f4911e262b
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
arangod/RocksDBEngine/RocksDBLogValue.cpp
View File

@ -22,7 +22,7 @@
/// @author Daniel H. Larkin /// @author Daniel H. Larkin
//////////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////////
#include "RocksDBEngine/RocksDBLogValue.h" #include "RocksDBLogValue.h"
#include "Basics/Common.h" #include "Basics/Common.h"
#include "Basics/Exceptions.h" #include "Basics/Exceptions.h"
#include "RocksDBEngine/RocksDBCommon.h" #include "RocksDBEngine/RocksDBCommon.h"
@ -112,7 +112,7 @@ RocksDBLogValue::RocksDBLogValue(RocksDBLogType type) : _buffer() {
_buffer.push_back(static_cast<char>(type)); _buffer.push_back(static_cast<char>(type));
break; break;
default: default:
THROW_ARANGO_EXCEPTION(TRI_ERROR_BAD_PARAMETER); THROW_ARANGO_EXCEPTION_MESSAGE(TRI_ERROR_BAD_PARAMETER, "invalid type for log value");
} }
} }
@ -128,7 +128,7 @@ RocksDBLogValue::RocksDBLogValue(RocksDBLogType type, uint64_t val)
} }
default: default:
THROW_ARANGO_EXCEPTION(TRI_ERROR_BAD_PARAMETER); THROW_ARANGO_EXCEPTION_MESSAGE(TRI_ERROR_BAD_PARAMETER, "invalid type for log value");
} }
} }
@ -149,7 +149,7 @@ RocksDBLogValue::RocksDBLogValue(RocksDBLogType type, uint64_t dbId,
} }
default: default:
THROW_ARANGO_EXCEPTION(TRI_ERROR_BAD_PARAMETER); THROW_ARANGO_EXCEPTION_MESSAGE(TRI_ERROR_BAD_PARAMETER, "invalid type for log value");
} }
} }
@ -166,7 +166,7 @@ RocksDBLogValue::RocksDBLogValue(RocksDBLogType type, uint64_t dbId,
break; break;
} }
default: default:
THROW_ARANGO_EXCEPTION(TRI_ERROR_BAD_PARAMETER); THROW_ARANGO_EXCEPTION_MESSAGE(TRI_ERROR_BAD_PARAMETER, "invalid type for log value");
} }
} }
@ -185,7 +185,7 @@ RocksDBLogValue::RocksDBLogValue(RocksDBLogType type, uint64_t dbId,
break; break;
} }
default: default:
THROW_ARANGO_EXCEPTION(TRI_ERROR_BAD_PARAMETER); THROW_ARANGO_EXCEPTION_MESSAGE(TRI_ERROR_BAD_PARAMETER, "invalid type for log value");
} }
} }
@ -193,6 +193,7 @@ RocksDBLogValue::RocksDBLogValue(RocksDBLogType type, uint64_t dbId,
uint64_t cid, StringRef const& data) uint64_t cid, StringRef const& data)
: _buffer() { : _buffer() {
switch (type) { switch (type) {
case RocksDBLogType::SingleRemove:
case RocksDBLogType::CollectionRename: { case RocksDBLogType::CollectionRename: {
_buffer.reserve(sizeof(RocksDBLogType) + sizeof(uint64_t) * 2 + _buffer.reserve(sizeof(RocksDBLogType) + sizeof(uint64_t) * 2 +
data.length()); data.length());
@ -203,7 +204,7 @@ RocksDBLogValue::RocksDBLogValue(RocksDBLogType type, uint64_t dbId,
break; break;
} }
default: default:
THROW_ARANGO_EXCEPTION(TRI_ERROR_BAD_PARAMETER); THROW_ARANGO_EXCEPTION_MESSAGE(TRI_ERROR_BAD_PARAMETER, "invalid type for log value");
} }
} }
@ -218,7 +219,7 @@ RocksDBLogValue::RocksDBLogValue(RocksDBLogType type, StringRef const& data)
} }
default: default:
THROW_ARANGO_EXCEPTION(TRI_ERROR_BAD_PARAMETER); THROW_ARANGO_EXCEPTION_MESSAGE(TRI_ERROR_BAD_PARAMETER, "invalid type for log value");
} }
} }