Hawkin
/
arangodb
mirror of https://gitee.com/bigwinds/arangodb
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix double precision loss in VelocyPack parser

This commit is contained in:
jsteemann 2016-07-04 14:59:50 +02:00
parent 9c98cb6cf3
commit e8ce6767b1
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
3rdParty/velocypack/src/Parser.cpp vendored
View File

@ -28,6 +28,8 @@
#include "velocypack/Parser.h" #include "velocypack/Parser.h"
#include "asm-functions.h" #include "asm-functions.h"
#include <cstdlib>
using namespace arangodb::velocypack; using namespace arangodb::velocypack;
// The following function does the actual parse. It gets bytes // The following function does the actual parse. It gets bytes
@ -121,6 +123,7 @@ int Parser::skipWhiteSpace(char const* err) {
// parses a number value // parses a number value
void Parser::parseNumber() { void Parser::parseNumber() {
size_t startPos = _pos;
ParsedNumber numberValue; ParsedNumber numberValue;
bool negative = false; bool negative = false;
int i = consume(); int i = consume();
@ -191,7 +194,10 @@ void Parser::parseNumber() {
} }
if (i != 'e' && i != 'E') { if (i != 'e' && i != 'E') {
unconsume(); unconsume();
_b->addDouble(fractionalPart); // use conventional atof() conversion here, to avoid precision loss
// when interpreting and multiplying the single digits of the input stream
// _b->addDouble(fractionalPart);
_b->addDouble(atof(reinterpret_cast<char const*>(_start) + startPos));
return; return;
} }
i = getOneOrThrow("Incomplete number"); i = getOneOrThrow("Incomplete number");
@ -214,7 +220,10 @@ void Parser::parseNumber() {
if (std::isnan(fractionalPart) || !std::isfinite(fractionalPart)) { if (std::isnan(fractionalPart) || !std::isfinite(fractionalPart)) {
throw Exception(Exception::NumberOutOfRange); throw Exception(Exception::NumberOutOfRange);
} }
_b->addDouble(fractionalPart); // use conventional atof() conversion here, to avoid precision loss
// when interpreting and multiplying the single digits of the input stream
// _b->addDouble(fractionalPart);
_b->addDouble(atof(reinterpret_cast<char const*>(_start) + startPos));
} }
void Parser::parseString() { void Parser::parseString() {