diff --git a/arangod/Agency/AgencyComm.cpp b/arangod/Agency/AgencyComm.cpp index b4d460ea88..a17f36cad4 100644 --- a/arangod/Agency/AgencyComm.cpp +++ b/arangod/Agency/AgencyComm.cpp @@ -61,7 +61,7 @@ static void addEmptyVPackObject(std::string const& name, // ----------------------------------------------------------------------------- AgencyPrecondition::AgencyPrecondition() - : type(AgencyPrecondition::Type::NONE) {} + : type(AgencyPrecondition::Type::NONE), empty(false) {} AgencyPrecondition::AgencyPrecondition(std::string const& key, Type t, bool e) : key(AgencyCommManager::path(key)), type(t), empty(e) {} diff --git a/arangod/Agency/AgencyComm.h b/arangod/Agency/AgencyComm.h index 01084cc802..9baf8f91c9 100644 --- a/arangod/Agency/AgencyComm.h +++ b/arangod/Agency/AgencyComm.h @@ -183,7 +183,7 @@ class AgencyPrecondition { class AgencyOperation { public: - AgencyOperation(std::string const& key); + explicit AgencyOperation(std::string const& key); AgencyOperation(std::string const& key, AgencySimpleOperationType opType); @@ -405,7 +405,7 @@ class AgencyCommManager { static std::string generateStamp(); public: - AgencyCommManager(std::string const& prefix) : _prefix(prefix) {} + explicit AgencyCommManager(std::string const& prefix) : _prefix(prefix) {} public: bool start(); diff --git a/arangod/Agency/AgencyCommon.h b/arangod/Agency/AgencyCommon.h index ada705a4ed..934817e86a 100644 --- a/arangod/Agency/AgencyCommon.h +++ b/arangod/Agency/AgencyCommon.h @@ -77,8 +77,8 @@ struct trans_ret_t { index_t maxind; size_t failed; query_t result; - trans_ret_t() : accepted(false), redirect("") {} - trans_ret_t(bool a, std::string const& id) : accepted(a), redirect(id) {} + trans_ret_t() : accepted(false), redirect(""), maxind(0), failed(0) {} + trans_ret_t(bool a, std::string const& id) : accepted(a), redirect(id), maxind(0), failed(0) {} trans_ret_t(bool a, std::string const& id, index_t mi, size_t f, query_t const& res) : accepted(a), redirect(id), maxind(mi), failed(f), result(res) {} diff --git a/arangod/Agency/Agent.cpp b/arangod/Agency/Agent.cpp index 38e1b18a88..90ba5811e6 100644 --- a/arangod/Agency/Agent.cpp +++ b/arangod/Agency/Agent.cpp @@ -573,8 +573,6 @@ query_t Agent::lastAckedAgo() const { } trans_ret_t Agent::transact(query_t const& queries) { - - std::vector applied; arangodb::consensus::index_t maxind = 0; // maximum write index if (!_constituent.leading()) { @@ -634,7 +632,6 @@ trans_ret_t Agent::transact(query_t const& queries) { /// Write new entries to replicated state and store write_ret_t Agent::write(query_t const& query) { - std::vector applied; std::vector indices;