1
0
Fork 0

distributeShardsLike is not ignored when prototype does not exist

This commit is contained in:
Kaveh Vahedipour 2017-04-27 10:38:07 +02:00
parent 278fad9185
commit e778604cef
4 changed files with 9 additions and 15 deletions

View File

@ -258,8 +258,8 @@ class ClusterMethods {
static std::unique_ptr<LogicalCollection> createCollectionOnCoordinator( static std::unique_ptr<LogicalCollection> createCollectionOnCoordinator(
TRI_col_type_e collectionType, TRI_vocbase_t* vocbase, TRI_col_type_e collectionType, TRI_vocbase_t* vocbase,
arangodb::velocypack::Slice parameters, arangodb::velocypack::Slice parameters,
bool ignoreDistributeShardsLikeErrors, bool ignoreDistributeShardsLikeErrors = true,
bool waitForSyncReplication); bool waitForSyncReplication = true);
private: private:
@ -268,7 +268,8 @@ class ClusterMethods {
//////////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////////
static std::unique_ptr<LogicalCollection> persistCollectionInAgency( static std::unique_ptr<LogicalCollection> persistCollectionInAgency(
LogicalCollection* col, bool ignoreDistributeShardsLikeErrors, bool waitForSyncReplication); LogicalCollection* col, bool ignoreDistributeShardsLikeErrors = true,
bool waitForSyncReplication = true);
}; };
} // namespace arangodb } // namespace arangodb

View File

@ -734,8 +734,9 @@ static void CreateVocBase(v8::FunctionCallbackInfo<v8::Value> const& args,
} }
std::unique_ptr<LogicalCollection> col = std::unique_ptr<LogicalCollection> col =
ClusterMethods::createCollectionOnCoordinator(collectionType, vocbase, ClusterMethods::createCollectionOnCoordinator(
infoSlice, true, createWaitsForSyncReplication); collectionType, vocbase, infoSlice, false,
createWaitsForSyncReplication);
TRI_V8_RETURN(WrapCollection(isolate, col.release())); TRI_V8_RETURN(WrapCollection(isolate, col.release()));
} }

View File

@ -499,15 +499,7 @@ std::string LogicalCollection::name() const {
} }
std::string const LogicalCollection::distributeShardsLike() const { std::string const LogicalCollection::distributeShardsLike() const {
if (!_distributeShardsLike.empty()) { return _distributeShardsLike;
CollectionNameResolver resolver(_vocbase);
TRI_voc_cid_t shardLike =
resolver.getCollectionIdCluster(_distributeShardsLike);
if (shardLike != 0) {
return basics::StringUtils::itoa(shardLike);
}
}
return "";
} }
void LogicalCollection::distributeShardsLike(std::string const& cid) { void LogicalCollection::distributeShardsLike(std::string const& cid) {