issue #972: Compilation Issue

lib/Utilities/DummyShell.cpp

@@ -33,7 +33,7 @@
 #include "BasicsC/files.h"
 
 using namespace std;
-using namespace triagentriagens;
+using namespace triagens;
 
 // -----------------------------------------------------------------------------
 // --SECTION--                                                  class DummyShell
@@ -47,10 +47,9 @@ using namespace triagentriagens;
 /// @brief constructs a new editor
 ////////////////////////////////////////////////////////////////////////////////
 
-DummyShell::DummyShell (std::string const& history)
+DummyShell::DummyShell (std::string const& history,
-  : _current(),
+                        Completer* completer)
-    _historyFilename(history),
+  : ShellImplementation(history, completer) {
-    _state(STATE_NONE) {
 }
 
 ////////////////////////////////////////////////////////////////////////////////
@@ -83,29 +82,6 @@ bool DummyShell::close () {
   return true;
 }
 
-////////////////////////////////////////////////////////////////////////////////
-/// @brief get the history file path
-////////////////////////////////////////////////////////////////////////////////
-
-string DummyShell::historyPath () {
-  return "";
-}
-
-////////////////////////////////////////////////////////////////////////////////
-/// @brief add to history
-////////////////////////////////////////////////////////////////////////////////
-
-void DummyShell::addHistory (char const* str) {
-}
-
-////////////////////////////////////////////////////////////////////////////////
-/// @brief save history
-////////////////////////////////////////////////////////////////////////////////
-
-bool DummyShell::writeHistory () {
-  return true;
-}
-
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief line editor prompt
 ////////////////////////////////////////////////////////////////////////////////
@@ -137,7 +113,7 @@ char* DummyShell::prompt (char const* prompt) {
     p = dotdot.c_str();
 
     if (cin.eof()) {
-        return 0;
+      return nullptr;
     }
 
     _current += sep;
@@ -164,7 +140,7 @@ char* DummyShell::prompt (char const* prompt) {
     // extend line and check
     _current += result;
 
-    bool ok = isComplete(_current, lineno, strlen(result));
+    bool ok = _completer->isComplete(_current, lineno, strlen(result));
 
     // stop if line is complete
     if (ok) {
@@ -173,11 +149,46 @@ char* DummyShell::prompt (char const* prompt) {
   }
 
   char* line = TRI_DuplicateStringZ(TRI_UNKNOWN_MEM_ZONE, _current.c_str());
+
   _current.clear();
 
   return line;
 }
 
+////////////////////////////////////////////////////////////////////////////////
+/// @brief get the history file path
+////////////////////////////////////////////////////////////////////////////////
+
+string DummyShell::historyPath () {
+  return "";
+}
+
+////////////////////////////////////////////////////////////////////////////////
+/// @brief add to history
+////////////////////////////////////////////////////////////////////////////////
+
+void DummyShell::addHistory (char const* str) {
+}
+
+////////////////////////////////////////////////////////////////////////////////
+/// @brief save history
+////////////////////////////////////////////////////////////////////////////////
+
+bool DummyShell::writeHistory () {
+  return true;
+}
+
+////////////////////////////////////////////////////////////////////////////////
+/// @brief returns the characters which the user has typed
+/// @arg  is the prompt of the shell
+/// Note: this is the interface between our shell world and some implementation
+///       of key events (linenoise, readline)
+////////////////////////////////////////////////////////////////////////////////
+
+char* DummyShell::getLine (char const* prompt) {
+  return this->prompt(prompt);
+}
+
 // -----------------------------------------------------------------------------
 // --SECTION--                                                       END-OF-FILE
 // -----------------------------------------------------------------------------

lib/Utilities/DummyShell.h

@@ -39,21 +39,17 @@
 #include "V8/v8-utils.h"
 
 namespace triagens {
-  using namespace std;
 
-////////////////////////////////////////////////////////////////////////////////
+  class DummyShell : public ShellImplementation {
-/// @addtogroup Shell
-/// @{
-////////////////////////////////////////////////////////////////////////////////
-
-  class DummyShell: public ShellImplementation {
 
     public:
+
 ////////////////////////////////////////////////////////////////////////////////
 ///                                               public constructor, destructor
 ////////////////////////////////////////////////////////////////////////////////
 
-    DummyShell(string const& history, Completer *);
+      DummyShell (std::string const& history,   
+                  Completer*);
   
       virtual ~DummyShell();
 
@@ -61,7 +57,7 @@ namespace triagens {
 /// @brief line editor open
 ////////////////////////////////////////////////////////////////////////////////
 
-    virtual bool open(bool autoComplete);
+      virtual bool open (bool autoComplete);
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief line editor shutdown
@@ -69,6 +65,12 @@ namespace triagens {
 
       virtual bool close();
 
+////////////////////////////////////////////////////////////////////////////////
+/// @brief line editor prompt
+////////////////////////////////////////////////////////////////////////////////
+
+      virtual char* prompt (char const* prompt);
+
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief get the history file path
 ///
@@ -82,7 +84,7 @@ namespace triagens {
 /// @brief add to history
 ////////////////////////////////////////////////////////////////////////////////
 
-    virtual void addHistory(const char*);
+      virtual void addHistory (const char*);
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief save the history
@@ -97,11 +99,7 @@ namespace triagens {
 ///       of key events (linenoise, readline)
 ////////////////////////////////////////////////////////////////////////////////
 
-    virtual char * getLine(char const *);
+      virtual char* getLine (char const*);
-
-////////////////////////////////////////////////////////////////////////////////
-/// @}
-////////////////////////////////////////////////////////////////////////////////
 
   };
 }

lib/Utilities/LinenoiseShell.cpp

@@ -157,7 +157,7 @@ bool LinenoiseShell::writeHistory() {
   return true;
 }
 
-char * LinenoiseShell::getLine(char const * input) {
+char* LinenoiseShell::getLine(char const* input) {
   return linenoise(input);
 }
 

lib/Utilities/LinenoiseShell.h

@@ -96,7 +96,7 @@ namespace triagens {
 ///       of key events (linenoise, readline)
 ////////////////////////////////////////////////////////////////////////////////
 
-    virtual char * getLine(char const *);
+    virtual char* getLine (char const*);
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @}

lib/Utilities/ShellImplFactory.cpp

@@ -28,14 +28,14 @@
 /// @author Copyright 2011-2014, triAGENS GmbH, Cologne, Germany
 ////////////////////////////////////////////////////////////////////////////////
 
-
-
 #ifdef _WIN32
 #include "LinenoiseShell.h"
 #elif TRI_HAVE_LINENOISE
 #include "LinenoiseShell.h"
-#else
+#elif TRI_HAVE_READLINE
 #include "ReadlineShell.h"
+#else 
+#include "DummyShell.h"
 #endif
 
 #include "ShellImplFactory.h"
@@ -43,15 +43,19 @@
 using namespace triagens;
 using namespace std;
 
-ShellImplementation * ShellImplFactory::buildShell (string const & history, Completer * completer) {
+ShellImplementation* ShellImplFactory::buildShell (string const & history, 
+                                                   Completer* completer) {
 
 #ifdef _WIN32
   //under windows the readline is not compilable
   return new LinenoiseShell(history, completer);
 #elif defined TRI_HAVE_LINENOISE
   return new LinenoiseShell(history, completer);
-#else
+#elif defined TRI_HAVE_READLINE
   return new ReadlineShell(history, completer);
+#else
+  // last resort!
+  return new DummyShell(history, completer);
 #endif
 
 }

lib/Utilities/ShellImplementation.cpp

@@ -32,43 +32,46 @@
 #include "BasicsC/tri-strings.h"
 
 using namespace std;
-namespace triagens {
-  // -----------------------------------------------------------------------------
-  // --SECTION--                                         class ShellImplementation
-  // -----------------------------------------------------------------------------
 
-  // -----------------------------------------------------------------------------
+namespace triagens {
-  // --SECTION--                                      constructors and destructors
+
-  // -----------------------------------------------------------------------------
+// -----------------------------------------------------------------------------
+// --SECTION--                                         class ShellImplementation
+// -----------------------------------------------------------------------------
+
+// -----------------------------------------------------------------------------
+// --SECTION--                                      constructors and destructors
+// -----------------------------------------------------------------------------
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief constructs a new editor
 ////////////////////////////////////////////////////////////////////////////////
 
-  ShellImplementation::ShellImplementation (string const& history, Completer * completer)
+ShellImplementation::ShellImplementation (string const& history, 
+                                          Completer* completer)
   : _current(),
     _historyFilename(history),
     _state(STATE_NONE),
     _completer(completer) {
 
-  }
+}
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief destructor
 ////////////////////////////////////////////////////////////////////////////////
 
-  ShellImplementation::~ShellImplementation () {
+ShellImplementation::~ShellImplementation () {
-  }
+}
 
-  // -----------------------------------------------------------------------------
+// -----------------------------------------------------------------------------
-  // --SECTION--                                                    public methods
+// --SECTION--                                                    public methods
-  // -----------------------------------------------------------------------------
+// -----------------------------------------------------------------------------
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief line editor prompt
 ////////////////////////////////////////////////////////////////////////////////
 
-  char* ShellImplementation::prompt (char const* the_prompt) {
+char* ShellImplementation::prompt (char const* the_prompt) {
   string dotdot;
   char const* p = the_prompt;
   size_t len1 = strlen(the_prompt);
@@ -91,11 +94,11 @@ namespace triagens {
 
     p = dotdot.c_str();
 
-      if (result == 0) {
+    if (result == nullptr) {
 
       // give up, if the user pressed control-D on the top-most level
       if (_current.empty()) {
-          return 0;
+        return nullptr;
       }
 
       // otherwise clear current content
@@ -142,8 +145,10 @@ namespace triagens {
   _current.clear();
 
   return line;
-  }
 }
+
+}
+
 // -----------------------------------------------------------------------------
 // --SECTION--                                                       END-OF-FILE
 // -----------------------------------------------------------------------------

lib/Utilities/ShellImplementation.h

@@ -37,10 +37,13 @@
 namespace triagens {
 
   class ShellImplementation {
+
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief state of the console                                  protected types
 ////////////////////////////////////////////////////////////////////////////////
+
   protected:
+
     typedef enum {
       STATE_NONE = 0,
       STATE_OPENED,
@@ -49,11 +52,12 @@ namespace triagens {
     console_state_e;
 
   public:
+
 ////////////////////////////////////////////////////////////////////////////////
 ///                                               public constructor, destructor
 ////////////////////////////////////////////////////////////////////////////////
 
-    ShellImplementation (std::string const& history, Completer *);
+    ShellImplementation (std::string const& history, Completer*);
 
     virtual ~ShellImplementation ();
 
@@ -100,15 +104,11 @@ namespace triagens {
 /// @brief todo!!
 ////////////////////////////////////////////////////////////////////////////////
 
-    virtual char * getLine (const char*) = 0;
+    virtual char* getLine (const char*) = 0;
 
-////////////////////////////////////////////////////////////////////////////////
+// -----------------------------------------------------------------------------
-/// @}
+// --SECTION--                                               protected variables
-////////////////////////////////////////////////////////////////////////////////
+// -----------------------------------------------------------------------------
-
-    // -----------------------------------------------------------------------------
-    // --SECTION--                                               protected variables
-    // -----------------------------------------------------------------------------
 
   protected:
 
@@ -134,11 +134,13 @@ namespace triagens {
 /// @brief object which defines when the input is finished
 ////////////////////////////////////////////////////////////////////////////////
 
-    Completer * _completer;
+    Completer* _completer;
 
   };
 }
+
 #endif
+
 // -----------------------------------------------------------------------------
 // --SECTION--                                                       END-OF-FILE
 // -----------------------------------------------------------------------------