From 8483a8bd4525df341674f52da2eaf1294ce41772 Mon Sep 17 00:00:00 2001 From: Michael Hackstein Date: Thu, 6 Nov 2014 14:36:09 +0000 Subject: [PATCH 1/4] Fixed aardvark router test --- js/apps/system/aardvark/test/specs/router/routerSpec.js | 1 + 1 file changed, 1 insertion(+) diff --git a/js/apps/system/aardvark/test/specs/router/routerSpec.js b/js/apps/system/aardvark/test/specs/router/routerSpec.js index 278fed6c4c..44e6d357b2 100644 --- a/js/apps/system/aardvark/test/specs/router/routerSpec.js +++ b/js/apps/system/aardvark/test/specs/router/routerSpec.js @@ -504,6 +504,7 @@ "databaseView", "databases-menu", { + users: sessionDummy, collection: databaseDummy } ); From 166407d4f9fe5cb8907a48ea0cfd13f88d488661 Mon Sep 17 00:00:00 2001 From: Michael Hackstein Date: Thu, 6 Nov 2014 14:45:24 +0000 Subject: [PATCH 2/4] Fixed user management view test --- .../aardvark/test/specs/views/userManagementViewSpec.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/js/apps/system/aardvark/test/specs/views/userManagementViewSpec.js b/js/apps/system/aardvark/test/specs/views/userManagementViewSpec.js index 83cc62fd21..b28fecd611 100644 --- a/js/apps/system/aardvark/test/specs/views/userManagementViewSpec.js +++ b/js/apps/system/aardvark/test/specs/views/userManagementViewSpec.js @@ -69,7 +69,9 @@ "click #userManagementSearchSubmit" : "search", "click #callEditUserPassword" : "editUserPassword", "click #submitEditUserPassword" : "submitEditUserPassword", - "click #submitEditCurrentUserProfile" : "submitEditCurrentUserProfile" + "click #submitEditCurrentUserProfile" : "submitEditCurrentUserProfile", + "click .css-label" : "checkBoxes", + "change #userSortDesc" : "sorting" }; expect(myEvents).toEqual(myView.events); }); From 3fecf7d4cb6a272d66eaeaef8f6a9ff029627780 Mon Sep 17 00:00:00 2001 From: Michael Hackstein Date: Thu, 6 Nov 2014 14:54:11 +0000 Subject: [PATCH 3/4] Fixed document view tests --- js/apps/system/aardvark/test/specs/views/documentViewSpec.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/js/apps/system/aardvark/test/specs/views/documentViewSpec.js b/js/apps/system/aardvark/test/specs/views/documentViewSpec.js index 2cd4b8602f..6d5cc5dbee 100644 --- a/js/apps/system/aardvark/test/specs/views/documentViewSpec.js +++ b/js/apps/system/aardvark/test/specs/views/documentViewSpec.js @@ -39,6 +39,10 @@ expect(view.colid).toEqual(0); expect(view.events).toEqual({ "click #saveDocumentButton": "saveDocument", + "click #deleteDocumentButton" : "deleteDocumentModal", + "click #confirmDeleteDocument" : "deleteDocument", + "click #document-from" : "navigateToDocument", + "click #document-to" : "navigateToDocument", "dblclick #documentEditor tr" : "addProperty" }); }); From d1f4c6b5feec308a5a6d051d074809127f0c542e Mon Sep 17 00:00:00 2001 From: Jan Steemann Date: Sun, 9 Nov 2014 00:09:07 +0100 Subject: [PATCH 4/4] fixed optimization --- arangod/Aql/AstNode.cpp | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/arangod/Aql/AstNode.cpp b/arangod/Aql/AstNode.cpp index f6e66a9c9f..ef59f2bce2 100644 --- a/arangod/Aql/AstNode.cpp +++ b/arangod/Aql/AstNode.cpp @@ -936,9 +936,12 @@ bool AstNode::isTrue () const { return getMember(1)->isTrue(); } else if (type == NODE_TYPE_OPERATOR_UNARY_NOT) { - return ! getMember(0)->isTrue(); + if (getMember(0)->isFalse()) { + // ! false => true + return true; + } } - + return false; } @@ -978,7 +981,10 @@ bool AstNode::isFalse () const { return getMember(1)->isFalse(); } else if (type == NODE_TYPE_OPERATOR_UNARY_NOT) { - return ! getMember(0)->isFalse(); + if (getMember(0)->isTrue()) { + // ! true => false + return true; + } } return false;