Hawkin
/
arangodb
mirror of https://gitee.com/bigwinds/arangodb
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Broken client API and server default was wrong (#3748)

This commit is contained in:
m0ppers 2017-11-21 17:19:14 +01:00 committed by Jan
parent ecb18dfded
commit ce537af092
2 changed files with 32 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
js/client/modules/@arangodb/arango-database.js
View File

@ -357,6 +357,11 @@ ArangoDatabase.prototype._create = function (name, properties, type, options) {
}); });
} }
if (typeof type === 'object') {
options = type;
type = undefined;
}
let urlAddons = []; let urlAddons = [];
if (typeof options === "object" && options !== null) { if (typeof options === "object" && options !== null) {
if (options.hasOwnProperty('waitForSyncReplication')) { if (options.hasOwnProperty('waitForSyncReplication')) {

29
js/common/tests/shell/shell-cluster-collection.js
View File

@ -374,8 +374,7 @@ function ClusterCollectionSuite () {
/// @brief test create /// @brief test create
//////////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////////
testCreateInsufficientDBServers : function () { testCreateInsufficientDBServersDefault : function () {
try { try {
db._create("bigreplication", {replicationFactor: 8}); db._create("bigreplication", {replicationFactor: 8});
fail(); fail();
@ -386,6 +385,32 @@ function ClusterCollectionSuite () {
db._drop('bigreplication'); db._drop('bigreplication');
}, },
////////////////////////////////////////////////////////////////////////////////
/// @brief test create
////////////////////////////////////////////////////////////////////////////////
testCreateInsufficientDBServersIgnoreReplicationFactor : function () {
// should not throw (just a warning)
db._create("bigreplication", {replicationFactor: 8}, {enforceReplicationFactor: false});
db._drop('bigreplication');
},
////////////////////////////////////////////////////////////////////////////////
/// @brief test create
////////////////////////////////////////////////////////////////////////////////
testCreateInsufficientDBServersEnforceReplicationFactor : function () {
try {
db._create("bigreplication", {replicationFactor: 8}, {enforceReplicationFactor: true});
fail();
}
catch (err) {
assertEqual(ERRORS.ERROR_CLUSTER_INSUFFICIENT_DBSERVERS.code, err.errorNum);
}
db._drop('bigreplication');
},
//////////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////////
/// @brief test creation / deleting of documents with replication set /// @brief test creation / deleting of documents with replication set
//////////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////////