From c796b5f93dd1d2a10f49fe227fcfc86f7fddeb76 Mon Sep 17 00:00:00 2001 From: Dan Larkin Date: Fri, 23 Jun 2017 02:44:42 -0400 Subject: [PATCH] Fixed a typo in overcommit ratio warning logic and some formatting. (#2650) --- lib/ApplicationFeatures/EnvironmentFeature.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/ApplicationFeatures/EnvironmentFeature.cpp b/lib/ApplicationFeatures/EnvironmentFeature.cpp index 2d65b999f7..a1e56c2f6f 100644 --- a/lib/ApplicationFeatures/EnvironmentFeature.cpp +++ b/lib/ApplicationFeatures/EnvironmentFeature.cpp @@ -246,13 +246,13 @@ void EnvironmentFeature::start() { ? 100.0 * ((ram - swapSpace) / ram) : 0.0; if (static_cast(r) > 1.05 * rr || - static_cast(r) < 0.95 * r) { + static_cast(r) < 0.95 * rr) { LOG_TOPIC(WARN, Logger::MEMORY) << "/proc/sys/vm/overcommit_ratio is set to '" << r - << "'. It is recommended to set it to " << static_cast(rr) - << " (100 * (max(0, (RAM - Swap Space)) / RAM))."; + << "'. It is recommended to set it to '" << std::llround(rr) + << "' (100 * (max(0, (RAM - Swap Space)) / RAM))."; LOG_TOPIC(WARN, Logger::MEMORY) << "execute 'sudo bash -c \"echo " - << rr << " > " + << std::llround(rr) << " > " << "/proc/sys/vm/overcommit_ratio\"'"; } }