1
0
Fork 0

fix small issues found by codescan (#4241)

This commit is contained in:
Jan 2018-01-16 00:27:42 +01:00 committed by GitHub
parent 653f95f243
commit c69868bde7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 3 deletions

View File

@ -28,6 +28,7 @@
#define VELOCYPACK_BUILDER_H
#include <vector>
#include <string>
#include <cstring>
#include <cstdint>
#include <algorithm>

View File

@ -264,7 +264,7 @@ class RocksDBCollection final : public PhysicalCollection {
void destroyCache() const;
/// is this collection using a cache
inline bool useCache() const { return (_cacheEnabled && _cachePresent); }
inline bool useCache() const noexcept { return (_cacheEnabled && _cachePresent); }
void blackListKey(char const* data, std::size_t len) const;
@ -273,7 +273,6 @@ class RocksDBCollection final : public PhysicalCollection {
std::atomic<uint64_t> _numberDocuments;
std::atomic<TRI_voc_rid_t> _revisionId;
mutable std::atomic<bool> _needToPersistIndexEstimates;
uint64_t _indexesSerializedSeq;
/// upgrade write locks to exclusive locks if this flag is set
bool _hasGeoIndex;

View File

@ -38,7 +38,9 @@ StorageEngine* EngineSelectorFeature::ENGINE = nullptr;
EngineSelectorFeature::EngineSelectorFeature(
application_features::ApplicationServer* server)
: ApplicationFeature(server, "EngineSelector"), _engine("auto") {
: ApplicationFeature(server, "EngineSelector"),
_engine("auto"),
_hasStarted(false) {
setOptional(false);
requiresElevatedPrivileges(false);
startsAfter("DatabasePath");