Hawkin
/
arangodb
mirror of https://gitee.com/bigwinds/arangodb
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

slight wording updates to PR template (#9025)

This commit is contained in:
Simon 2019-05-17 11:37:19 +02:00 committed by Jan
parent 970f732dec
commit c37950135c
1 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
PULL_REQUEST_TEMPLATE.md
View File

@ -18,9 +18,11 @@ and merged into ArangoDB. The overarching goal is to:
*(Can you describe what functional change your PR is trying to effect?)*
- [ ] This is a **Bug-Fix** for a released Version ?
- [ ] Does this create **new functionality** (i.e. a new feature / new option in an existing API) ?
- [ ] Have you *manually tested* the behavior you are affecting in this PR ?
- [ ] Bug-Fix for *devel-branch* (i.e. no need for backports?)
- [ ] Bug-Fix for a *released version* (did you remember to port this to all relevant release branches?)
- [ ] Strictly *new functionality* (i.e. a new feature / new option, no need for porting)
- [ ] The behavior in this PR can be (and was) *manually tested* (support / qa / customers can test it)
- [ ] The behaviour change can only be verified via automatic tests
#### Related Information
@ -43,18 +45,22 @@ This change is already covered by existing tests, such as *(please describe test
*(or)*
This change added tests and can be verified as follows:
This PR adds tests that were used to verify all changes:
- [ ] Added **Regression Tests** (Only for bug-fixes)
- [ ] Added new C++ *Unit Tests* (Either GoogleTest or Catch-Test)
- Did you add tests for a new RestHandler subclass ?
- [ ] Added new C++ **Unit Tests** (Either GoogleTest or Catch-Test)
- Did you add tests for a new *RestHandler* subclass ?
- Did you add new mocks of underlying code layers to be able to verify your functionality ?
- ...
- [ ] Added new *integration tests* (i.e. in shell_server / shell_server_aql)
- [ ] Added new *resilience tests* (only if the feature is impacted by failovers)
- [ ] There are tests in one of the external test repos (i.e. node-resilience tests, chaos tests)
- [ ] Added new **integration tests** (i.e. in shell_server / shell_server_aql)
- [ ] Added new **resilience tests** (only if the feature is impacted by failovers)
Additionally:
- [ ] There are tests in an external testing repository (i.e. node-resilience tests, chaos tests)
- [ ] I ensured this code runs with ASan / TSan or other static verification tools
*(Include link to Jenkins run etc)*
> Think about whether the new code you added is modular enough to be