Hawkin
/
arangodb
mirror of https://gitee.com/bigwinds/arangodb
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix some issues found by cppcheck (#8959)

This commit is contained in:
Jan 2019-05-10 16:31:22 +02:00 committed by GitHub
parent bc4f2ce90a
commit c00442e31c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
arangod/Agency/AgencyComm.cpp
View File

@ -250,7 +250,7 @@ bool AgencyWriteTransaction::validate(AgencyCommResult const& result) const {
} }
std::string AgencyWriteTransaction::randomClientId() { std::string AgencyWriteTransaction::randomClientId() {
std::string uuid = to_string(boost::uuids::random_generator()()), id; std::string uuid = to_string(boost::uuids::random_generator()());
auto ss = ServerState::instance(); auto ss = ServerState::instance();
if (ss != nullptr && !ss->getId().empty()) { if (ss != nullptr && !ss->getId().empty()) {

1
arangod/Agency/Agent.cpp
View File

@ -966,7 +966,6 @@ trans_ret_t Agent::transact(query_t const& queries) {
// own conclusions. The map of ongoing trxs is only to cover the time // own conclusions. The map of ongoing trxs is only to cover the time
// from when we receive the request until we have appended the trxs // from when we receive the request until we have appended the trxs
// ourselves. // ourselves.
ret = std::make_shared<arangodb::velocypack::Builder>();
failed = 0; failed = 0;
ret->openArray(); ret->openArray();
// Only leader else redirect // Only leader else redirect

1
lib/ProgramOptions/IniFileParser.cpp
View File

@ -68,7 +68,6 @@ bool IniFileParser::parse(std::string const& filename, bool endPassAfterwards) {
} catch (arangodb::basics::Exception const& ex) { } catch (arangodb::basics::Exception const& ex) {
return _options->fail(std::string("Couldn't open configuration file: '") + return _options->fail(std::string("Couldn't open configuration file: '") +
filename + "' - " + ex.what()); filename + "' - " + ex.what());
return true;
} }
bool isCommunity = false; bool isCommunity = false;
bool isEnterprise = false; bool isEnterprise = false;