handle compile warnings

arangod/ApplicationServer/ApplicationServer.cpp

@@ -171,11 +171,12 @@ void ApplicationServer::setupLogging(bool threaded, bool daemon,
   Logger::setOutputPrefix(_logPrefix);
   Logger::setShowThreadIdentifier(_logThreadId);
 
-  char const* contentFilter = nullptr;
+// TODO(FC) fixme
+//  char const* contentFilter = nullptr;
 
-  if (_options.has("log.content-filter")) {
-    contentFilter = _logContentFilter.c_str();
-  }
+//  if (_options.has("log.content-filter")) {
+//    contentFilter = _logContentFilter.c_str();
+//  }
 
   std::vector<std::string> levels;
   std::vector<std::string> outputs;

arangod/RestHandler/RestAdminLogHandler.cpp

@@ -167,7 +167,7 @@ HttpHandler::status_t RestAdminLogHandler::execute() {
 
     if (offset < 0) {
       offset = 0;
-    } else if (offset >= length) {
+    } else if (offset >= static_cast<int64_t>(length)) {
       length = 0;
       offset = 0;
     } else if (offset > 0) {

lib/Basics/Logger.cpp

@@ -120,7 +120,7 @@ struct LogMessage {
 
 class LogAppender {
  public:
-  LogAppender(std::string const& filter) : _filter(filter) {}
+  explicit LogAppender(std::string const& filter) : _filter(filter) {}
   virtual ~LogAppender() {}
 
   virtual void logMessage(LogLevel, std::string const& message,
@@ -641,7 +641,7 @@ static void QueueMessage(char const* function, char const* file, long int line,
 
 class LogThread : public Thread {
  public:
-  LogThread(std::string const& name) : Thread(name) {}
+  explicit LogThread(std::string const& name) : Thread(name) {}
 
  public:
   void run();

lib/Basics/Logger.h

@@ -64,7 +64,7 @@
 #include <iosfwd>
 #include <sstream>
 
-bool TRI_ShutdownLogging(bool);  // TODO(fc) remove
+static inline bool TRI_ShutdownLogging(bool) { return true; }  // TODO(fc) remove
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief maximal number of log topics