1
0
Fork 0

remove unused options

This commit is contained in:
jsteemann 2017-05-12 12:12:09 +02:00
parent b848030818
commit b1aae2efdd
5 changed files with 0 additions and 46 deletions

View File

@ -111,28 +111,10 @@ The number of bits used to shard the block cache to allow concurrent operations.
To keep individual shards at a reasonable size (i.e. at least 512KB), keep this
value to at most `block-cache-shard-bits / 512KB`. Default: 4.
### Logging
`--rocksdb.max-log-file-size` (Hidden)
Specify the maximal size of the info log file. When the file size is reached, a
new file will be created. If set to 0, everything will be written to one file.
Default: 0.
`--rocksdb.keep-log-file-num` (Hidden)
The maximum number of info log files to be kept. Default: 1000.
`--rocksdb.recycle-log-file-num` (Hidden)
Number of log files to keep around for recycling. Default: 0.
`--rocksdb.log-file-time-to-roll` (Hidden)
Time for the info log file to roll (in seconds). If specified with non-zero
value, log file will be rolled if it has been active longer than
`log_file_time_to_roll`. Set to 0 to disable. Default: 0.
### Miscellaneous
`--rocksdb.verify-checksums-in-compaction` (Hidden)

View File

@ -124,9 +124,6 @@ void MMFilesPersistentIndexFeature::start() {
_options.base_background_compactions = static_cast<int>(opts->_baseBackgroundCompactions);
_options.max_background_compactions = static_cast<int>(opts->_maxBackgroundCompactions);
_options.max_log_file_size = static_cast<size_t>(opts->_maxLogFileSize);
_options.keep_log_file_num = static_cast<size_t>(opts->_keepLogFileNum);
_options.log_file_time_to_roll = static_cast<size_t>(opts->_logFileTimeToRoll);
_options.compaction_readahead_size = static_cast<size_t>(opts->_compactionReadaheadSize);
if (_options.base_background_compactions > 1 || _options.max_background_compactions > 1) {

View File

@ -209,11 +209,7 @@ void RocksDBEngine::start() {
_options.max_background_flushes = static_cast<int>(opts->_maxFlushes);
_options.use_fsync = opts->_useFSync;
_options.max_log_file_size = static_cast<size_t>(opts->_maxLogFileSize);
_options.keep_log_file_num = static_cast<size_t>(opts->_keepLogFileNum);
_options.recycle_log_file_num = static_cast<size_t>(opts->_recycleLogFileNum);
_options.log_file_time_to_roll =
static_cast<size_t>(opts->_logFileTimeToRoll);
_options.compaction_readahead_size =
static_cast<size_t>(opts->_compactionReadaheadSize);

View File

@ -61,10 +61,7 @@ RocksDBOptionFeature::RocksDBOptionFeature(
_numThreadsLow(rocksDBDefaults.max_background_compactions),
_blockCacheSize(8 * 1024 * 1024),
_blockCacheShardBits(4),
_maxLogFileSize(rocksDBDefaults.max_log_file_size),
_keepLogFileNum(rocksDBDefaults.keep_log_file_num),
_recycleLogFileNum(rocksDBDefaults.recycle_log_file_num),
_logFileTimeToRoll(rocksDBDefaults.log_file_time_to_roll),
_compactionReadaheadSize(rocksDBDefaults.compaction_readahead_size),
_verifyChecksumsInCompaction(
rocksDBDefaults.verify_checksums_in_compaction),
@ -193,25 +190,10 @@ void RocksDBOptionFeature::collectOptions(
"number of shard bits to use for block cache",
new UInt64Parameter(&_blockCacheShardBits));
options->addHiddenOption("--rocksdb.max-log-file-size",
"specify the maximal size of the info log file",
new UInt64Parameter(&_maxLogFileSize));
options->addHiddenOption("--rocksdb.keep-log-file-num",
"maximal info log files to be kept",
new UInt64Parameter(&_keepLogFileNum));
options->addHiddenOption("--rocksdb.recycle-log-file-num",
"number of log files to keep around for recycling",
new UInt64Parameter(&_recycleLogFileNum));
options->addHiddenOption(
"--rocksdb.log-file-time-to-roll",
"time for the info log file to roll (in seconds). "
"If specified with non-zero value, log file will be rolled "
"if it has been active longer than `log_file_time_to_roll`",
new UInt64Parameter(&_logFileTimeToRoll));
options->addHiddenOption(
"--rocksdb.compaction-read-ahead-size",
"if non-zero, we perform bigger reads when doing compaction. If you're "

View File

@ -61,10 +61,7 @@ class RocksDBOptionFeature final
uint64_t _numThreadsLow;
uint64_t _blockCacheSize;
uint64_t _blockCacheShardBits;
uint64_t _maxLogFileSize;
uint64_t _keepLogFileNum;
uint64_t _recycleLogFileNum;
uint64_t _logFileTimeToRoll;
uint64_t _compactionReadaheadSize;
bool _verifyChecksumsInCompaction;
bool _optimizeFiltersForHits;