Hawkin
/
arangodb
mirror of https://gitee.com/bigwinds/arangodb
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

minor patches

This commit is contained in:
Jan Steemann 2015-10-30 15:12:41 +01:00 committed by Frank Celler
parent c88ab6b49c
commit afdcc68e51
2 changed files with 24 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
arangod/Aql/Functions.cpp
View File

@ -2917,19 +2917,23 @@ AqlValue Functions::Edges (triagens::aql::Query* query,
if (exampleJson.isArray()) {
size_t exampleCount = exampleJson.size();
// We only support objects here so validate
for (size_t k = 0; k < exampleCount; ++k) {
if (! exampleJson.at(k).isObject()) {
RegisterWarning(query, "EDGES", TRI_ERROR_QUERY_FUNCTION_ARGUMENT_TYPE_MISMATCH);
if (TRI_DeleteArrayJson(TRI_UNKNOWN_MEM_ZONE, exampleJson.json(), k)) {
--k;
--exampleCount;
}
else {
// Should never occur.
// If it occurs in production it will simply fall through
// it can only retern more results than expected and not do any harm.
TRI_ASSERT(false);
}
for (size_t k = 0; k < exampleCount; /* nothing */) {
if (exampleJson.at(k).isObject()) {
++k;
continue;
}
RegisterWarning(query, "EDGES", TRI_ERROR_QUERY_FUNCTION_ARGUMENT_TYPE_MISMATCH);
if (TRI_DeleteArrayJson(TRI_UNKNOWN_MEM_ZONE, exampleJson.json(), k)) {
// don't modify count
--exampleCount;
}
else {
// Should never occur.
// If it occurs in production it will simply fall through
// it can only return more results than expected and not do any harm.
TRI_ASSERT(false);
++k;
}
}
if (exampleCount > 0) {
@ -2946,17 +2950,19 @@ AqlValue Functions::Edges (triagens::aql::Query* query,
if (buildMatcher) {
try {
triagens::arango::ExampleMatcher matcher(exampleJson.json(), shaper, resolver);
for (size_t i = 0; i < resultCount; ++i) {
for (size_t i = 0; i < resultCount; /* nothing */) {
if (! matcher.matches(cid, &edges[i])) {
edges.erase(edges.begin() + i);
--i;
--resultCount;
}
else {
++i;
}
}
}
catch (triagens::basics::Exception& e) {
catch (triagens::basics::Exception const& e) {
if (e.code() != TRI_RESULT_ELEMENT_NOT_FOUND) {
throw e;
throw;
}
// Illegal match, we cannot filter anything
edges.clear();

3
arangod/Utils/Transaction.cpp
View File

@ -86,8 +86,6 @@ int Transaction::readIncremental (TRI_transaction_collection_t* trxCollection,
return TRI_ERROR_OUT_OF_MEMORY;
}
uint64_t count = 0;
try {
if (batchSize > 2048) {
docs.reserve(2048);
@ -97,6 +95,7 @@ int Transaction::readIncremental (TRI_transaction_collection_t* trxCollection,
}
auto primaryIndex = document->primaryIndex();
uint64_t count = 0;
while (count < batchSize || skip > 0) {
TRI_doc_mptr_t const* mptr = primaryIndex->lookupSequential(internalSkip, total);