Merge branch 'devel' of https://github.com/arangodb/arangodb into devel

3rdParty/zlib/zlib-1.2.8/CMakeLists.txt

@@ -212,9 +212,9 @@ if(UNIX)
     # On unix-like platforms the library is almost always called libz
     #set_target_properties(zlib zlibstatic PROPERTIES OUTPUT_NAME z)
     set_target_properties(zlibstatic PROPERTIES OUTPUT_NAME z)
-    if(NOT APPLE AND NOT SOLARIS)
-      set_target_properties(zlib PROPERTIES LINK_FLAGS "-Wl,--version-script,\"${CMAKE_CURRENT_SOURCE_DIR}/zlib.map\"")
-    endif()
+    # if(NOT APPLE AND NOT SOLARIS)
+    #   set_target_properties(zlib PROPERTIES LINK_FLAGS "-Wl,--version-script,\"${CMAKE_CURRENT_SOURCE_DIR}/zlib.map\"")
+    # endif()
   elseif(BUILD_SHARED_LIBS AND WIN32)
     # Creates zlib1.dll when building shared library version
     set_target_properties(zlib PROPERTIES SUFFIX "1.dll")

lib/ApplicationFeatures/ApplicationServer.cpp

@@ -35,10 +35,7 @@ using namespace arangodb::options;
 ApplicationServer* ApplicationServer::server = nullptr;
 
 ApplicationServer::ApplicationServer(std::shared_ptr<ProgramOptions> options)
-    : _options(options),
-      _stopping(false),
-      _privilegesDropped(false),
-      _dumpDependencies(false) {
+    : _options(options), _stopping(false) {
   if (ApplicationServer::server != nullptr) {
     LOG(ERR) << "ApplicationServer initialized twice";
   }
@@ -155,6 +152,7 @@ void ApplicationServer::run(int argc, char* argv[]) {
 
   // collect options from all features
   // in this phase, all features are order-independent
+  _state = ServerState::IN_COLLECT_OPTIONS;
   collectOptions();
 
   // setup dependency, but ignore any failure for now
@@ -168,6 +166,7 @@ void ApplicationServer::run(int argc, char* argv[]) {
   _options->seal();
 
   // validate options of all features
+  _state = ServerState::IN_VALIDATE_OPTIONS;
   validateOptions();
 
   // enable automatic features
@@ -184,6 +183,7 @@ void ApplicationServer::run(int argc, char* argv[]) {
   // furthermore, they must not write any files under elevated privileges
   // if they want other features to access them, or if they want to access
   // these files with dropped privileges
+  _state = ServerState::IN_PREPARE;
   prepare();
 
   // permanently drop the privileges
@@ -193,13 +193,18 @@ void ApplicationServer::run(int argc, char* argv[]) {
   Thread::allowThreadCreation();
 
   // start features. now features are allowed to start threads, write files etc.
+  _state = ServerState::IN_START;
   start();
 
   // wait until we get signaled the shutdown request
   wait();
 
   // stop all features
+  _state = ServerState::IN_STOP;
   stop();
+
+  // stopped
+  _state = ServerState::STOPPED;
 }
 
 // signal the server to shut down

lib/ApplicationFeatures/ApplicationServer.h

@@ -91,10 +91,15 @@ class ApplicationServer {
   ApplicationServer& operator=(ApplicationServer const&) = delete;
 
  public:
-  static ApplicationServer* server;
-  static bool isStopping() {
-    return server != nullptr && server->_stopping.load();
-  }
+  enum class ServerState {
+    UNINITIALIZED,
+    IN_COLLECT_OPTIONS,
+    IN_VALIDATE_OPTIONS,
+    IN_PREPARE,
+    IN_START,
+    IN_STOP,
+    STOPPED
+  };
 
   enum class FeatureState {
     UNINITIALIZED,
@@ -105,6 +110,15 @@ class ApplicationServer {
     STOPPED
   };
 
+  static ApplicationServer* server;
+  static bool isStopping() {
+    return server != nullptr && server->_stopping.load();
+  }
+  static bool isPrepared() {
+    return server != nullptr && (server->_state == ServerState::IN_START ||
+                                 server->_state == ServerState::IN_STOP);
+  }
+
   // returns the feature with the given name if known
   // throws otherwise
   template <typename T>
@@ -172,6 +186,9 @@ class ApplicationServer {
   // return VPack options
   VPackBuilder options(std::unordered_set<std::string> const& excludes) const;
 
+  // return the server state
+  ServerState state() const { return _state; }
+
  private:
   // look up a feature and return a pointer to it. may be nullptr
   static ApplicationFeature* lookupFeature(std::string const&);
@@ -228,6 +245,9 @@ class ApplicationServer {
   void dropPrivilegesPermanently();
 
  private:
+  // the current state
+  ServerState _state = ServerState::UNINITIALIZED;
+
   // the shared program options
   std::shared_ptr<options::ProgramOptions> _options;
 
@@ -241,10 +261,10 @@ class ApplicationServer {
   std::atomic<bool> _stopping;
 
   // whether or not privileges have been dropped permanently
-  bool _privilegesDropped;
+  bool _privilegesDropped = false;
 
   // whether or not to dump dependencies
-  bool _dumpDependencies;
+  bool _dumpDependencies = false;
 };
 }
 }

lib/Basics/Thread.cpp

@@ -27,6 +27,7 @@
 #include <errno.h>
 #include <signal.h>
 
+#include "ApplicationFeatures/ApplicationServer.h"
 #include "Basics/ConditionLocker.h"
 #include "Basics/Exceptions.h"
 #include "Logger/Logger.h"
@@ -36,6 +37,7 @@
 #include <velocypack/velocypack-aliases.h>
 
 using namespace arangodb;
+using namespace arangodb::application_features;
 using namespace arangodb::basics;
 
 ////////////////////////////////////////////////////////////////////////////////
@@ -282,6 +284,15 @@ bool Thread::isStopping() const {
 ////////////////////////////////////////////////////////////////////////////////
 
 bool Thread::start(ConditionVariable* finishedCondition) {
+  if (!isSystem() && ! ApplicationServer::isPrepared()) {
+    LOG(FATAL) << "trying to start a thread '" << _name
+               << "' before prepare has finished, current state: "
+               << (ApplicationServer::server == nullptr
+                       ? -1
+                       : (int)ApplicationServer::server->state());
+    FATAL_ERROR_EXIT();
+  }
+
   _finishedCondition = finishedCondition;
 
   if (_state.load() != ThreadState::CREATED) {

lib/Basics/Thread.h

@@ -148,6 +148,9 @@ class Thread {
   virtual ~Thread();
 
  public:
+  // whether or not the thread is allowed to start during prepare
+  virtual bool isSystem() { return false; }
+
   //////////////////////////////////////////////////////////////////////////////
   /// @brief whether or not the thread is chatty on shutdown
   //////////////////////////////////////////////////////////////////////////////

lib/Logger/LogThread.h

@@ -41,6 +41,7 @@ class LogThread : public Thread {
   ~LogThread();
 
  public:
+  bool isSystem() override { return true; }
   bool isSilent() override { return true; }
   void run() override;
 

lib/Logger/LoggerFeature.cpp

@@ -91,7 +91,8 @@ void LoggerFeature::collectOptions(std::shared_ptr<ProgramOptions> options) {
                            "append line number and file name",
                            new BooleanParameter(&_lineNumber));
 
-  options->addHiddenOption("--log.thread", "show thread identifier in log message",
+  options->addHiddenOption("--log.thread",
+                           "show thread identifier in log message",
                            new BooleanParameter(&_thread));
 
   options->addHiddenOption("--log.performance",
@@ -170,9 +171,6 @@ void LoggerFeature::prepare() {
   }
 }
 
-void LoggerFeature::start() {
-}
-
 void LoggerFeature::stop() {
   Logger::flush();
   Logger::shutdown(true);

lib/Logger/LoggerFeature.h

@@ -35,7 +35,6 @@ class LoggerFeature final : public application_features::ApplicationFeature {
   void loadOptions(std::shared_ptr<options::ProgramOptions>) override final;
   void validateOptions(std::shared_ptr<options::ProgramOptions>) override final;
   void prepare() override final;
-  void start() override final;
   void stop() override final;
 
  public: