Added some small fixes

arangod/MMFiles/MMFilesHashIndex.cpp

@@ -433,7 +433,7 @@ MMFilesHashIndex::MultiArray::~MultiArray() {
 MMFilesHashIndex::MMFilesHashIndex(TRI_idx_iid_t iid, LogicalCollection* collection,
                      VPackSlice const& info)
     : MMFilesPathBasedIndex(iid, collection, info, sizeof(TRI_voc_rid_t) + sizeof(uint32_t), false), _uniqueArray(nullptr) {
-  uint32_t indexBuckets = 1;
+  size_t indexBuckets = 1;
 
   if (collection != nullptr) {
     auto physical = static_cast<MMFilesCollection*>(collection->getPhysical());

arangod/RocksDBEngine/RocksDBCollection.cpp

@@ -310,7 +310,7 @@ int RocksDBCollection::restoreIndex(transaction::Methods*,
 /// @brief Drop an index with the given iid.
 bool RocksDBCollection::dropIndex(TRI_idx_iid_t iid) {
   THROW_ARANGO_NOT_YET_IMPLEMENTED();
-  return false;
+  return true;
 }
 
 std::unique_ptr<IndexIterator> RocksDBCollection::getAllIterator(
@@ -733,7 +733,7 @@ int RocksDBCollection::saveIndex(transaction::Methods* trx,
 // or it's indexes are freed the pointer returned will get invalidated.
 arangodb::RocksDBPrimaryIndex* RocksDBCollection::primaryIndex() const {
   // The primary index always has iid 0
-  auto primary = _logicalCollection->lookupIndex(0);
+  auto primary = PhysicalCollection::lookupIndex(0);
   TRI_ASSERT(primary != nullptr);
 
 #ifdef ARANGODB_ENABLE_MAINTAINER_MODE

arangod/RocksDBEngine/RocksDBCommon.h

@@ -30,7 +30,7 @@
 
 #include <rocksdb/status.h>
 
-namespace rocksdb {class DB; class ReadOptions;}
+namespace rocksdb {class DB; struct ReadOptions;}
 
 namespace arangodb {
 class TransactionState;

arangod/RocksDBEngine/RocksDBEngine.cpp

@@ -520,7 +520,8 @@ void RocksDBEngine::dropIndexWalMarker(TRI_vocbase_t* vocbase,
 
 void RocksDBEngine::unloadCollection(TRI_vocbase_t* vocbase,
                                      arangodb::LogicalCollection* collection) {
-  THROW_ARANGO_NOT_YET_IMPLEMENTED();
+  // TODO: does anything have to happen
+  //THROW_ARANGO_NOT_YET_IMPLEMENTED();
 }
 
 void RocksDBEngine::createView(TRI_vocbase_t* vocbase, TRI_voc_cid_t id,

arangod/RocksDBEngine/RocksDBPrimaryIndex.cpp

@@ -110,7 +110,6 @@ RocksDBAllIndexIterator::RocksDBAllIndexIterator(
     : IndexIterator(collection, trx, mmdr, index),
       _cmp(index->_cmp),
       _reverse(reverse),
-      _total(0),
       _bounds(RocksDBKeyBounds::PrimaryIndex(index->objectId())) {
   // aquire rocksdb transaction
   RocksDBTransactionState* state = rocksutils::toRocksTransactionState(trx);

arangod/RocksDBEngine/RocksDBPrimaryIndex.h

@@ -90,7 +90,6 @@ class RocksDBAllIndexIterator final : public IndexIterator {
 
   RocksDBComparator const* _cmp;
   bool const _reverse;
-  uint64_t _total;
   std::unique_ptr<rocksdb::Iterator> _iterator;
   RocksDBKeyBounds _bounds;
 };