1
0
Fork 0

disable enforce-block-cache-size-limit for now (#9270)

This commit is contained in:
Frank Celler 2019-08-12 09:42:32 +02:00 committed by GitHub
parent 8b5b1677a4
commit 7a197b49e6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 1 deletions

View File

@ -1,3 +1,8 @@
v3.3.25 (2019-XX-XX)
--------------------
* disabled enforce-block-cache-size-limit because of bugs in RocksDB 5.6
v3.3.24 (2019-08-09)
--------------------

View File

@ -255,7 +255,7 @@ void RocksDBOptionFeature::collectOptions(std::shared_ptr<ProgramOptions> option
new Int64Parameter(&_blockCacheShardBits));
options->addOption("--rocksdb.enforce-block-cache-size-limit",
"if true, strictly enforces the block cache size limit",
"if true, strictly enforces the block cache size limit (not supported)",
new BooleanParameter(&_enforceBlockCacheSizeLimit));
options->addOption(
@ -331,6 +331,9 @@ void RocksDBOptionFeature::validateOptions(std::shared_ptr<ProgramOptions> optio
<< "invalid value for '--rocksdb.block-cache-shard-bits'";
FATAL_ERROR_EXIT();
}
// currently disable because this can cause an error in RocksDB 5.6
_enforceBlockCacheSizeLimit = false;
}
void RocksDBOptionFeature::start() {