From 79e145546bfa3261f63d626f3aee17a8a825a9dd Mon Sep 17 00:00:00 2001 From: Jan Date: Tue, 12 Nov 2019 10:43:25 +0100 Subject: [PATCH] Something about `--agency.supervision-grace-period` (#10395) --- arangod/Agency/AgencyFeature.cpp | 8 ++++---- scripts/startLeaderFollower.sh | 1 - scripts/startLocalCluster.sh | 2 -- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/arangod/Agency/AgencyFeature.cpp b/arangod/Agency/AgencyFeature.cpp index 7064839a27..02996358a2 100644 --- a/arangod/Agency/AgencyFeature.cpp +++ b/arangod/Agency/AgencyFeature.cpp @@ -88,12 +88,12 @@ void AgencyFeature::collectOptions(std::shared_ptr options) { options->addOption( "--agency.election-timeout-min", - "minimum timeout before an agent calls for new election [s]", + "minimum timeout before an agent calls for new election (in seconds)", new DoubleParameter(&_minElectionTimeout)); options->addOption( "--agency.election-timeout-max", - "maximum timeout before an agent calls for new election [s]", + "maximum timeout before an agent calls for new election (in seconds)", new DoubleParameter(&_maxElectionTimeout)); options->addOption("--agency.endpoint", "agency endpoints", @@ -108,12 +108,12 @@ void AgencyFeature::collectOptions(std::shared_ptr options) { new BooleanParameter(&_supervision)); options->addOption("--agency.supervision-frequency", - "arangodb cluster supervision frequency [s]", + "arangodb cluster supervision frequency (in seconds)", new DoubleParameter(&_supervisionFrequency)); options->addOption( "--agency.supervision-grace-period", - "supervision time, after which a server is considered to have failed [s]", + "supervision time, after which a server is considered to have failed (in seconds)", new DoubleParameter(&_supervisionGracePeriod)); options->addOption("--agency.compaction-step-size", diff --git a/scripts/startLeaderFollower.sh b/scripts/startLeaderFollower.sh index 63856d4783..3f892e95af 100755 --- a/scripts/startLeaderFollower.sh +++ b/scripts/startLeaderFollower.sh @@ -142,7 +142,6 @@ for aid in `seq 0 $(( $NRAGENTS - 1 ))`; do --agency.size $NRAGENTS \ --agency.supervision true \ --agency.supervision-frequency $SFRE \ - --agency.supervision-grace-period 5.0 \ --agency.wait-for-sync false \ --database.directory active/data$PORT \ --javascript.enabled false \ diff --git a/scripts/startLocalCluster.sh b/scripts/startLocalCluster.sh index b9038ae85d..1a01e3fdce 100755 --- a/scripts/startLocalCluster.sh +++ b/scripts/startLocalCluster.sh @@ -156,7 +156,6 @@ for aid in `seq 0 $(( $NRAGENTS - 1 ))`; do --agency.size $NRAGENTS \ --agency.supervision true \ --agency.supervision-frequency $SFRE \ - --agency.supervision-grace-period 5.0 \ --agency.wait-for-sync false \ --database.directory cluster/data$PORT \ --javascript.enabled false \ @@ -184,7 +183,6 @@ for aid in `seq 0 $(( $NRAGENTS - 1 ))`; do --agency.size $NRAGENTS \ --agency.supervision true \ --agency.supervision-frequency $SFRE \ - --agency.supervision-grace-period 5.0 \ --agency.wait-for-sync false \ --database.directory cluster/data$PORT \ --javascript.enabled false \