From 61f799ecf0ca48d7fc35c0f294e25e73e9eb48e3 Mon Sep 17 00:00:00 2001 From: Jan Steemann Date: Tue, 16 Dec 2014 15:37:15 +0100 Subject: [PATCH] satisfy jslint --- .../frontend/js/collections/foxxCollection.js | 1 - .../frontend/js/views/applicationsView.js | 19 ++++++++++--------- .../modules/org/arangodb/foxx/manager.js | 2 -- 3 files changed, 10 insertions(+), 12 deletions(-) diff --git a/js/apps/system/aardvark/frontend/js/collections/foxxCollection.js b/js/apps/system/aardvark/frontend/js/collections/foxxCollection.js index b93988a14e..8417e9a341 100644 --- a/js/apps/system/aardvark/frontend/js/collections/foxxCollection.js +++ b/js/apps/system/aardvark/frontend/js/collections/foxxCollection.js @@ -48,7 +48,6 @@ result = data; }, error: function(data) { - console.log(data); result = { error: true }; diff --git a/js/apps/system/aardvark/frontend/js/views/applicationsView.js b/js/apps/system/aardvark/frontend/js/views/applicationsView.js index be47d88486..43cf63738d 100644 --- a/js/apps/system/aardvark/frontend/js/views/applicationsView.js +++ b/js/apps/system/aardvark/frontend/js/views/applicationsView.js @@ -1,6 +1,6 @@ /*jshint browser: true */ /*jshint strict: false, unused: false */ -/*global Backbone, $, window, arangoHelper, templateEngine, Joi, _*/ +/*global Backbone, $, window, arangoHelper, templateEngine, Joi, alert, _*/ (function() { "use strict"; @@ -73,11 +73,11 @@ [ { rule: Joi.string().regex(/^[a-zA-Z0-9]+[\/]/), - msg: "No valid github link given." + msg: "No valid Github link given." }, { rule: Joi.string().required(), - msg: "No github link given." + msg: "No Github link given." } ] )); @@ -445,7 +445,7 @@ } else { switch(result.errorNum) { case 1752: - alert("Unable to download Application from the given repository"); + alert("Unable to download application from the given repository"); break; default: alert("Error: " + result.errorNum + ". " + result.errorMessage); @@ -462,7 +462,7 @@ "mount-point", "Mount", "", - "The path the App will be mounted. Has to start with /. Is not allowed to start with /_", + "The path the app will be mounted. Has to start with /. Is not allowed to start with /_", "/my/app", true, //TODO nochmal schauen @@ -502,6 +502,7 @@ rule: Joi.number().integer(), msg: "Has to be an integer." }]; + /* falls through */ default: if (check === undefined) { check = [{ @@ -530,7 +531,7 @@ window.modalView.createSuccessButton("Configure", this.mountFoxx.bind(this, config, name, version)) ); window.modalView.show( - "modalTable.ejs", "Configure Application", buttons, tableContent + "modalTable.ejs", "Configure application", buttons, tableContent ); }, @@ -598,7 +599,7 @@ }, error: function(e, info) { if (info.responseText.indexOf("already used by") > -1) { - alert("Mount-Path already in use."); + alert("Mount path already in use."); } else if (info.responseText.indexOf("app is not defined") > -1) { //temp ignore this message, fix needs to be server-side window.modalView.hide(); @@ -624,7 +625,7 @@ ]; window.modalView.show( "modalDownloadFoxx.ejs", - "Download Application", + "Download application", buttons ); }, @@ -720,7 +721,7 @@ ); window.modalView.show( "modalApplicationMount.ejs", - "Install Application", + "Install application", buttons, undefined, undefined, diff --git a/js/server/modules/org/arangodb/foxx/manager.js b/js/server/modules/org/arangodb/foxx/manager.js index d2873f1960..e082379d59 100644 --- a/js/server/modules/org/arangodb/foxx/manager.js +++ b/js/server/modules/org/arangodb/foxx/manager.js @@ -29,8 +29,6 @@ //////////////////////////////////////////////////////////////////////////////// var arangodb = require("org/arangodb"); -var ArangoError = arangodb.ArangoError; - var console = require("console"); var fs = require("fs"); var utils = require("org/arangodb/foxx/manager-utils");