ascii art (#9565)

arangod/Agency/AgencyComm.h

@@ -401,7 +401,7 @@ struct AgencyWriteTransaction : public AgencyTransaction {
               std::back_inserter(preconditions));
   }
 
-  AgencyWriteTransaction() : clientId(randomClientId()) {};
+  AgencyWriteTransaction() : clientId(randomClientId()) {}
 
   void toVelocyPack(arangodb::velocypack::Builder& builder) const override final;
 

arangod/Agency/AgentInterface.h

@@ -37,7 +37,7 @@ class AgentInterface {
     bool _discardStartup;
     bool _privileged;
     WriteMode(bool d = false, bool p = false)
-        : _discardStartup(d), _privileged(p){};
+        : _discardStartup(d), _privileged(p) {}
     bool privileged() const { return _privileged; }
     bool discardStartup() const { return _discardStartup; }
   };

arangod/Aql/EnumerateListExecutor.cpp

@@ -58,7 +58,7 @@ EnumerateListExecutor::EnumerateListExecutor(Fetcher& fetcher, EnumerateListExec
       _currentRow{CreateInvalidInputRowHint{}},
       _rowState(ExecutionState::HASMORE),
       _inputArrayPosition(0),
-      _inputArrayLength(0){};
+      _inputArrayLength(0) {}
 
 std::pair<ExecutionState, NoStats> EnumerateListExecutor::produceRows(OutputAqlItemRow& output) {
   while (true) {

arangod/Aql/IdExecutor.cpp

@@ -43,7 +43,7 @@ IdExecutorInfos::IdExecutorInfos(RegisterId nrInOutRegisters,
 
 template <class UsedFetcher>
 IdExecutor<UsedFetcher>::IdExecutor(Fetcher& fetcher, IdExecutorInfos& infos)
-    : _fetcher(fetcher){};
+    : _fetcher(fetcher) {}
 
 template <class UsedFetcher>
 IdExecutor<UsedFetcher>::~IdExecutor() = default;

arangod/Aql/ReturnExecutor.cpp

@@ -42,6 +42,6 @@ ReturnExecutorInfos::ReturnExecutorInfos(RegisterId inputRegister, RegisterId nr
       _doCount(doCount) {}
 
 ReturnExecutor::ReturnExecutor(Fetcher& fetcher, ReturnExecutorInfos& infos)
-    : _infos(infos), _fetcher(fetcher){};
+    : _infos(infos), _fetcher(fetcher) {}
 
 ReturnExecutor::~ReturnExecutor() = default;

arangod/Aql/SortExecutor.cpp

@@ -109,7 +109,7 @@ std::vector<SortRegister>& SortExecutorInfos::sortRegisters() {
 bool SortExecutorInfos::stable() const { return _stable; }
 
 SortExecutor::SortExecutor(Fetcher& fetcher, SortExecutorInfos& infos)
-    : _infos(infos), _fetcher(fetcher), _input(nullptr), _returnNext(0){};
+    : _infos(infos), _fetcher(fetcher), _input(nullptr), _returnNext(0) {}
 SortExecutor::~SortExecutor() = default;
 
 std::pair<ExecutionState, NoStats> SortExecutor::produceRows(OutputAqlItemRow& output) {

arangod/Cluster/ClusterComm.cpp

@@ -605,8 +605,8 @@ std::unique_ptr<ClusterCommResult> ClusterComm::syncRequest(
     std::atomic<bool> wasSignaled;
 
     SharedVariables() = delete;
-    SharedVariables(ClusterCommResult * preparedResult)
-      : result(preparedResult), wasSignaled(false) {};
+    explicit SharedVariables(ClusterCommResult* preparedResult)
+      : result(preparedResult), wasSignaled(false) {}
   };
 
   // this shared_ptr is not atomic (until c++20), careful

arangod/Cluster/ClusterRepairOperations.cpp

@@ -251,7 +251,7 @@ class StreamRepairOperationVisitor : public boost::static_visitor<std::ostream&>
   StreamRepairOperationVisitor() = delete;
 
   explicit StreamRepairOperationVisitor(std::ostream& stream_)
-      : _stream(stream_){};
+      : _stream(stream_) {}
 
   std::ostream& operator()(BeginRepairsOperation const& op) {
     return _stream << op;

arangod/Cluster/CreateDatabase.cpp

@@ -55,7 +55,7 @@ CreateDatabase::CreateDatabase(MaintenanceFeature& feature, ActionDescription co
   }
 }
 
-CreateDatabase::~CreateDatabase(){};
+CreateDatabase::~CreateDatabase() {}
 
 bool CreateDatabase::first() {
   VPackSlice users;

arangod/Cluster/DropCollection.cpp

@@ -60,7 +60,7 @@ DropCollection::DropCollection(MaintenanceFeature& feature, ActionDescription co
   }
 }
 
-DropCollection::~DropCollection(){};
+DropCollection::~DropCollection() {}
 
 bool DropCollection::first() {
   auto const& database = _description.get(DATABASE);

arangod/Cluster/DropDatabase.cpp

@@ -53,7 +53,7 @@ DropDatabase::DropDatabase(MaintenanceFeature& feature, ActionDescription const&
   }
 }
 
-DropDatabase::~DropDatabase(){};
+DropDatabase::~DropDatabase() {}
 
 bool DropDatabase::first() {
   std::string const database = _description.get(DATABASE);

arangod/Cluster/DropIndex.cpp

@@ -63,7 +63,7 @@ DropIndex::DropIndex(MaintenanceFeature& feature, ActionDescription const& d)
   }
 }
 
-DropIndex::~DropIndex(){};
+DropIndex::~DropIndex() {}
 
 bool DropIndex::first() {
   auto const& database = _description.get(DATABASE);

arangod/Cluster/MaintenanceFeature.h

@@ -82,7 +82,7 @@ class MaintenanceFeature : public application_features::ApplicationFeature {
   virtual void stop() override;
 
   // shut down the feature
-  virtual void unprepare() override{};
+  virtual void unprepare() override {}
 
   //
   // api features

arangod/Cluster/ResignShardLeadership.cpp

@@ -72,7 +72,7 @@ ResignShardLeadership::ResignShardLeadership(MaintenanceFeature& feature,
   }
 }
 
-ResignShardLeadership::~ResignShardLeadership(){};
+ResignShardLeadership::~ResignShardLeadership() {}
 
 bool ResignShardLeadership::first() {
   std::string const& database = _description.get(DATABASE);

arangod/Cluster/SynchronizeShard.cpp

@@ -123,7 +123,7 @@ SynchronizeShard::~SynchronizeShard() {}
 
 class SynchronizeShardCallback : public arangodb::ClusterCommCallback {
  public:
-  explicit SynchronizeShardCallback(SynchronizeShard* callie){};
+  explicit SynchronizeShardCallback(SynchronizeShard* callee) {}
   virtual bool operator()(arangodb::ClusterCommResult*) override final {
     return true;
   }

arangod/Cluster/UpdateCollection.cpp

@@ -143,7 +143,7 @@ void handleLeadership(LogicalCollection& collection, std::string const& localLea
   }
 }
 
-UpdateCollection::~UpdateCollection(){};
+UpdateCollection::~UpdateCollection() {}
 
 bool UpdateCollection::first() {
   auto const& database = _description.get(DATABASE);

arangod/Graph/GraphCache.cpp

@@ -55,7 +55,7 @@ struct Success {
   std::shared_ptr<Graph const> graph;
 
   explicit Success(std::shared_ptr<Graph const> graph_)
-      : graph(std::move(graph_)){};
+      : graph(std::move(graph_)) {}
   Success& operator=(Success const& other) = default;
   Success() = delete;
 };

arangod/Graph/GraphManager.h

@@ -62,7 +62,7 @@ class GraphManager {
 
  public:
   explicit GraphManager(TRI_vocbase_t& vocbase)
-      : GraphManager(vocbase, false){};
+      : GraphManager(vocbase, false) {}
 
   GraphManager(TRI_vocbase_t& vocbase, bool isInTransaction)
       : _vocbase(vocbase), _isInTransaction(isInTransaction) {}