remove call to requiresElevatedPrivileges with default value (#5172)

arangod/Actions/ActionFeature.cpp

@@ -38,7 +38,6 @@ ActionFeature::ActionFeature(application_features::ApplicationServer* server)
     : ApplicationFeature(server, "Action"),
       _allowUseDatabase(false) {
   setOptional(true);
-  requiresElevatedPrivileges(false);
   startsAfter("Logger");
 }
 

arangod/Agency/AgencyFeature.cpp

@@ -57,7 +57,6 @@ AgencyFeature::AgencyFeature(application_features::ApplicationServer* server)
       _supervisionGracePeriod(10.0),
       _cmdLineTimings(false) {
   setOptional(true);
-  requiresElevatedPrivileges(false);
   startsAfter("Cluster");
   startsAfter("Database");
   startsAfter("Endpoint");

arangod/Cache/CacheManagerFeature.cpp

@@ -61,7 +61,6 @@ CacheManagerFeature::CacheManagerFeature(
                   : (256 << 20)),
       _rebalancingInterval(static_cast<uint64_t>(2 * 1000 * 1000)) {
   setOptional(true);
-  requiresElevatedPrivileges(false);
   startsAfter("Scheduler");
 }
 

arangod/Cluster/ClusterFeature.cpp

@@ -56,7 +56,6 @@ ClusterFeature::ClusterFeature(application_features::ApplicationServer* server)
       _agencyCallbackRegistry(nullptr),
       _requestedRole(ServerState::RoleEnum::ROLE_UNDEFINED) {
   setOptional(true);
-  requiresElevatedPrivileges(false);
   startsAfter("Authentication");
   startsAfter("CacheManager");
   startsAfter("Logger");

arangod/Cluster/ReplicationTimeoutFeature.cpp

@@ -35,7 +35,6 @@ double ReplicationTimeoutFeature::lowerLimit = 0.5;
 ReplicationTimeoutFeature::ReplicationTimeoutFeature(application_features::ApplicationServer* server)
     : ApplicationFeature(server, "ReplicationTimeout") {
   setOptional(true);
-  requiresElevatedPrivileges(false);
   startsAfter("EngineSelector");
   startsBefore("StorageEngine");
 }

arangod/GeneralServer/AuthenticationFeature.cpp

@@ -53,7 +53,6 @@ AuthenticationFeature::AuthenticationFeature(
       _jwtSecretProgramOption(""),
       _active(true) {
   setOptional(false);
-  requiresElevatedPrivileges(false);
   startsAfter("Random");
 #ifdef USE_ENTERPRISE
   startsAfter("Ldap");

arangod/GeneralServer/GeneralServerFeature.cpp

@@ -104,7 +104,6 @@ GeneralServerFeature::GeneralServerFeature(
       _allowMethodOverride(false),
       _proxyCheck(true) {
   setOptional(true);
-  requiresElevatedPrivileges(false);
   startsAfter("Agency");
   startsAfter("Authentication");
   startsAfter("CheckVersion");

arangod/IResearch/IResearchAnalyzerFeature.cpp

@@ -398,7 +398,6 @@ IResearchAnalyzerFeature::IResearchAnalyzerFeature(
   _analyzers(getStaticAnalyzers()), // load static analyzers
   _started(false) {
   setOptional(true);
-  requiresElevatedPrivileges(false);
   startsAfter("AQLFunctions"); // used for registering IResearch analyzer functions
   startsAfter("SystemDatabase"); // used for getting the system database containing the persisted configuration
 }

arangod/IResearch/IResearchFeature.cpp

@@ -298,7 +298,6 @@ IResearchFeature::IResearchFeature(arangodb::application_features::ApplicationSe
   : ApplicationFeature(server, IResearchFeature::name()),
     _running(false) {
   setOptional(true);
-  requiresElevatedPrivileges(false);
   startsAfter("ViewTypes");
   startsAfter("Logger");
   startsAfter("Database");

arangod/MMFiles/MMFilesCompactionFeature.cpp

@@ -49,7 +49,6 @@ MMFilesCompactionFeature::MMFilesCompactionFeature(ApplicationServer* server)
     _deadSizeThreshold(128 * 1024),
     _deadShare(0.1) { 
   setOptional(true);
-  requiresElevatedPrivileges(false);
   onlyEnabledWith("MMFilesEngine");
   MMFilesCompactionFeature::COMPACTOR = this;
 }

arangod/MMFiles/MMFilesLogfileManager.cpp

@@ -121,7 +121,6 @@ MMFilesLogfileManager::MMFilesLogfileManager(ApplicationServer* server)
   TRI_ASSERT(!_allowWrites);
 
   setOptional(true);
-  requiresElevatedPrivileges(false);
   startsAfter("Database");
   startsAfter("DatabasePath");
   startsAfter("EngineSelector");

arangod/MMFiles/MMFilesPersistentIndexFeature.cpp

@@ -59,7 +59,6 @@ MMFilesPersistentIndexFeature::MMFilesPersistentIndexFeature(
       _db(nullptr), _comparator(nullptr), _path()
 {
   setOptional(true);
-  requiresElevatedPrivileges(false);
   startsAfter("RocksDBOption");
   startsBefore("Database");
   onlyEnabledWith("MMFilesEngine");

arangod/MMFiles/MMFilesWalRecoveryFeature.cpp

@@ -39,7 +39,6 @@ MMFilesWalRecoveryFeature::MMFilesWalRecoveryFeature(ApplicationServer* server)
     : ApplicationFeature(server, "MMFilesWalRecovery") {
 
   setOptional(true);
-  requiresElevatedPrivileges(false);
   startsAfter("Database"); 
   startsAfter("MMFilesLogfileManager");
   startsAfter("MMFilesPersistentIndex");

arangod/Pregel/PregelFeature.cpp

@@ -52,7 +52,6 @@ uint64_t PregelFeature::createExecutionNumber() {
 PregelFeature::PregelFeature(application_features::ApplicationServer* server)
     : application_features::ApplicationFeature(server, "Pregel") {
   setOptional(true);
-  requiresElevatedPrivileges(false);
   startsAfter("WorkMonitor");
   startsAfter("Logger");
   startsAfter("Database");

arangod/Replication/ReplicationFeature.cpp

@@ -45,7 +45,6 @@ ReplicationFeature::ReplicationFeature(ApplicationServer* server)
       _enableActiveFailover(false) {
 
   setOptional(false);
-  requiresElevatedPrivileges(false);
   startsAfter("Database");
   startsAfter("ServerId");
   startsAfter("StorageEngine");

arangod/RestServer/AqlFeature.cpp

@@ -40,7 +40,6 @@ AqlFeature::AqlFeature(
     application_features::ApplicationServer* server)
     : ApplicationFeature(server, "Aql"), _numberLeases(0), _isStopped(false) {
   setOptional(false);
-  requiresElevatedPrivileges(false);
   startsAfter("CacheManager");
   startsAfter("Cluster");
   startsAfter("Database");

arangod/RestServer/CheckVersionFeature.cpp

@@ -45,7 +45,6 @@ CheckVersionFeature::CheckVersionFeature(
       _result(result),
       _nonServerFeatures(nonServerFeatures) {
   setOptional(false);
-  requiresElevatedPrivileges(false);
   startsAfter("Database");
   startsAfter("EngineSelector");
   startsAfter("ServerId");

arangod/RestServer/DatabaseFeature.cpp

@@ -237,7 +237,6 @@ DatabaseFeature::DatabaseFeature(ApplicationServer* server)
       _checkVersion(false),
       _upgrade(false) {
   setOptional(false);
-  requiresElevatedPrivileges(false);
   startsAfter("Authentication");
   startsAfter("CacheManager");
   startsAfter("DatabasePath");

arangod/RestServer/DatabasePathFeature.cpp

@@ -40,7 +40,6 @@ DatabasePathFeature::DatabasePathFeature(ApplicationServer* server)
     : ApplicationFeature(server, "DatabasePath"),
       _requiredDirectoryState("any") {
   setOptional(false);
-  requiresElevatedPrivileges(false);
   startsAfter("FileDescriptors");
   startsAfter("Language");
   startsAfter("Logger");

arangod/RestServer/FileDescriptorsFeature.cpp

@@ -40,7 +40,6 @@ FileDescriptorsFeature::FileDescriptorsFeature(
     application_features::ApplicationServer* server)
     : ApplicationFeature(server, "FileDescriptors"), _descriptorsMinimum(0) {
   setOptional(false);
-  requiresElevatedPrivileges(false);
   startsAfter("Logger");
 }
 

arangod/RestServer/FlushFeature.cpp

@@ -43,7 +43,6 @@ FlushFeature::FlushFeature(ApplicationServer* server)
     : ApplicationFeature(server, "Flush"),
       _flushInterval(1000000) {
   setOptional(false);
-  requiresElevatedPrivileges(false);
   startsAfter("WorkMonitor");
   startsAfter("StorageEngine");
   startsAfter("MMFilesLogfileManager");

arangod/RestServer/InitDatabaseFeature.cpp

@@ -45,7 +45,6 @@ InitDatabaseFeature::InitDatabaseFeature(ApplicationServer* server,
   : ApplicationFeature(server, "InitDatabase"),
     _nonServerFeatures(nonServerFeatures) {
   setOptional(false);
-  requiresElevatedPrivileges(false);
   startsAfter("Logger");
   startsAfter("DatabasePath");
 }

arangod/RestServer/LockfileFeature.cpp

@@ -35,7 +35,6 @@ LockfileFeature::LockfileFeature(
     application_features::ApplicationServer* server)
     : ApplicationFeature(server, "Lockfile") {
   setOptional(false);
-  requiresElevatedPrivileges(false);
   startsAfter("DatabasePath");
 }
 

arangod/RestServer/QueryRegistryFeature.cpp

@@ -45,7 +45,6 @@ QueryRegistryFeature::QueryRegistryFeature(ApplicationServer* server)
       _queryCacheMode("off"),
       _queryCacheEntries(128) {
   setOptional(false);
-  requiresElevatedPrivileges(false);
   startsAfter("DatabasePath");
   startsAfter("Database");
   startsAfter("Cluster");

arangod/RestServer/ServerFeature.cpp

@@ -52,7 +52,6 @@ ServerFeature::ServerFeature(application_features::ApplicationServer* server,
       _result(res),
       _operationMode(OperationMode::MODE_SERVER) {
   setOptional(true);
-  requiresElevatedPrivileges(false);
   startsAfter("Authentication");
   startsAfter("Cluster");
   startsAfter("Database");

arangod/RestServer/ServerIdFeature.cpp

@@ -39,7 +39,6 @@ ServerIdFeature::ServerIdFeature(
     application_features::ApplicationServer* server)
     : ApplicationFeature(server, "ServerId") {
   setOptional(false);
-  requiresElevatedPrivileges(false);
   startsAfter("Database");
   startsAfter("DatabasePath");
 }

arangod/RestServer/TransactionManagerFeature.cpp

@@ -37,7 +37,6 @@ std::unique_ptr<TransactionManager> TransactionManagerFeature::MANAGER;
 TransactionManagerFeature::TransactionManagerFeature(ApplicationServer* server)
     : ApplicationFeature(server, "TransactionManager") {
   setOptional(false);
-  requiresElevatedPrivileges(false);
   startsAfter("EngineSelector");
   startsAfter("WorkMonitor");
 }

arangod/RestServer/TraverserEngineRegistryFeature.cpp

@@ -33,7 +33,6 @@ TraverserEngineRegistryFeature::TraverserEngineRegistryFeature(
     ApplicationServer* server)
     : ApplicationFeature(server, "TraverserEngineRegistry") {
   setOptional(false);
-  requiresElevatedPrivileges(false);
   startsAfter("DatabasePath");
   startsAfter("Database");
 }

arangod/RestServer/UpgradeFeature.cpp

@@ -47,7 +47,6 @@ UpgradeFeature::UpgradeFeature(
       _result(result),
       _nonServerFeatures(nonServerFeatures) {
   setOptional(false);
-  requiresElevatedPrivileges(false);
   startsAfter("CheckVersion");
   startsAfter("Database");
   startsAfter("Cluster");

arangod/RestServer/ViewTypesFeature.cpp

@@ -40,7 +40,6 @@ ViewTypesFeature::ViewTypesFeature(
   application_features::ApplicationServer* server
 ): application_features::ApplicationFeature(server, ViewTypesFeature::name()) {
   setOptional(false);
-  requiresElevatedPrivileges(false);
   startsAfter("WorkMonitor");
 }
 

arangod/RestServer/WorkMonitorFeature.cpp

@@ -30,7 +30,6 @@ WorkMonitorFeature::WorkMonitorFeature(
     application_features::ApplicationServer* server)
     : ApplicationFeature(server, "WorkMonitor") {
   setOptional(false);
-  requiresElevatedPrivileges(false);
 
   startsAfter("ShellColors");
 }

arangod/RocksDBEngine/RocksDBRecoveryManager.cpp

@@ -72,7 +72,6 @@ RocksDBRecoveryManager::RocksDBRecoveryManager(
       _db(nullptr),
       _inRecovery(true) {
   setOptional(true);
-  requiresElevatedPrivileges(false);
   startsAfter("Database");
   startsAfter("RocksDBEngine");
   startsAfter("StorageEngine");

arangod/Scheduler/SchedulerFeature.cpp

@@ -55,7 +55,6 @@ SchedulerFeature::SchedulerFeature(
     application_features::ApplicationServer* server)
     : ApplicationFeature(server, "Scheduler"), _scheduler(nullptr) {
   setOptional(true);
-  requiresElevatedPrivileges(false);
   startsAfter("FileDescriptors");
   startsAfter("Logger");
   startsAfter("Random");

arangod/StorageEngine/EngineSelectorFeature.cpp

@@ -42,7 +42,6 @@ EngineSelectorFeature::EngineSelectorFeature(
       _engine("auto"), 
       _hasStarted(false) {
   setOptional(false);
-  requiresElevatedPrivileges(false);
   startsAfter("DatabasePath");
   startsAfter("Greetings");
   startsAfter("Logger");

arangod/StorageEngine/StorageEngine.h

@@ -76,7 +76,6 @@ class StorageEngine : public application_features::ApplicationFeature {
     // will make sure that exactly one engine is selected at startup
     setOptional(true);
     // storage engines must not use elevated privileges for files etc
-    requiresElevatedPrivileges(false);
 
     startsAfter("CacheManager");
     startsAfter("DatabasePath");

arangod/V8Server/FoxxQueuesFeature.cpp

@@ -34,7 +34,6 @@ FoxxQueuesFeature::FoxxQueuesFeature(
       _pollInterval(1.0),
       _enabled(true) {
   setOptional(true);
-  requiresElevatedPrivileges(false);
   startsAfter("V8Platform");
 }
 

arangod/V8Server/V8DealerFeature.cpp

@@ -107,7 +107,6 @@ V8DealerFeature::V8DealerFeature(
       _gcFinished(false),
       _dynamicContextCreationBlockers(0) {
   setOptional(false);
-  requiresElevatedPrivileges(false);
   startsAfter("Action");
   startsAfter("Authentication");
   startsAfter("Database");

lib/ApplicationFeatures/ConfigFeature.cpp

@@ -47,7 +47,6 @@ ConfigFeature::ConfigFeature(application_features::ApplicationServer* server,
       _checkConfiguration(false),
       _progname(progname) {
   setOptional(false);
-  requiresElevatedPrivileges(false);
   startsAfter("Logger");
   startsAfter("ShellColors");
 }

lib/ApplicationFeatures/DaemonFeature.cpp

@@ -42,7 +42,6 @@ using namespace arangodb::options;
 DaemonFeature::DaemonFeature(application_features::ApplicationServer* server)
     : ApplicationFeature(server, "Daemon") {
   setOptional(true);
-  requiresElevatedPrivileges(false);
   startsAfter("Logger");
   startsAfter("WorkMonitor");
 

lib/ApplicationFeatures/EngineEqualityCheckFeature.cpp

@@ -34,7 +34,6 @@ EngineEqualityCheckFeature::EngineEqualityCheckFeature(
     application_features::ApplicationServer* server)
     : ApplicationFeature(server, "EngineEqualityCheck") {
   setOptional(false);
-  requiresElevatedPrivileges(false);
   startsAfter("Bootstrap");
 }
 

lib/ApplicationFeatures/EnvironmentFeature.cpp

@@ -40,7 +40,6 @@ EnvironmentFeature::EnvironmentFeature(
     application_features::ApplicationServer* server)
     : ApplicationFeature(server, "Environment") {
   setOptional(false);
-  requiresElevatedPrivileges(false);
   startsAfter("Greetings");
   startsAfter("Logger");
   startsAfter("MaxMapCount");

lib/ApplicationFeatures/GreetingsFeature.cpp

@@ -30,7 +30,6 @@ GreetingsFeature::GreetingsFeature(
     application_features::ApplicationServer* server)
     : ApplicationFeature(server, "Greetings") {
   setOptional(false);
-  requiresElevatedPrivileges(false);
   startsAfter("Logger");
 }
 

lib/ApplicationFeatures/JemallocFeature.cpp

@@ -40,7 +40,6 @@ JemallocFeature::JemallocFeature(
     application_features::ApplicationServer* server)
     : ApplicationFeature(server, "Jemalloc"), _defaultPath("./") {
   setOptional(false);
-  requiresElevatedPrivileges(false);
 }
 
 void JemallocFeature::collectOptions(std::shared_ptr<ProgramOptions> options) {

lib/ApplicationFeatures/LanguageFeature.cpp

@@ -46,7 +46,6 @@ LanguageFeature::LanguageFeature(
       _icuDataPtr(nullptr) {
   Instance = this;
   setOptional(false);
-  requiresElevatedPrivileges(false);
   startsAfter("Logger");
 }
 

lib/ApplicationFeatures/MaxMapCountFeature.cpp

@@ -63,7 +63,6 @@ MaxMapCountFeature::MaxMapCountFeature(
     application_features::ApplicationServer* server)
     : ApplicationFeature(server, "MaxMapCount") {
   setOptional(false);
-  requiresElevatedPrivileges(false);
 
   maxMappings = UINT64_MAX;
   mapsFilename.clear();

lib/ApplicationFeatures/NonceFeature.cpp

@@ -34,7 +34,6 @@ using namespace arangodb::options;
 NonceFeature::NonceFeature(application_features::ApplicationServer* server)
     : ApplicationFeature(server, "Nonce"), _size(4 * 1024 * 1024) {
   setOptional(true);
-  requiresElevatedPrivileges(false);
   startsAfter("Logger");
 }
 

lib/ApplicationFeatures/PageSizeFeature.cpp

@@ -32,7 +32,6 @@ PageSizeFeature::PageSizeFeature(
     application_features::ApplicationServer* server)
     : ApplicationFeature(server, "PageSize") {
   setOptional(false);
-  requiresElevatedPrivileges(false);
   startsAfter("Logger");
 }
 

lib/ApplicationFeatures/PrivilegeFeature.cpp

@@ -44,7 +44,6 @@ PrivilegeFeature::PrivilegeFeature(
     : ApplicationFeature(server, "Privilege"),
       _numericUid(0), _numericGid(0) {
   setOptional(true);
-  requiresElevatedPrivileges(false);
   startsAfter("Logger");
 }
 

lib/ApplicationFeatures/RocksDBOptionFeature.cpp

@@ -92,7 +92,6 @@ RocksDBOptionFeature::RocksDBOptionFeature(
 #endif
 
   setOptional(true);
-  requiresElevatedPrivileges(false);
   startsAfter("Daemon");
   startsAfter("DatabasePath");
 }

lib/ApplicationFeatures/ShellColorsFeature.cpp

@@ -60,7 +60,6 @@ ShellColorsFeature::ShellColorsFeature(
     application_features::ApplicationServer* server)
     : ApplicationFeature(server, "ShellColors") {
   setOptional(false);
-  requiresElevatedPrivileges(false);
 }
 
 void ShellColorsFeature::prepare() {

lib/ApplicationFeatures/ShutdownFeature.cpp

@@ -34,7 +34,6 @@ ShutdownFeature::ShutdownFeature(
     std::vector<std::string> const& features)
     : ApplicationFeature(server, "Shutdown") {
   setOptional(true);
-  requiresElevatedPrivileges(false);
   startsAfter("Logger");
 
   for (auto feature : features) {

lib/ApplicationFeatures/SupervisorFeature.cpp

@@ -117,7 +117,6 @@ SupervisorFeature::SupervisorFeature(
     application_features::ApplicationServer* server)
     : ApplicationFeature(server, "Supervisor"), _supervisor(false), _clientPid(0) {
   setOptional(true);
-  requiresElevatedPrivileges(false);
   startsAfter("Daemon");
   startsAfter("Logger");
   startsAfter("WorkMonitor");

lib/ApplicationFeatures/TempFeature.cpp

@@ -36,7 +36,6 @@ TempFeature::TempFeature(application_features::ApplicationServer* server,
                          std::string const& appname)
     : ApplicationFeature(server, "Temp"), _path(), _appname(appname) {
   setOptional(false);
-  requiresElevatedPrivileges(false);
   startsAfter("Logger");
   startsAfter("Random");
 }

lib/ApplicationFeatures/V8PlatformFeature.cpp

@@ -122,7 +122,6 @@ V8PlatformFeature::V8PlatformFeature(
     application_features::ApplicationServer* server)
     : ApplicationFeature(server, "V8Platform") {
   setOptional(true);
-  requiresElevatedPrivileges(false);
   startsAfter("Logger");
 }
 

lib/ApplicationFeatures/VersionFeature.cpp

@@ -35,7 +35,6 @@ VersionFeature::VersionFeature(application_features::ApplicationServer* server)
     : ApplicationFeature(server, "Version"),
       _printVersion(false) {
   setOptional(false);
-  requiresElevatedPrivileges(false);
 
   startsAfter("ShellColors");
 }

lib/Logger/LoggerBufferFeature.cpp

@@ -33,7 +33,6 @@ using namespace arangodb::options;
 LoggerBufferFeature::LoggerBufferFeature(application_features::ApplicationServer* server)
     : ApplicationFeature(server, "LoggerBuffer") {
   setOptional(true);
-  requiresElevatedPrivileges(false);
   startsAfter("Logger");
 }
 

lib/Logger/LoggerFeature.cpp

@@ -41,7 +41,6 @@ LoggerFeature::LoggerFeature(application_features::ApplicationServer* server,
     : ApplicationFeature(server, "Logger"),
       _threaded(threaded) {
   setOptional(false);
-  requiresElevatedPrivileges(false);
 
   startsAfter("ShellColors");
   startsAfter("Version");

lib/Random/RandomFeature.cpp

@@ -35,7 +35,6 @@ RandomFeature::RandomFeature(application_features::ApplicationServer* server)
     : ApplicationFeature(server, "Random"),
       _randomGenerator((uint32_t)RandomGenerator::RandomType::MERSENNE) {
   setOptional(false);
-  requiresElevatedPrivileges(false);
   startsAfter("Logger");
 }
 

lib/Ssl/SslFeature.cpp

@@ -47,7 +47,6 @@ const boost::asio::ssl::detail::openssl_init<true> SslFeature::sslBase{};
 SslFeature::SslFeature(application_features::ApplicationServer* server)
     : ApplicationFeature(server, "Ssl") {
   setOptional(true);
-  requiresElevatedPrivileges(false);
   startsAfter("Logger");
   startsAfter("Greetings");
 }

lib/Ssl/SslServerFeature.cpp

@@ -46,7 +46,6 @@ SslServerFeature::SslServerFeature(
       _sslOptions(boost::asio::ssl::context::default_workarounds | boost::asio::ssl::context::single_dh_use),
       _ecdhCurve("prime256v1") {
   setOptional(true);
-  requiresElevatedPrivileges(false);
   startsAfter("Ssl");
   startsAfter("Logger");
 }