Hawkin
/
arangodb
mirror of https://gitee.com/bigwinds/arangodb
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Don't clone objects just to throw them away.

This commit is contained in:
Alan Plum 2014-07-08 13:46:47 +02:00
parent b2415d7871
commit 292ff5c8e7
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
js/server/modules/org/arangodb/foxx/model.js
View File

@ -85,22 +85,22 @@ Model = function (attributes) {
/// @brief The attributes property is the internal hash containing the model's state.
////////////////////////////////////////////////////////////////////////////////
this.attributes = _.clone(attributes || {});
this.attributes = {};
this.isValid = true;
this.errors = {};
var instance = this;
if (instance.schema) {
_.each(
_.union(_.keys(instance.schema), _.keys(instance.attributes)),
_.union(_.keys(instance.schema), _.keys(attributes)),
function (attributeName) {
instance.set(attributeName, instance.attributes[attributeName]);
instance.set(attributeName, attributes ? attributes[attributeName] : undefined);
}
);
} else {
if (instance.constructor.attributes) {
} else if (instance.constructor.attributes) {
if (attributes) {
instance.attributes = _.pick(
instance.attributes,
attributes,
_.union(
_.keys(metadataSchema),
_.keys(instance.constructor.attributes)
@ -112,6 +112,8 @@ Model = function (attributes) {
instance.attributes[attributeName] = attribute.defaultValue;
}
});
} else if (attributes) {
instance.attributes = _.clone(attributes);
}
};